Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-1710

JSONEvent.getBody should not return null

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.4.0
    • Fix Version/s: 1.6.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently if the charset is not supported, it returns null. We should propagate that error instead of returning null.

      1. FLUME-1710-0.patch
        2 kB
        Ashish Paliwal

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in flume-trunk #676 (See https://builds.apache.org/job/flume-trunk/676/)
          FLUME-1710. JSONEvent.getBody should not return null (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=aa6fb7fbd9273c905a242c045f99a5b114fb3dc0)

          • flume-ng-sdk/src/test/java/org/apache/flume/event/TestEventBuilder.java
          • flume-ng-sdk/src/main/java/org/apache/flume/event/JSONEvent.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in flume-trunk #676 (See https://builds.apache.org/job/flume-trunk/676/ ) FLUME-1710 . JSONEvent.getBody should not return null (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=aa6fb7fbd9273c905a242c045f99a5b114fb3dc0 ) flume-ng-sdk/src/test/java/org/apache/flume/event/TestEventBuilder.java flume-ng-sdk/src/main/java/org/apache/flume/event/JSONEvent.java
          Hide
          hudson Hudson added a comment -

          UNSTABLE: Integrated in Flume-trunk-hbase-98 #35 (See https://builds.apache.org/job/Flume-trunk-hbase-98/35/)
          FLUME-1710. JSONEvent.getBody should not return null (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=aa6fb7fbd9273c905a242c045f99a5b114fb3dc0)

          • flume-ng-sdk/src/test/java/org/apache/flume/event/TestEventBuilder.java
          • flume-ng-sdk/src/main/java/org/apache/flume/event/JSONEvent.java
          Show
          hudson Hudson added a comment - UNSTABLE: Integrated in Flume-trunk-hbase-98 #35 (See https://builds.apache.org/job/Flume-trunk-hbase-98/35/ ) FLUME-1710 . JSONEvent.getBody should not return null (hshreedharan: http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=aa6fb7fbd9273c905a242c045f99a5b114fb3dc0 ) flume-ng-sdk/src/test/java/org/apache/flume/event/TestEventBuilder.java flume-ng-sdk/src/main/java/org/apache/flume/event/JSONEvent.java
          Hide
          hshreedharan Hari Shreedharan added a comment -

          Committed!Thanks Ashish!

          Show
          hshreedharan Hari Shreedharan added a comment - Committed!Thanks Ashish!
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 93ff446ff00f6044e4b58f4594a47c81caf16ddf in flume's branch refs/heads/flume-1.6 from Hari Shreedharan
          [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=93ff446 ]

          FLUME-1710. JSONEvent.getBody should not return null

          (Ashish Paliwal via Hari)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 93ff446ff00f6044e4b58f4594a47c81caf16ddf in flume's branch refs/heads/flume-1.6 from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=93ff446 ] FLUME-1710 . JSONEvent.getBody should not return null (Ashish Paliwal via Hari)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit aa6fb7fbd9273c905a242c045f99a5b114fb3dc0 in flume's branch refs/heads/trunk from Hari Shreedharan
          [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=aa6fb7f ]

          FLUME-1710. JSONEvent.getBody should not return null

          (Ashish Paliwal via Hari)

          Show
          jira-bot ASF subversion and git services added a comment - Commit aa6fb7fbd9273c905a242c045f99a5b114fb3dc0 in flume's branch refs/heads/trunk from Hari Shreedharan [ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=aa6fb7f ] FLUME-1710 . JSONEvent.getBody should not return null (Ashish Paliwal via Hari)
          Hide
          hshreedharan Hari Shreedharan added a comment -

          +1. Running tests and committing.

          Show
          hshreedharan Hari Shreedharan added a comment - +1. Running tests and committing.
          Hide
          paliwalashish Ashish Paliwal added a comment -

          Hari Shreedharan Can you plesae have a look at the patch

          Show
          paliwalashish Ashish Paliwal added a comment - Hari Shreedharan Can you plesae have a look at the patch
          Hide
          paliwalashish Ashish Paliwal added a comment -

          Patch for JSONEvent.getBody should not return null

          Added test case to existing Test class (TestEventBuilder), instead of creating new one.

          Show
          paliwalashish Ashish Paliwal added a comment - Patch for JSONEvent.getBody should not return null Added test case to existing Test class (TestEventBuilder), instead of creating new one.

            People

            • Assignee:
              paliwalashish Ashish Paliwal
              Reporter:
              brocknoland Brock Noland
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development