Flume
  1. Flume
  2. FLUME-1690

Elastic Search Sink doesn't run it's unit tests

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: v1.3.0
    • Fix Version/s: v1.3.0
    • Component/s: Sinks+Sources
    • Labels:
      None

      Description

      I noticed that Elastic Search Sink doesn't run it's unit tests because they end with Test rather than start with Test. It's because top level pom defines this:

      <test.include.pattern>*/Test.java</test.include.pattern>

      1. FLUME-1690.patch
        33 kB
        Hari Shreedharan

        Issue Links

          Activity

          Hide
          Hari Shreedharan added a comment -

          Yep. You are right. Are you looking into this? If not, I can submit a patch.

          Show
          Hari Shreedharan added a comment - Yep. You are right. Are you looking into this? If not, I can submit a patch.
          Hide
          wolfgang hoschek added a comment -

          I'm pretty swamped right now. I think fix is to either add to the test.include.pattern or change the name of test java files.

          Show
          wolfgang hoschek added a comment - I'm pretty swamped right now. I think fix is to either add to the test.include.pattern or change the name of test java files.
          Hide
          Hari Shreedharan added a comment -

          I changed the names of the files.

          Show
          Hari Shreedharan added a comment - I changed the names of the files.
          Hide
          Brock Noland added a comment -

          Thank you for discovering the issue Wolfgang and for the patch Hari! Committed to trunk, 1.4, and 1.3.0!

          Show
          Brock Noland added a comment - Thank you for discovering the issue Wolfgang and for the patch Hari! Committed to trunk, 1.4, and 1.3.0!
          Hide
          Hudson added a comment -

          Integrated in flume-trunk #323 (See https://builds.apache.org/job/flume-trunk/323/)
          FLUME-1690: Elastic Search Sink doesn't run it's unit tests (Revision 107875af508541ab73311c875b6043b2eeab2da3)

          Result = SUCCESS
          brock : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=107875af508541ab73311c875b6043b2eeab2da3
          Files :

          • flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchDynamicSerializer.java
          • flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/ElasticSearchDynamicSerializerTest.java
          • flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchLogStashEventSerializer.java
          • flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchSink.java
          • flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/ElasticSearchSinkTest.java
          • flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/ElasticSearchLogStashEventSerializerTest.java
          Show
          Hudson added a comment - Integrated in flume-trunk #323 (See https://builds.apache.org/job/flume-trunk/323/ ) FLUME-1690 : Elastic Search Sink doesn't run it's unit tests (Revision 107875af508541ab73311c875b6043b2eeab2da3) Result = SUCCESS brock : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=107875af508541ab73311c875b6043b2eeab2da3 Files : flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchDynamicSerializer.java flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/ElasticSearchDynamicSerializerTest.java flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchLogStashEventSerializer.java flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchSink.java flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/ElasticSearchSinkTest.java flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/ElasticSearchLogStashEventSerializerTest.java

            People

            • Assignee:
              Hari Shreedharan
              Reporter:
              wolfgang hoschek
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development