Flume
  1. Flume
  2. FLUME-1537

Dump RollingFileSink's counter status when agent stops

    Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: v1.3.0
    • Component/s: None
    • Labels:
      None

      Description

      RollingFileSink.stop() should dump counter stats. See AvroSink.stop() for example.

      1. FLUME-1537-0.patch
        3 kB
        Ted Malaska
      2. FLUME-1537-1.patch
        5 kB
        Ted Malaska
      3. FLUME-1537-2.patch
        5 kB
        Ted Malaska
      4. FLUME-1537-3.patch
        5 kB
        Ted Malaska

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in flume-trunk #303 (See https://builds.apache.org/job/flume-trunk/303/)
          FLUME-1537. Dump RollingFileSink's counter status when agent stops (Revision f2960cd491c1ac499720fe468b1bb4f3330a726f)

          Result = SUCCESS
          hshreedharan : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=f2960cd491c1ac499720fe468b1bb4f3330a726f
          Files :

          • flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java
          Show
          Hudson added a comment - Integrated in flume-trunk #303 (See https://builds.apache.org/job/flume-trunk/303/ ) FLUME-1537 . Dump RollingFileSink's counter status when agent stops (Revision f2960cd491c1ac499720fe468b1bb4f3330a726f) Result = SUCCESS hshreedharan : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=f2960cd491c1ac499720fe468b1bb4f3330a726f Files : flume-ng-core/src/main/java/org/apache/flume/sink/RollingFileSink.java
          Hide
          Hari Shreedharan added a comment -

          Patch committed, rev: f2960cd491c1ac499720fe468b1bb4f3330a726f. Thanks Ted!

          Show
          Hari Shreedharan added a comment - Patch committed, rev: f2960cd491c1ac499720fe468b1bb4f3330a726f. Thanks Ted!
          Hide
          Ted Malaska added a comment -

          Rebased

          Show
          Ted Malaska added a comment - Rebased
          Hide
          Ted Malaska added a comment -

          There was two things that I changed here:
          1. a final was added by eclipse, so I removed it
          2. I forgot to remove a unused import

          Show
          Ted Malaska added a comment - There was two things that I changed here: 1. a final was added by eclipse, so I removed it 2. I forgot to remove a unused import
          Hide
          Ted Malaska added a comment -

          Change from counterGroup to sinkCounter

          Show
          Ted Malaska added a comment - Change from counterGroup to sinkCounter
          Hide
          Ted Malaska added a comment -

          Added counting for:
          1. events
          2. transaction success
          3. transaction failure

          Also added logging of name and counters at start and stop. Just like NullSink.

          Show
          Ted Malaska added a comment - Added counting for: 1. events 2. transaction success 3. transaction failure Also added logging of name and counters at start and stop. Just like NullSink.
          Hide
          Ted Malaska added a comment -

          Got this one.

          Show
          Ted Malaska added a comment - Got this one.

            People

            • Assignee:
              Ted Malaska
              Reporter:
              Will McQueen
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development