Uploaded image for project: 'Flume'
  1. Flume
  2. FLUME-1511

Scribe-source doesn't handle zero message request correctly.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2.0, 1.3.0
    • Fix Version/s: 1.4.0
    • Component/s: Sinks+Sources
    • Labels:

      Description

      ScribeSource deosn't handle the zero message request correctly.

      When scribed sends zero message request like this:
      sent <0> messages to remote scribe server <dwen:1564>
      The log receiver of scribe-source will return ResultCode.TRY_LATER.
      The return value reultes that scribed falls into infinite loop to
      retry to send the zero message request out, and the whole
      message channel is blocked.

      So I suggest that ResultCode.OK is returned when the size of
      LogEntry list is 0.

        Issue Links

          Activity

          Hide
          dennyy Denny Ye added a comment -

          Patch has submitted. Accept zero message from local Scribe client with normal activity

          Show
          dennyy Denny Ye added a comment - Patch has submitted. Accept zero message from local Scribe client with normal activity
          Hide
          mpercy Mike Percy added a comment -

          +1 lgtm. (I wish we had unit tests for this component)

          Show
          mpercy Mike Percy added a comment - +1 lgtm. (I wish we had unit tests for this component)
          Hide
          mpercy Mike Percy added a comment -

          Pushed to trunk & flume-1.4 branches. Thanks Denny!

          Show
          mpercy Mike Percy added a comment - Pushed to trunk & flume-1.4 branches. Thanks Denny!
          Hide
          hudson Hudson added a comment -

          Integrated in flume-trunk #377 (See https://builds.apache.org/job/flume-trunk/377/)
          FLUME-1511. Scribe-source doesn't handle zero message request correctly. (Revision 46dadc63e540bca52fe87557762506ed55cd5a3a)

          Result = FAILURE
          mpercy : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=46dadc63e540bca52fe87557762506ed55cd5a3a
          Files :

          • flume-ng-sources/flume-scribe-source/src/main/java/org/apache/flume/source/scribe/ScribeSource.java
          Show
          hudson Hudson added a comment - Integrated in flume-trunk #377 (See https://builds.apache.org/job/flume-trunk/377/ ) FLUME-1511 . Scribe-source doesn't handle zero message request correctly. (Revision 46dadc63e540bca52fe87557762506ed55cd5a3a) Result = FAILURE mpercy : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=46dadc63e540bca52fe87557762506ed55cd5a3a Files : flume-ng-sources/flume-scribe-source/src/main/java/org/apache/flume/source/scribe/ScribeSource.java

            People

            • Assignee:
              dennyy Denny Ye
              Reporter:
              is Xin Yu
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development