Flume
  1. Flume
  2. FLUME-1321

BasicTransactionSemantics should never throw from close()

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: v1.1.0
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Release Note:
      Transaction close() now logs error message instead of throwing exceptions.

      Description

      Currently, BasicTransactionSemantics can throw from close(). This means that exceptions will be clobbered in cases where unexpected exceptions are thrown, since close() is idiomatically called in a finally block.

      1. FLUME-1321.2.patch
        2 kB
        Roshan Naik
      2. FLUME-1321.patch
        2 kB
        Roshan Naik

        Issue Links

          Activity

          Mike Percy created issue -
          Mike Percy made changes -
          Field Original Value New Value
          Link This issue breaks FLUME-1322 [ FLUME-1322 ]
          Mike Percy made changes -
          Fix Version/s v1.3.0 [ 12322140 ]
          Fix Version/s v1.2.0 [ 12320243 ]
          Brock Noland made changes -
          Fix Version/s v1.4.0 [ 12323372 ]
          Fix Version/s v1.3.0 [ 12322140 ]
          Roshan Naik made changes -
          Assignee Roshan Naik [ roshan_naik ]
          Roshan Naik made changes -
          Attachment 1321.patch.1 [ 12573207 ]
          Roshan Naik made changes -
          Attachment 1321.patch.1 [ 12573210 ]
          Roshan Naik made changes -
          Attachment 1321.patch.1 [ 12573207 ]
          Roshan Naik made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Release Note Transaction close() now logs error message instead of throwing exceptions.
          Roshan Naik made changes -
          Attachment 1321.patch.1 [ 12573210 ]
          Roshan Naik made changes -
          Attachment FLUME-1321.patch [ 12577695 ]
          Roshan Naik made changes -
          Remote Link This issue links to "Review board (Web Link)" [ 12138 ]
          Roshan Naik made changes -
          Attachment FLUME-1321.2.patch [ 12579034 ]
          Mike Percy made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Roshan Naik made changes -
          Assignee Roshan Naik [ roshan_naik ]
          Mike Percy made changes -
          Fix Version/s v1.4.0 [ 12323372 ]

            People

            • Assignee:
              Unassigned
              Reporter:
              Mike Percy
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:

                Development