Flume
  1. Flume
  2. FLUME-1296

Lifecycle supervisor should check if the monitor service is still running before supervising

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: v1.2.0
    • Fix Version/s: v1.4.0
    • Component/s: Node
    • Labels:
      None

      Description

      Lifecycle supervisor not checking if the executor service is running before supervising can cause RejectedExecutionException, if supervise gets called after the shutdown hook already killed the executor service. It is harmless, but an exception gets dumped to the log.

      Also it would be good to call shutdownNow on the monitor service if it hasn't terminated in a fixed time, say 10s.

      1. FLUME-1296-2.patch
        3 kB
        Hari Shreedharan

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          172d 20h 32m 1 Hari Shreedharan 10/Dec/12 19:21
          Patch Available Patch Available Resolved Resolved
          1h 17m 1 Brock Noland 10/Dec/12 20:39
          Hide
          Hudson added a comment -

          Integrated in flume-trunk #338 (See https://builds.apache.org/job/flume-trunk/338/)
          FLUME-1296: Lifecycle supervisor should check if the monitor service is still running before supervising (Revision 8de68ea636c956b0fe7d2cc18ab21bc26d077405)

          Result = SUCCESS
          brock : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=8de68ea636c956b0fe7d2cc18ab21bc26d077405
          Files :

          • flume-ng-core/src/main/java/org/apache/flume/lifecycle/LifecycleSupervisor.java
          Show
          Hudson added a comment - Integrated in flume-trunk #338 (See https://builds.apache.org/job/flume-trunk/338/ ) FLUME-1296 : Lifecycle supervisor should check if the monitor service is still running before supervising (Revision 8de68ea636c956b0fe7d2cc18ab21bc26d077405) Result = SUCCESS brock : http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=8de68ea636c956b0fe7d2cc18ab21bc26d077405 Files : flume-ng-core/src/main/java/org/apache/flume/lifecycle/LifecycleSupervisor.java
          Brock Noland made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Brock Noland added a comment -

          Thanks Hari! Committed to trunk and 1.4!

          Show
          Brock Noland added a comment - Thanks Hari! Committed to trunk and 1.4!
          Hari Shreedharan made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Assignee Hari Shreedharan [ hshreedharan ]
          Hari Shreedharan made changes -
          Attachment FLUME-1296-2.patch [ 12560243 ]
          Brock Noland made changes -
          Fix Version/s v1.4.0 [ 12323372 ]
          Fix Version/s v1.3.0 [ 12322140 ]
          Mike Percy made changes -
          Fix Version/s v1.3.0 [ 12322140 ]
          Fix Version/s v1.2.0 [ 12320243 ]
          Hari Shreedharan made changes -
          Field Original Value New Value
          Remote Link This issue links to "Reviewboard Link (Web Link)" [ 10207 ]
          Hari Shreedharan created issue -

            People

            • Assignee:
              Hari Shreedharan
              Reporter:
              Hari Shreedharan
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development