Flume
  1. Flume
  2. FLUME-1221

ThriftLegacySource doesn't handle fields -> headers conversions for bytebuffers

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: v1.1.0
    • Fix Version/s: v1.2.0
    • Component/s: Sinks+Sources
    • Labels:
      None

      Description

      The LegacyThriftSource just calls ByteBuffer.toString() when looping through the list of fields and converting them to flume-ng headers. That's incorrect.

        Activity

        Joe Crobak created issue -
        Hide
        Joe Crobak added a comment -

        don't think I can assign to myself, but patch is forth-coming.

        Show
        Joe Crobak added a comment - don't think I can assign to myself, but patch is forth-coming.
        Hide
        Joe Crobak added a comment -
        Show
        Joe Crobak added a comment - Patch here: https://reviews.apache.org/r/5189/
        Joe Crobak made changes -
        Field Original Value New Value
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Mike Percy added a comment -

        +1

        Show
        Mike Percy added a comment - +1
        Hide
        Joe Crobak added a comment -

        thanks Mike - what do we have to do to ge this committed?

        Show
        Joe Crobak added a comment - thanks Mike - what do we have to do to ge this committed?
        Hide
        Mike Percy added a comment -

        Hey Joe, I'll commit it. I am following up with INFRA about permissions issues at the moment but I expect it should not take that long to resolve that.

        Show
        Mike Percy added a comment - Hey Joe, I'll commit it. I am following up with INFRA about permissions issues at the moment but I expect it should not take that long to resolve that.
        Hide
        Mike Percy added a comment -

        Hi Joe,
        Please attach the patch to the JIRA.

        Thanks,
        Mike

        Show
        Mike Percy added a comment - Hi Joe, Please attach the patch to the JIRA. Thanks, Mike
        Joe Crobak made changes -
        Attachment FLUME-1221.patch [ 12530080 ]
        Hide
        Mike Percy added a comment -

        Patch committed. Thanks for the contribution, Joe!

        Show
        Mike Percy added a comment - Patch committed. Thanks for the contribution, Joe!
        Mike Percy made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Mike Percy made changes -
        Fix Version/s v1.2.0 [ 12320243 ]
        Hide
        Hudson added a comment -

        Integrated in flume-trunk #214 (See https://builds.apache.org/job/flume-trunk/214/)
        FLUME-1221. Thrift Legacy Source improperly converts Flume 0.9 event headers to 1.x format.

        (Joe Crobak via Mike Percy) (Revision 1343934)

        Result = SUCCESS
        mpercy : http://svn.apache.org/viewvc/?view=rev&rev=1343934
        Files :

        • /incubator/flume/trunk/flume-ng-legacy-sources/flume-thrift-source/src/main/java/org/apache/flume/source/thriftLegacy/ThriftLegacySource.java
        • /incubator/flume/trunk/flume-ng-legacy-sources/flume-thrift-source/src/test/java/org/apache/flume/source/thriftLegacy/TestThriftLegacySource.java
        Show
        Hudson added a comment - Integrated in flume-trunk #214 (See https://builds.apache.org/job/flume-trunk/214/ ) FLUME-1221 . Thrift Legacy Source improperly converts Flume 0.9 event headers to 1.x format. (Joe Crobak via Mike Percy) (Revision 1343934) Result = SUCCESS mpercy : http://svn.apache.org/viewvc/?view=rev&rev=1343934 Files : /incubator/flume/trunk/flume-ng-legacy-sources/flume-thrift-source/src/main/java/org/apache/flume/source/thriftLegacy/ThriftLegacySource.java /incubator/flume/trunk/flume-ng-legacy-sources/flume-thrift-source/src/test/java/org/apache/flume/source/thriftLegacy/TestThriftLegacySource.java
        Mike Percy made changes -
        Assignee Joe Crobak [ joecrobak ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        43m 12s 1 Joe Crobak 22/May/12 03:49
        Patch Available Patch Available Resolved Resolved
        7d 16h 32m 1 Mike Percy 29/May/12 20:22

          People

          • Assignee:
            Joe Crobak
            Reporter:
            Joe Crobak
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development