Flume
  1. Flume
  2. FLUME-1194

RecoverableMemoryChannel prop misspelled -- "rentention" should be "retention"

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: v1.2.0
    • Fix Version/s: v1.2.0
    • Component/s: Channel
    • Labels:
      None

      Description

      I suggest replacing all occurrences of "rentention" with "retention" (unless you're talking about "the private retention of publicly-generated land values"... http://www.wealthandwant.com/themes/Rentention.html)

      These substitutions include:

      1) The var names:

      long minLogRetentionPeriod = context.getLong(WAL_MIN_RENTENTION_PERIOD, WAL.DEFAULT_MIN_LOG_RENTENTION_PERIOD);
      ==> long minLogRetentionPeriod = context.getLong(WAL_MIN_RETENTION_PERIOD, WAL.DEFAULT_MIN_LOG_RETENTION_PERIOD);

      2) The prop name:

      "wal.minRententionPeriod" => "wal.minRetentionPeriod"

      Thank you.

      1. FLUME-1194.patch
        3 kB
        Juhani Connolly

        Activity

        Hide
        Juhani Connolly added a comment -

        this is a trivial patch to fix the spelling so skipping the review board.

        if necessary I can post it up

        Show
        Juhani Connolly added a comment - this is a trivial patch to fix the spelling so skipping the review board. if necessary I can post it up
        Hide
        Hari Shreedharan added a comment -

        +1 - Please go ahead and commit it(I am officially a committer now, but don't have commit access yet - so please go ahead).

        Show
        Hari Shreedharan added a comment - +1 - Please go ahead and commit it(I am officially a committer now, but don't have commit access yet - so please go ahead).
        Hide
        Juhani Connolly added a comment -

        Committed to trunk

        Show
        Juhani Connolly added a comment - Committed to trunk
        Hide
        Hudson added a comment -

        Integrated in flume-trunk #212 (See https://builds.apache.org/job/flume-trunk/212/)
        FLUME-1194 RecoverableMemoryChannel prop misspelled – "rentention" should be "retention"

        (Juhani Connolly) (Revision 1342066)

        Result = SUCCESS
        juhanic : http://svn.apache.org/viewvc/?view=rev&rev=1342066
        Files :

        • /incubator/flume/trunk/flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/RecoverableMemoryChannel.java
        • /incubator/flume/trunk/flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WAL.java
        Show
        Hudson added a comment - Integrated in flume-trunk #212 (See https://builds.apache.org/job/flume-trunk/212/ ) FLUME-1194 RecoverableMemoryChannel prop misspelled – "rentention" should be "retention" (Juhani Connolly) (Revision 1342066) Result = SUCCESS juhanic : http://svn.apache.org/viewvc/?view=rev&rev=1342066 Files : /incubator/flume/trunk/flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/RecoverableMemoryChannel.java /incubator/flume/trunk/flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WAL.java

          People

          • Assignee:
            Unassigned
            Reporter:
            Will McQueen
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development