Flume
  1. Flume
  2. FLUME-1188

TestRecoverableMemoryChannel.testThreaded can fail sometimes

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: v1.2.0
    • Fix Version/s: v1.2.0
    • Component/s: Channel
    • Labels:
      None

      Description

      Implement same changes as FLUME-1184 for recoverable memory channel

        Issue Links

          Activity

          Brock Noland created issue -
          Brock Noland made changes -
          Field Original Value New Value
          Link This issue relates to FLUME-1184 [ FLUME-1184 ]
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/5056/
          -----------------------------------------------------------

          Review request for Flume.

          Summary
          -------

          Implement the same changes as FLUME-1184 for RecoverableMemoryChannel.

          This addresses bug FLUME-1188.
          https://issues.apache.org/jira/browse/FLUME-1188

          Diffs


          flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/TestRecoverableMemoryChannel.java 654db8c

          Diff: https://reviews.apache.org/r/5056/diff

          Testing
          -------

          Tests pass.

          Thanks,

          Brock

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5056/ ----------------------------------------------------------- Review request for Flume. Summary ------- Implement the same changes as FLUME-1184 for RecoverableMemoryChannel. This addresses bug FLUME-1188 . https://issues.apache.org/jira/browse/FLUME-1188 Diffs flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/TestRecoverableMemoryChannel.java 654db8c Diff: https://reviews.apache.org/r/5056/diff Testing ------- Tests pass. Thanks, Brock
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/5056/#review7661
          -----------------------------------------------------------

          Ship it!

          +1. Please attach the patch to the Jira.

          • Arvind

          On 2012-05-07 20:34:38, Brock Noland wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/5056/

          -----------------------------------------------------------

          (Updated 2012-05-07 20:34:38)

          Review request for Flume.

          Summary

          -------

          Implement the same changes as FLUME-1184 for RecoverableMemoryChannel.

          This addresses bug FLUME-1188.

          https://issues.apache.org/jira/browse/FLUME-1188

          Diffs

          -----

          flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/TestRecoverableMemoryChannel.java 654db8c

          Diff: https://reviews.apache.org/r/5056/diff

          Testing

          -------

          Tests pass.

          Thanks,

          Brock

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5056/#review7661 ----------------------------------------------------------- Ship it! +1. Please attach the patch to the Jira. Arvind On 2012-05-07 20:34:38, Brock Noland wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5056/ ----------------------------------------------------------- (Updated 2012-05-07 20:34:38) Review request for Flume. Summary ------- Implement the same changes as FLUME-1184 for RecoverableMemoryChannel. This addresses bug FLUME-1188 . https://issues.apache.org/jira/browse/FLUME-1188 Diffs ----- flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/TestRecoverableMemoryChannel.java 654db8c Diff: https://reviews.apache.org/r/5056/diff Testing ------- Tests pass. Thanks, Brock
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/5056/
          -----------------------------------------------------------

          (Updated 2012-05-08 05:11:34.153643)

          Review request for Flume.

          Changes
          -------

          Very minor changes. Producers wait until consumers start and removed two unused lines of code.

          Summary
          -------

          Implement the same changes as FLUME-1184 for RecoverableMemoryChannel.

          This addresses bug FLUME-1188.
          https://issues.apache.org/jira/browse/FLUME-1188

          Diffs (updated)


          flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WAL.java a533277
          flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/TestRecoverableMemoryChannel.java 654db8c

          Diff: https://reviews.apache.org/r/5056/diff

          Testing
          -------

          Tests pass.

          Thanks,

          Brock

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5056/ ----------------------------------------------------------- (Updated 2012-05-08 05:11:34.153643) Review request for Flume. Changes ------- Very minor changes. Producers wait until consumers start and removed two unused lines of code. Summary ------- Implement the same changes as FLUME-1184 for RecoverableMemoryChannel. This addresses bug FLUME-1188 . https://issues.apache.org/jira/browse/FLUME-1188 Diffs (updated) flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WAL.java a533277 flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/TestRecoverableMemoryChannel.java 654db8c Diff: https://reviews.apache.org/r/5056/diff Testing ------- Tests pass. Thanks, Brock
          Hide
          Brock Noland added a comment -

          Patch from RB.

          Show
          Brock Noland added a comment - Patch from RB.
          Brock Noland made changes -
          Attachment FLUME-1188-1.patch [ 12525956 ]
          Hide
          jiraposter@reviews.apache.org added a comment -

          On 2012-05-07 23:12:46, Arvind Prabhakar wrote:

          > +1. Please attach the patch to the Jira.

          I made some minor changes so I added here in case you wanted to see them easily. Patch is on JIRA now as well.

          • Brock

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/5056/#review7661
          -----------------------------------------------------------

          On 2012-05-08 05:11:34, Brock Noland wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/5056/

          -----------------------------------------------------------

          (Updated 2012-05-08 05:11:34)

          Review request for Flume.

          Summary

          -------

          Implement the same changes as FLUME-1184 for RecoverableMemoryChannel.

          This addresses bug FLUME-1188.

          https://issues.apache.org/jira/browse/FLUME-1188

          Diffs

          -----

          flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WAL.java a533277

          flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/TestRecoverableMemoryChannel.java 654db8c

          Diff: https://reviews.apache.org/r/5056/diff

          Testing

          -------

          Tests pass.

          Thanks,

          Brock

          Show
          jiraposter@reviews.apache.org added a comment - On 2012-05-07 23:12:46, Arvind Prabhakar wrote: > +1. Please attach the patch to the Jira. I made some minor changes so I added here in case you wanted to see them easily. Patch is on JIRA now as well. Brock ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5056/#review7661 ----------------------------------------------------------- On 2012-05-08 05:11:34, Brock Noland wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5056/ ----------------------------------------------------------- (Updated 2012-05-08 05:11:34) Review request for Flume. Summary ------- Implement the same changes as FLUME-1184 for RecoverableMemoryChannel. This addresses bug FLUME-1188 . https://issues.apache.org/jira/browse/FLUME-1188 Diffs ----- flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WAL.java a533277 flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/TestRecoverableMemoryChannel.java 654db8c Diff: https://reviews.apache.org/r/5056/diff Testing ------- Tests pass. Thanks, Brock
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/5056/#review7670
          -----------------------------------------------------------

          Ship it!

          +1

          • Arvind

          On 2012-05-08 05:11:34, Brock Noland wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/5056/

          -----------------------------------------------------------

          (Updated 2012-05-08 05:11:34)

          Review request for Flume.

          Summary

          -------

          Implement the same changes as FLUME-1184 for RecoverableMemoryChannel.

          This addresses bug FLUME-1188.

          https://issues.apache.org/jira/browse/FLUME-1188

          Diffs

          -----

          flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WAL.java a533277

          flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/TestRecoverableMemoryChannel.java 654db8c

          Diff: https://reviews.apache.org/r/5056/diff

          Testing

          -------

          Tests pass.

          Thanks,

          Brock

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5056/#review7670 ----------------------------------------------------------- Ship it! +1 Arvind On 2012-05-08 05:11:34, Brock Noland wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5056/ ----------------------------------------------------------- (Updated 2012-05-08 05:11:34) Review request for Flume. Summary ------- Implement the same changes as FLUME-1184 for RecoverableMemoryChannel. This addresses bug FLUME-1188 . https://issues.apache.org/jira/browse/FLUME-1188 Diffs ----- flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WAL.java a533277 flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/TestRecoverableMemoryChannel.java 654db8c Diff: https://reviews.apache.org/r/5056/diff Testing ------- Tests pass. Thanks, Brock
          Hide
          Arvind Prabhakar added a comment -

          Patch committed. Thanks Brock!

          Show
          Arvind Prabhakar added a comment - Patch committed. Thanks Brock!
          Arvind Prabhakar made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s v1.2.0 [ 12320243 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in flume-trunk #199 (See https://builds.apache.org/job/flume-trunk/199/)
          FLUME-1188. TestRecoverableMemoryChannel.testThreaded can fail sometimes.

          (Brock Noland via Arvind Prabhakar) (Revision 1335364)

          Result = SUCCESS
          arvind : http://svn.apache.org/viewvc/?view=rev&rev=1335364
          Files :

          • /incubator/flume/trunk/flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WAL.java
          • /incubator/flume/trunk/flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/TestRecoverableMemoryChannel.java
          Show
          Hudson added a comment - Integrated in flume-trunk #199 (See https://builds.apache.org/job/flume-trunk/199/ ) FLUME-1188 . TestRecoverableMemoryChannel.testThreaded can fail sometimes. (Brock Noland via Arvind Prabhakar) (Revision 1335364) Result = SUCCESS arvind : http://svn.apache.org/viewvc/?view=rev&rev=1335364 Files : /incubator/flume/trunk/flume-ng-channels/flume-recoverable-memory-channel/src/main/java/org/apache/flume/channel/recoverable/memory/wal/WAL.java /incubator/flume/trunk/flume-ng-channels/flume-recoverable-memory-channel/src/test/java/org/apache/flume/channel/recoverable/memory/TestRecoverableMemoryChannel.java

            People

            • Assignee:
              Brock Noland
              Reporter:
              Brock Noland
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development