[FLUME-1187] PropertiesFileConfigurationProvider provides poor error messages for misconfiguration

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 1.1.0
• Component/s: Configuration, Technical Debt
• Assignee: Unassigned
• Reporter: Eric Sammer
• Created: 07/May/12 17:03
• Updated: 07/May/12 17:03

Description

We need to beef up the proactive configuration sanity checking of PFCP. We have some blind references that can generate NPEs. One example of this is if a source doesn't specify the channels property.

2012-05-07 01:15:14,347 INFO properties.PropertiesFileConfigurationProvider: Creating channels
2012-05-07 01:15:14,355 INFO properties.PropertiesFileConfigurationProvider: created channel XXXXX
2012-05-07 01:15:14,368 ERROR properties.PropertiesFileConfigurationProvider: Failed to load configuration data. Exception follows.
java.lang.NullPointerException
        at org.apache.flume.conf.properties.PropertiesFileConfigurationProvider.loadSources(PropertiesFileConfigurationProvider.java:304)
        at org.apache.flume.conf.properties.PropertiesFileConfigurationProvider.load(PropertiesFileConfigurationProvider.java:219)
        at org.apache.flume.conf.file.AbstractFileConfigurationProvider.doLoad(AbstractFileConfigurationProvider.java:124)
        at org.apache.flume.conf.file.AbstractFileConfigurationProvider.access$300(AbstractFileConfigurationProvider.java:38)
        at org.apache.flume.conf.file.AbstractFileConfigurationProvider$FileWatcherRunnable.run(AbstractFileConfigurationProvider.java:203)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
        at java.util.concurrent.FutureTask$Sync.innerRunAndReset(FutureTask.java:317)
        at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:150)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$101(ScheduledThreadPoolExecutor.java:98)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.runPeriodic(ScheduledThreadPoolExecutor.java:180)
        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:204)
        at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
        at java.lang.Thread.run(Thread.java:662)