Flume
  1. Flume
  2. FLUME-1177

Maven deps on flume-ng-configuration module are brought in transitively instead of directly

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: v1.2.0
    • Component/s: None
    • Labels:
      None

      Description

      The maven dependencies on flume-ng-configuration are not brought in directly by the modules that reference configuration-related objects, such as Context. This also affects IDEs such as Netbeans, which will not auto-complete transitive dependencies.

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5012/
        -----------------------------------------------------------

        Review request for Flume.

        Summary
        -------

        Add direct Maven deps on flume-ng-configuration

        This addresses bug FLUME-1177.
        https://issues.apache.org/jira/browse/FLUME-1177

        Diffs


        flume-ng-channels/flume-file-channel/pom.xml e8155be
        flume-ng-channels/flume-jdbc-channel/pom.xml 8e82583
        flume-ng-channels/flume-recoverable-memory-channel/pom.xml 820158c
        flume-ng-core/pom.xml b798b34
        flume-ng-legacy-sources/flume-avro-source/pom.xml 216e479
        flume-ng-legacy-sources/flume-thrift-source/pom.xml 70b67a6
        flume-ng-node/pom.xml da0d15e
        flume-ng-sinks/flume-hdfs-sink/pom.xml c85ea44
        flume-ng-sinks/flume-irc-sink/pom.xml d935faf

        Diff: https://reviews.apache.org/r/5012/diff

        Testing
        -------

        Thanks,

        Mike

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5012/ ----------------------------------------------------------- Review request for Flume. Summary ------- Add direct Maven deps on flume-ng-configuration This addresses bug FLUME-1177 . https://issues.apache.org/jira/browse/FLUME-1177 Diffs flume-ng-channels/flume-file-channel/pom.xml e8155be flume-ng-channels/flume-jdbc-channel/pom.xml 8e82583 flume-ng-channels/flume-recoverable-memory-channel/pom.xml 820158c flume-ng-core/pom.xml b798b34 flume-ng-legacy-sources/flume-avro-source/pom.xml 216e479 flume-ng-legacy-sources/flume-thrift-source/pom.xml 70b67a6 flume-ng-node/pom.xml da0d15e flume-ng-sinks/flume-hdfs-sink/pom.xml c85ea44 flume-ng-sinks/flume-irc-sink/pom.xml d935faf Diff: https://reviews.apache.org/r/5012/diff Testing ------- Thanks, Mike
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/5012/#review7714
        -----------------------------------------------------------

        Ship it!

        lgtm

        • Brock

        On 2012-05-04 04:59:59, Mike Percy wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/5012/

        -----------------------------------------------------------

        (Updated 2012-05-04 04:59:59)

        Review request for Flume.

        Summary

        -------

        Add direct Maven deps on flume-ng-configuration

        This addresses bug FLUME-1177.

        https://issues.apache.org/jira/browse/FLUME-1177

        Diffs

        -----

        flume-ng-channels/flume-file-channel/pom.xml e8155be

        flume-ng-channels/flume-jdbc-channel/pom.xml 8e82583

        flume-ng-channels/flume-recoverable-memory-channel/pom.xml 820158c

        flume-ng-core/pom.xml b798b34

        flume-ng-legacy-sources/flume-avro-source/pom.xml 216e479

        flume-ng-legacy-sources/flume-thrift-source/pom.xml 70b67a6

        flume-ng-node/pom.xml da0d15e

        flume-ng-sinks/flume-hdfs-sink/pom.xml c85ea44

        flume-ng-sinks/flume-irc-sink/pom.xml d935faf

        Diff: https://reviews.apache.org/r/5012/diff

        Testing

        -------

        Thanks,

        Mike

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5012/#review7714 ----------------------------------------------------------- Ship it! lgtm Brock On 2012-05-04 04:59:59, Mike Percy wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5012/ ----------------------------------------------------------- (Updated 2012-05-04 04:59:59) Review request for Flume. Summary ------- Add direct Maven deps on flume-ng-configuration This addresses bug FLUME-1177 . https://issues.apache.org/jira/browse/FLUME-1177 Diffs ----- flume-ng-channels/flume-file-channel/pom.xml e8155be flume-ng-channels/flume-jdbc-channel/pom.xml 8e82583 flume-ng-channels/flume-recoverable-memory-channel/pom.xml 820158c flume-ng-core/pom.xml b798b34 flume-ng-legacy-sources/flume-avro-source/pom.xml 216e479 flume-ng-legacy-sources/flume-thrift-source/pom.xml 70b67a6 flume-ng-node/pom.xml da0d15e flume-ng-sinks/flume-hdfs-sink/pom.xml c85ea44 flume-ng-sinks/flume-irc-sink/pom.xml d935faf Diff: https://reviews.apache.org/r/5012/diff Testing ------- Thanks, Mike
        Hide
        Brock Noland added a comment -

        Committed in 1335901.

        Show
        Brock Noland added a comment - Committed in 1335901.
        Hide
        Hudson added a comment -

        Integrated in flume-trunk #201 (See https://builds.apache.org/job/flume-trunk/201/)
        FLUME-1177: Maven deps on flume-ng-configuration module are brought in transitively instead of directly

        (Mike Percy via Brock Noland) (Revision 1335901)

        Result = SUCCESS
        brock : http://svn.apache.org/viewvc/?view=rev&rev=1335901
        Files :

        • /incubator/flume/trunk/flume-ng-channels/flume-file-channel/pom.xml
        • /incubator/flume/trunk/flume-ng-channels/flume-jdbc-channel/pom.xml
        • /incubator/flume/trunk/flume-ng-channels/flume-recoverable-memory-channel/pom.xml
        • /incubator/flume/trunk/flume-ng-core/pom.xml
        • /incubator/flume/trunk/flume-ng-legacy-sources/flume-avro-source/pom.xml
        • /incubator/flume/trunk/flume-ng-legacy-sources/flume-thrift-source/pom.xml
        • /incubator/flume/trunk/flume-ng-node/pom.xml
        • /incubator/flume/trunk/flume-ng-sinks/flume-hdfs-sink/pom.xml
        • /incubator/flume/trunk/flume-ng-sinks/flume-irc-sink/pom.xml
        Show
        Hudson added a comment - Integrated in flume-trunk #201 (See https://builds.apache.org/job/flume-trunk/201/ ) FLUME-1177 : Maven deps on flume-ng-configuration module are brought in transitively instead of directly (Mike Percy via Brock Noland) (Revision 1335901) Result = SUCCESS brock : http://svn.apache.org/viewvc/?view=rev&rev=1335901 Files : /incubator/flume/trunk/flume-ng-channels/flume-file-channel/pom.xml /incubator/flume/trunk/flume-ng-channels/flume-jdbc-channel/pom.xml /incubator/flume/trunk/flume-ng-channels/flume-recoverable-memory-channel/pom.xml /incubator/flume/trunk/flume-ng-core/pom.xml /incubator/flume/trunk/flume-ng-legacy-sources/flume-avro-source/pom.xml /incubator/flume/trunk/flume-ng-legacy-sources/flume-thrift-source/pom.xml /incubator/flume/trunk/flume-ng-node/pom.xml /incubator/flume/trunk/flume-ng-sinks/flume-hdfs-sink/pom.xml /incubator/flume/trunk/flume-ng-sinks/flume-irc-sink/pom.xml

          People

          • Assignee:
            Mike Percy
            Reporter:
            Mike Percy
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development