Flume
  1. Flume
  2. FLUME-1164

Configure should be called after stopping all events.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: v1.1.0
    • Fix Version/s: v1.2.0
    • Component/s: Configuration
    • Labels:
      None

      Description

      After a reconfiguration event (config file is modified), the configure() method is called on the same component object (unless its name or type has changed in the config file). For example, changing the config file to add a new property or changing an existing property for source component instance r1 will cause the object's configure() method to be called again.

      We should consider whether this should be expected behavior, or if a reconfig event should result in instantiating new objects for all components specified in the config file.

      For reference, please see:
      FLUME-932
      FLUME-933
      FLUME-1036
      FLUME-1162

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in flume-trunk #202 (See https://builds.apache.org/job/flume-trunk/202/)
          FLUME-1164. Configure should be called after stopping all components.

          (Hari Shreedharan via Arvind Prabhakar) (Revision 1336416)

          Result = SUCCESS
          arvind : http://svn.apache.org/viewvc/?view=rev&rev=1336416
          Files :

          • /incubator/flume/trunk/flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java
          • /incubator/flume/trunk/flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java
          • /incubator/flume/trunk/flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/NodeConfigurationAware.java
          • /incubator/flume/trunk/flume-ng-node/src/test/java/org/apache/flume/conf/properties/TestPropertiesFileConfigurationProvider.java
          Show
          Hudson added a comment - Integrated in flume-trunk #202 (See https://builds.apache.org/job/flume-trunk/202/ ) FLUME-1164 . Configure should be called after stopping all components. (Hari Shreedharan via Arvind Prabhakar) (Revision 1336416) Result = SUCCESS arvind : http://svn.apache.org/viewvc/?view=rev&rev=1336416 Files : /incubator/flume/trunk/flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java /incubator/flume/trunk/flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java /incubator/flume/trunk/flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/NodeConfigurationAware.java /incubator/flume/trunk/flume-ng-node/src/test/java/org/apache/flume/conf/properties/TestPropertiesFileConfigurationProvider.java
          Hide
          Arvind Prabhakar added a comment -

          Patch committed. Thanks Hari!

          Show
          Arvind Prabhakar added a comment - Patch committed. Thanks Hari!
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/4939/
          -----------------------------------------------------------

          (Updated 2012-05-09 19:26:00.814385)

          Review request for Flume.

          Changes
          -------

          Rebased. updated a test class to support the new interface.

          Summary
          -------

          Refactored the NodeConfigurationAware interface, into 2 functions for starting and stopping components.

          This addresses bug FLUME-1164.
          https://issues.apache.org/jira/browse/FLUME-1164

          Diffs (updated)


          flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 878feda
          flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java 292ebcd
          flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/NodeConfigurationAware.java 47249e9
          flume-ng-node/src/test/java/org/apache/flume/conf/properties/TestPropertiesFileConfigurationProvider.java 48659c4

          Diff: https://reviews.apache.org/r/4939/diff

          Testing
          -------

          Thanks,

          Hari

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4939/ ----------------------------------------------------------- (Updated 2012-05-09 19:26:00.814385) Review request for Flume. Changes ------- Rebased. updated a test class to support the new interface. Summary ------- Refactored the NodeConfigurationAware interface, into 2 functions for starting and stopping components. This addresses bug FLUME-1164 . https://issues.apache.org/jira/browse/FLUME-1164 Diffs (updated) flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 878feda flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java 292ebcd flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/NodeConfigurationAware.java 47249e9 flume-ng-node/src/test/java/org/apache/flume/conf/properties/TestPropertiesFileConfigurationProvider.java 48659c4 Diff: https://reviews.apache.org/r/4939/diff Testing ------- Thanks, Hari
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/4939/#review7719
          -----------------------------------------------------------

          Ship it!

          +1

          Please rebase the patch and attach it to the Jira.

          • Arvind

          On 2012-04-30 21:33:09, Hari Shreedharan wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/4939/

          -----------------------------------------------------------

          (Updated 2012-04-30 21:33:09)

          Review request for Flume.

          Summary

          -------

          Refactored the NodeConfigurationAware interface, into 2 functions for starting and stopping components.

          This addresses bug FLUME-1164.

          https://issues.apache.org/jira/browse/FLUME-1164

          Diffs

          -----

          flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java c6ae2f5

          flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java 07c3d0b

          flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/NodeConfigurationAware.java 47249e9

          Diff: https://reviews.apache.org/r/4939/diff

          Testing

          -------

          Thanks,

          Hari

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4939/#review7719 ----------------------------------------------------------- Ship it! +1 Please rebase the patch and attach it to the Jira. Arvind On 2012-04-30 21:33:09, Hari Shreedharan wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4939/ ----------------------------------------------------------- (Updated 2012-04-30 21:33:09) Review request for Flume. Summary ------- Refactored the NodeConfigurationAware interface, into 2 functions for starting and stopping components. This addresses bug FLUME-1164 . https://issues.apache.org/jira/browse/FLUME-1164 Diffs ----- flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java c6ae2f5 flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java 07c3d0b flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/NodeConfigurationAware.java 47249e9 Diff: https://reviews.apache.org/r/4939/diff Testing ------- Thanks, Hari
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/4939/
          -----------------------------------------------------------

          Review request for Flume.

          Summary
          -------

          Refactored the NodeConfigurationAware interface, into 2 functions for starting and stopping components.

          This addresses bug FLUME-1164.
          https://issues.apache.org/jira/browse/FLUME-1164

          Diffs


          flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java c6ae2f5
          flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java 07c3d0b
          flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/NodeConfigurationAware.java 47249e9

          Diff: https://reviews.apache.org/r/4939/diff

          Testing
          -------

          Thanks,

          Hari

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4939/ ----------------------------------------------------------- Review request for Flume. Summary ------- Refactored the NodeConfigurationAware interface, into 2 functions for starting and stopping components. This addresses bug FLUME-1164 . https://issues.apache.org/jira/browse/FLUME-1164 Diffs flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java c6ae2f5 flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java 07c3d0b flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/NodeConfigurationAware.java 47249e9 Diff: https://reviews.apache.org/r/4939/diff Testing ------- Thanks, Hari
          Hide
          Hari Shreedharan added a comment -

          Note that this affects v1.1.0.

          Show
          Hari Shreedharan added a comment - Note that this affects v1.1.0.

            People

            • Assignee:
              Hari Shreedharan
              Reporter:
              Will McQueen
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development