Flume
  1. Flume
  2. FLUME-1135

flume-docs exclude is not sufficient for rat

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: v1.2.0
    • Component/s: Build
    • Labels:
      None

      Description

      The rat exclude in the top-level pom is not sufficient to ignore generated docs if rat is run without first running mvn clean.

        Activity

        Hide
        Hudson added a comment -

        Integrated in flume-trunk #180 (See https://builds.apache.org/job/flume-trunk/180/)
        FLUME-1135. Module flume-docs exclude is not sufficient for rat.

        (Mike Percy via Arvind Prabhakar) (Revision 1329367)

        Result = SUCCESS
        arvind : http://svn.apache.org/viewvc/?view=rev&rev=1329367
        Files :

        • /incubator/flume/trunk/pom.xml
        Show
        Hudson added a comment - Integrated in flume-trunk #180 (See https://builds.apache.org/job/flume-trunk/180/ ) FLUME-1135 . Module flume-docs exclude is not sufficient for rat. (Mike Percy via Arvind Prabhakar) (Revision 1329367) Result = SUCCESS arvind : http://svn.apache.org/viewvc/?view=rev&rev=1329367 Files : /incubator/flume/trunk/pom.xml
        Hide
        Arvind Prabhakar added a comment -

        Patch committed. Thanks Mike!

        Show
        Arvind Prabhakar added a comment - Patch committed. Thanks Mike!
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4796/#review7149
        -----------------------------------------------------------

        Ship it!

        +1

        • Arvind

        On 2012-04-19 04:12:44, Mike Percy wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4796/

        -----------------------------------------------------------

        (Updated 2012-04-19 04:12:44)

        Review request for Flume.

        Summary

        -------

        The exclude pattern used so rat doesn't complain about the site docs needs to be tweaked.

        This addresses bug FLUME-1135.

        https://issues.apache.org/jira/browse/FLUME-1135

        Diffs

        -----

        pom.xml ed8092d

        Diff: https://reviews.apache.org/r/4796/diff

        Testing

        -------

        This no longer fails on the 2nd run: mvn clean package -DskipTests && mvn package -DskipTests

        Thanks,

        Mike

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4796/#review7149 ----------------------------------------------------------- Ship it! +1 Arvind On 2012-04-19 04:12:44, Mike Percy wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4796/ ----------------------------------------------------------- (Updated 2012-04-19 04:12:44) Review request for Flume. Summary ------- The exclude pattern used so rat doesn't complain about the site docs needs to be tweaked. This addresses bug FLUME-1135 . https://issues.apache.org/jira/browse/FLUME-1135 Diffs ----- pom.xml ed8092d Diff: https://reviews.apache.org/r/4796/diff Testing ------- This no longer fails on the 2nd run: mvn clean package -DskipTests && mvn package -DskipTests Thanks, Mike
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4796/#review7039
        -----------------------------------------------------------

        Ship it!

        lgtm

        • Prasad

        On 2012-04-19 04:12:44, Mike Percy wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4796/

        -----------------------------------------------------------

        (Updated 2012-04-19 04:12:44)

        Review request for Flume.

        Summary

        -------

        The exclude pattern used so rat doesn't complain about the site docs needs to be tweaked.

        This addresses bug FLUME-1135.

        https://issues.apache.org/jira/browse/FLUME-1135

        Diffs

        -----

        pom.xml ed8092d

        Diff: https://reviews.apache.org/r/4796/diff

        Testing

        -------

        This no longer fails on the 2nd run: mvn clean package -DskipTests && mvn package -DskipTests

        Thanks,

        Mike

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4796/#review7039 ----------------------------------------------------------- Ship it! lgtm Prasad On 2012-04-19 04:12:44, Mike Percy wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4796/ ----------------------------------------------------------- (Updated 2012-04-19 04:12:44) Review request for Flume. Summary ------- The exclude pattern used so rat doesn't complain about the site docs needs to be tweaked. This addresses bug FLUME-1135 . https://issues.apache.org/jira/browse/FLUME-1135 Diffs ----- pom.xml ed8092d Diff: https://reviews.apache.org/r/4796/diff Testing ------- This no longer fails on the 2nd run: mvn clean package -DskipTests && mvn package -DskipTests Thanks, Mike
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4796/
        -----------------------------------------------------------

        Review request for Flume.

        Summary
        -------

        The exclude pattern used so rat doesn't complain about the site docs needs to be tweaked.

        This addresses bug FLUME-1135.
        https://issues.apache.org/jira/browse/FLUME-1135

        Diffs


        pom.xml ed8092d

        Diff: https://reviews.apache.org/r/4796/diff

        Testing
        -------

        This no longer fails on the 2nd run: mvn clean package -DskipTests && mvn package -DskipTests

        Thanks,

        Mike

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4796/ ----------------------------------------------------------- Review request for Flume. Summary ------- The exclude pattern used so rat doesn't complain about the site docs needs to be tweaked. This addresses bug FLUME-1135 . https://issues.apache.org/jira/browse/FLUME-1135 Diffs pom.xml ed8092d Diff: https://reviews.apache.org/r/4796/diff Testing ------- This no longer fails on the 2nd run: mvn clean package -DskipTests && mvn package -DskipTests Thanks, Mike

          People

          • Assignee:
            Mike Percy
            Reporter:
            Mike Percy
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development