Flume
  1. Flume
  2. FLUME-1132

HDFSEventSink has spurious and verbose log message

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: v1.1.0
    • Fix Version/s: v1.2.0
    • Component/s: None
    • Labels:
      None

      Description

      The finally block in HDFSEvent sink when calling flush prints "Calling abort on ...". This is incorrect as it's actually calling flush and is logged a tremendous number of times.

      1. FLUME-1132-1.patch
        4 kB
        Brock Noland
      2. FLUME-1132-0.patch
        3 kB
        Brock Noland

        Activity

        Brock Noland created issue -
        Brock Noland made changes -
        Field Original Value New Value
        Affects Version/s v1.2.0 [ 12320243 ]
        Brock Noland made changes -
        Affects Version/s v1.1.0 [ 12319284 ]
        Affects Version/s v1.2.0 [ 12320243 ]
        Hide
        Brock Noland added a comment -

        Patch from RB

        Show
        Brock Noland added a comment - Patch from RB
        Brock Noland made changes -
        Attachment FLUME-1132-0.patch [ 12523724 ]
        Brock Noland made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4838/
        -----------------------------------------------------------

        Review request for Flume.

        Summary
        -------

        Message is logged a large volume of times and is incorrect.

        This addresses bug FLUME-1132.
        https://issues.apache.org/jira/browse/FLUME-1132

        Diffs


        flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java 1b61cad

        Diff: https://reviews.apache.org/r/4838/diff

        Testing
        -------

        Logging only change

        Thanks,

        Brock

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4838/ ----------------------------------------------------------- Review request for Flume. Summary ------- Message is logged a large volume of times and is incorrect. This addresses bug FLUME-1132 . https://issues.apache.org/jira/browse/FLUME-1132 Diffs flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java 1b61cad Diff: https://reviews.apache.org/r/4838/diff Testing ------- Logging only change Thanks, Brock
        Brock Noland made changes -
        Assignee Brock Noland [ brocknoland ]
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4838/#review7457
        -----------------------------------------------------------

        Ship it!

        +1 Changes look good. A couple of nits noted below.

        flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java
        <https://reviews.apache.org/r/4838/#comment16464>

        nit: the callWithTimeoutLogError adds a prefix to the log message as "Error calling " + name. This translates to a message in this case like:"Error calling Calling flush on ...". Suggest removing the redundant words here and keeping the name to "flush on " + callableWriter.

        flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java
        <https://reviews.apache.org/r/4838/#comment16465>

        nit: "close on " + e.getKey()

        • Arvind

        On 2012-04-22 23:17:45, Brock Noland wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4838/

        -----------------------------------------------------------

        (Updated 2012-04-22 23:17:45)

        Review request for Flume.

        Summary

        -------

        Message is logged a large volume of times and is incorrect.

        This addresses bug FLUME-1132.

        https://issues.apache.org/jira/browse/FLUME-1132

        Diffs

        -----

        flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java 1b61cad

        Diff: https://reviews.apache.org/r/4838/diff

        Testing

        -------

        Logging only change

        Thanks,

        Brock

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4838/#review7457 ----------------------------------------------------------- Ship it! +1 Changes look good. A couple of nits noted below. flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java < https://reviews.apache.org/r/4838/#comment16464 > nit: the callWithTimeoutLogError adds a prefix to the log message as "Error calling " + name. This translates to a message in this case like:"Error calling Calling flush on ...". Suggest removing the redundant words here and keeping the name to "flush on " + callableWriter. flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java < https://reviews.apache.org/r/4838/#comment16465 > nit: "close on " + e.getKey() Arvind On 2012-04-22 23:17:45, Brock Noland wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4838/ ----------------------------------------------------------- (Updated 2012-04-22 23:17:45) Review request for Flume. Summary ------- Message is logged a large volume of times and is incorrect. This addresses bug FLUME-1132 . https://issues.apache.org/jira/browse/FLUME-1132 Diffs ----- flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java 1b61cad Diff: https://reviews.apache.org/r/4838/diff Testing ------- Logging only change Thanks, Brock
        Hide
        Brock Noland added a comment -

        Patch from RB

        Show
        Brock Noland added a comment - Patch from RB
        Brock Noland made changes -
        Attachment FLUME-1132-1.patch [ 12525303 ]
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-05-02 00:20:27, Arvind Prabhakar wrote:

        > +1 Changes look good. A couple of nits noted below.

        Resolve both nits and attached to JIRA. Thank you for your review!

        • Brock

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4838/#review7457
        -----------------------------------------------------------

        On 2012-04-22 23:17:45, Brock Noland wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4838/

        -----------------------------------------------------------

        (Updated 2012-04-22 23:17:45)

        Review request for Flume.

        Summary

        -------

        Message is logged a large volume of times and is incorrect.

        This addresses bug FLUME-1132.

        https://issues.apache.org/jira/browse/FLUME-1132

        Diffs

        -----

        flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java 1b61cad

        Diff: https://reviews.apache.org/r/4838/diff

        Testing

        -------

        Logging only change

        Thanks,

        Brock

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-05-02 00:20:27, Arvind Prabhakar wrote: > +1 Changes look good. A couple of nits noted below. Resolve both nits and attached to JIRA. Thank you for your review! Brock ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4838/#review7457 ----------------------------------------------------------- On 2012-04-22 23:17:45, Brock Noland wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4838/ ----------------------------------------------------------- (Updated 2012-04-22 23:17:45) Review request for Flume. Summary ------- Message is logged a large volume of times and is incorrect. This addresses bug FLUME-1132 . https://issues.apache.org/jira/browse/FLUME-1132 Diffs ----- flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java 1b61cad Diff: https://reviews.apache.org/r/4838/diff Testing ------- Logging only change Thanks, Brock
        Hide
        Arvind Prabhakar added a comment -

        Patch committed. Thanks Brock!

        Show
        Arvind Prabhakar added a comment - Patch committed. Thanks Brock!
        Arvind Prabhakar made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s v1.2.0 [ 12320243 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in flume-trunk #192 (See https://builds.apache.org/job/flume-trunk/192/)
        FLUME-1132. HDFS Event Sink has spurious and verbose log message.

        (Brock Noland via Arvind Prabhakar) (Revision 1333223)

        Result = SUCCESS
        arvind : http://svn.apache.org/viewvc/?view=rev&rev=1333223
        Files :

        • /incubator/flume/trunk/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java
        Show
        Hudson added a comment - Integrated in flume-trunk #192 (See https://builds.apache.org/job/flume-trunk/192/ ) FLUME-1132 . HDFS Event Sink has spurious and verbose log message. (Brock Noland via Arvind Prabhakar) (Revision 1333223) Result = SUCCESS arvind : http://svn.apache.org/viewvc/?view=rev&rev=1333223 Files : /incubator/flume/trunk/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java

          People

          • Assignee:
            Brock Noland
            Reporter:
            Brock Noland
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development