Flume
  1. Flume
  2. FLUME-1125

flume-ng script allows flume-env.sh to clobber some command-line arguments

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: v1.1.0
    • Fix Version/s: v1.2.0
    • Component/s: None
    • Labels:
      None

      Description

      Certain command-line arguments such as --classpath and -D* can be clobbered by specifying them as FLUME_CLASSPATH and JAVA_OPTS in flume-env.sh

      These command-line params should append to the values specified in the flume-env.sh script, if any.

        Issue Links

          Activity

          Mike Percy created issue -
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/4759/
          -----------------------------------------------------------

          Review request for Flume.

          Summary
          -------

          We shouldn't allow the flume-env.sh variables to override command-line parameters. This patch fixes that issue.
          This also adds support for a --dryrun parameter in order to test the variations and cleans up the flume-env.sh.template file a little bit.
          The following vars are longer "clobberable" by flume-env.sh: FLUME_CLASSPATH, JAVA_OPTS

          This addresses bug FLUME-1125.
          https://issues.apache.org/jira/browse/FLUME-1125

          Diffs


          bin/flume-ng 145db32
          conf/flume-env.sh.template 0388ef9

          Diff: https://reviews.apache.org/r/4759/diff

          Testing
          -------

          Manually tested various combinations.

          Thanks,

          Mike

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4759/ ----------------------------------------------------------- Review request for Flume. Summary ------- We shouldn't allow the flume-env.sh variables to override command-line parameters. This patch fixes that issue. This also adds support for a --dryrun parameter in order to test the variations and cleans up the flume-env.sh.template file a little bit. The following vars are longer "clobberable" by flume-env.sh: FLUME_CLASSPATH, JAVA_OPTS This addresses bug FLUME-1125 . https://issues.apache.org/jira/browse/FLUME-1125 Diffs bin/flume-ng 145db32 conf/flume-env.sh.template 0388ef9 Diff: https://reviews.apache.org/r/4759/diff Testing ------- Manually tested various combinations. Thanks, Mike
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/4759/#review6992
          -----------------------------------------------------------

          Ship it!

          • Brock

          On 2012-04-17 21:29:29, Mike Percy wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/4759/

          -----------------------------------------------------------

          (Updated 2012-04-17 21:29:29)

          Review request for Flume.

          Summary

          -------

          We shouldn't allow the flume-env.sh variables to override command-line parameters. This patch fixes that issue.

          This also adds support for a --dryrun parameter in order to test the variations and cleans up the flume-env.sh.template file a little bit.

          The following vars are longer "clobberable" by flume-env.sh: FLUME_CLASSPATH, JAVA_OPTS

          This addresses bug FLUME-1125.

          https://issues.apache.org/jira/browse/FLUME-1125

          Diffs

          -----

          bin/flume-ng 145db32

          conf/flume-env.sh.template 0388ef9

          Diff: https://reviews.apache.org/r/4759/diff

          Testing

          -------

          Manually tested various combinations.

          Thanks,

          Mike

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4759/#review6992 ----------------------------------------------------------- Ship it! Brock On 2012-04-17 21:29:29, Mike Percy wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4759/ ----------------------------------------------------------- (Updated 2012-04-17 21:29:29) Review request for Flume. Summary ------- We shouldn't allow the flume-env.sh variables to override command-line parameters. This patch fixes that issue. This also adds support for a --dryrun parameter in order to test the variations and cleans up the flume-env.sh.template file a little bit. The following vars are longer "clobberable" by flume-env.sh: FLUME_CLASSPATH, JAVA_OPTS This addresses bug FLUME-1125 . https://issues.apache.org/jira/browse/FLUME-1125 Diffs ----- bin/flume-ng 145db32 conf/flume-env.sh.template 0388ef9 Diff: https://reviews.apache.org/r/4759/diff Testing ------- Manually tested various combinations. Thanks, Mike
          Mike Percy made changes -
          Field Original Value New Value
          Attachment FLUME-1125-4.patch [ 12523055 ]
          Mike Percy made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          jiraposter@reviews.apache.org added a comment -

          On 2012-04-17 21:51:54, Brock Noland wrote:

          >

          Thanks Brock! I've attached the patch to the JIRA.

          • Mike

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/4759/#review6992
          -----------------------------------------------------------

          On 2012-04-17 21:29:29, Mike Percy wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/4759/

          -----------------------------------------------------------

          (Updated 2012-04-17 21:29:29)

          Review request for Flume.

          Summary

          -------

          We shouldn't allow the flume-env.sh variables to override command-line parameters. This patch fixes that issue.

          This also adds support for a --dryrun parameter in order to test the variations and cleans up the flume-env.sh.template file a little bit.

          The following vars are longer "clobberable" by flume-env.sh: FLUME_CLASSPATH, JAVA_OPTS

          This addresses bug FLUME-1125.

          https://issues.apache.org/jira/browse/FLUME-1125

          Diffs

          -----

          bin/flume-ng 145db32

          conf/flume-env.sh.template 0388ef9

          Diff: https://reviews.apache.org/r/4759/diff

          Testing

          -------

          Manually tested various combinations.

          Thanks,

          Mike

          Show
          jiraposter@reviews.apache.org added a comment - On 2012-04-17 21:51:54, Brock Noland wrote: > Thanks Brock! I've attached the patch to the JIRA. Mike ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4759/#review6992 ----------------------------------------------------------- On 2012-04-17 21:29:29, Mike Percy wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4759/ ----------------------------------------------------------- (Updated 2012-04-17 21:29:29) Review request for Flume. Summary ------- We shouldn't allow the flume-env.sh variables to override command-line parameters. This patch fixes that issue. This also adds support for a --dryrun parameter in order to test the variations and cleans up the flume-env.sh.template file a little bit. The following vars are longer "clobberable" by flume-env.sh: FLUME_CLASSPATH, JAVA_OPTS This addresses bug FLUME-1125 . https://issues.apache.org/jira/browse/FLUME-1125 Diffs ----- bin/flume-ng 145db32 conf/flume-env.sh.template 0388ef9 Diff: https://reviews.apache.org/r/4759/diff Testing ------- Manually tested various combinations. Thanks, Mike
          Hide
          Brock Noland added a comment -

          Committed in 1327540.

          Thank you for your patch Mike!

          Show
          Brock Noland added a comment - Committed in 1327540. Thank you for your patch Mike!
          Brock Noland made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in flume-trunk #174 (See https://builds.apache.org/job/flume-trunk/174/)
          FLUME-1125: flume-ng script allows flume-env.sh to clobber some command-line arguments

          (Mike Percy via Brock Noland) (Revision 1327540)

          Result = SUCCESS
          brock : http://svn.apache.org/viewvc/?view=rev&rev=1327540
          Files :

          • /incubator/flume/trunk/bin/flume-ng
          • /incubator/flume/trunk/conf/flume-env.sh.template
          Show
          Hudson added a comment - Integrated in flume-trunk #174 (See https://builds.apache.org/job/flume-trunk/174/ ) FLUME-1125 : flume-ng script allows flume-env.sh to clobber some command-line arguments (Mike Percy via Brock Noland) (Revision 1327540) Result = SUCCESS brock : http://svn.apache.org/viewvc/?view=rev&rev=1327540 Files : /incubator/flume/trunk/bin/flume-ng /incubator/flume/trunk/conf/flume-env.sh.template
          Mike Percy made changes -
          Link This issue breaks FLUME-1130 [ FLUME-1130 ]

            People

            • Assignee:
              Mike Percy
              Reporter:
              Mike Percy
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development