Flume
  1. Flume
  2. FLUME-1109

Syslog sources need to be refactored

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: v1.1.0
    • Fix Version/s: v1.2.0
    • Component/s: Sinks+Sources
    • Labels:
      None

      Description

      There is data loss in the syslog source.

      1. FLUME-1109-1.patch
        24 kB
        Hari Shreedharan

        Activity

        Hide
        Hudson added a comment -

        Integrated in flume-trunk #163 (See https://builds.apache.org/job/flume-trunk/163/)
        FLUME-1109. Syslog source loses data under some situations.

        (Hari Shreedharan via Arvind Prabhakar) (Revision 1310665)

        Result = SUCCESS
        arvind : http://svn.apache.org/viewvc/?view=rev&rev=1310665
        Files :

        • /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java
        • /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java
        • /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java
        • /incubator/flume/trunk/flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java
        • /incubator/flume/trunk/flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java
        Show
        Hudson added a comment - Integrated in flume-trunk #163 (See https://builds.apache.org/job/flume-trunk/163/ ) FLUME-1109 . Syslog source loses data under some situations. (Hari Shreedharan via Arvind Prabhakar) (Revision 1310665) Result = SUCCESS arvind : http://svn.apache.org/viewvc/?view=rev&rev=1310665 Files : /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java /incubator/flume/trunk/flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java /incubator/flume/trunk/flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java
        Hide
        Arvind Prabhakar added a comment -

        Patch committed. Thanks Hari!

        Show
        Arvind Prabhakar added a comment - Patch committed. Thanks Hari!
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4676/#review6765
        -----------------------------------------------------------

        Ship it!

        +1

        Thanks for the patch Hari.

        • Arvind

        On 2012-04-07 02:33:01, Hari Shreedharan wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4676/

        -----------------------------------------------------------

        (Updated 2012-04-07 02:33:01)

        Review request for Flume.

        Summary

        -------

        Refactoring Syslog sources, to fix a bunch of data loss problems encountered.

        This addresses bug FLUME-1109.

        https://issues.apache.org/jira/browse/FLUME-1109

        Diffs

        -----

        flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java d78d27f

        flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 34818f0

        flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java ceb9ff1

        flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java d1db49d

        flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java PRE-CREATION

        Diff: https://reviews.apache.org/r/4676/diff

        Testing

        -------

        Did a bunch of functional tests. Also added unit tests for SylogUtils.

        Thanks,

        Hari

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4676/#review6765 ----------------------------------------------------------- Ship it! +1 Thanks for the patch Hari. Arvind On 2012-04-07 02:33:01, Hari Shreedharan wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4676/ ----------------------------------------------------------- (Updated 2012-04-07 02:33:01) Review request for Flume. Summary ------- Refactoring Syslog sources, to fix a bunch of data loss problems encountered. This addresses bug FLUME-1109 . https://issues.apache.org/jira/browse/FLUME-1109 Diffs ----- flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java d78d27f flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 34818f0 flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java ceb9ff1 flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java d1db49d flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java PRE-CREATION Diff: https://reviews.apache.org/r/4676/diff Testing ------- Did a bunch of functional tests. Also added unit tests for SylogUtils. Thanks, Hari
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4676/
        -----------------------------------------------------------

        Review request for Flume.

        Summary
        -------

        Refactoring Syslog sources, to fix a bunch of data loss problems encountered.

        This addresses bug FLUME-1109.
        https://issues.apache.org/jira/browse/FLUME-1109

        Diffs


        flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java d78d27f
        flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 34818f0
        flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java ceb9ff1
        flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java d1db49d
        flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java PRE-CREATION

        Diff: https://reviews.apache.org/r/4676/diff

        Testing
        -------

        Did a bunch of functional tests. Also added unit tests for SylogUtils.

        Thanks,

        Hari

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4676/ ----------------------------------------------------------- Review request for Flume. Summary ------- Refactoring Syslog sources, to fix a bunch of data loss problems encountered. This addresses bug FLUME-1109 . https://issues.apache.org/jira/browse/FLUME-1109 Diffs flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java d78d27f flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 34818f0 flume-ng-core/src/main/java/org/apache/flume/source/SyslogUtils.java ceb9ff1 flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java d1db49d flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java PRE-CREATION Diff: https://reviews.apache.org/r/4676/diff Testing ------- Did a bunch of functional tests. Also added unit tests for SylogUtils. Thanks, Hari

          People

          • Assignee:
            Hari Shreedharan
            Reporter:
            Hari Shreedharan
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development