Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: v1.2.0
    • Component/s: Channel
    • Labels:
      None

      Description

      The configuration keys for JDBC channel currently require a prefix which serves no purpose as the configuration is already namespace isolated within the configuration system.

      For example, to set the capacity of the channel named "jdbcchannel", the configuration setting will look like:

      agent.channels.jdbcchannel.org.apache.flume.channel.jdbc.maximum.capacity = 1000
      

      It is preferable that the setting be of the short form like the following:

      agent.channels.jdbcchannel.maximum.capacity = 1000
      
      1. FLUME-1107-2.patch
        13 kB
        Arvind Prabhakar
      2. FLUME-1107-1.patch
        12 kB
        Arvind Prabhakar

        Activity

        Arvind Prabhakar created issue -
        Arvind Prabhakar made changes -
        Field Original Value New Value
        Component/s Channel [ 12316614 ]
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4677/
        -----------------------------------------------------------

        Review request for Flume.

        Summary
        -------

        Modified the implementation to deprecate the old form of configuration keys for JDBC channel. The new form takes precedence if both types are present.

        This addresses bug FLUME-1107.
        https://issues.apache.org/jira/browse/FLUME-1107

        Diffs


        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 1310683
        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 1310683

        Diff: https://reviews.apache.org/r/4677/diff

        Testing
        -------

        Ran JDBC channel unit tests with the deprecated old form of configuration keys. Updated the tests to use the new form and tested as well.

        Thanks,

        Arvind

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4677/ ----------------------------------------------------------- Review request for Flume. Summary ------- Modified the implementation to deprecate the old form of configuration keys for JDBC channel. The new form takes precedence if both types are present. This addresses bug FLUME-1107 . https://issues.apache.org/jira/browse/FLUME-1107 Diffs /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 1310683 /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 1310683 Diff: https://reviews.apache.org/r/4677/diff Testing ------- Ran JDBC channel unit tests with the deprecated old form of configuration keys. Updated the tests to use the new form and tested as well. Thanks, Arvind
        Arvind Prabhakar made changes -
        Attachment FLUME-1107-1.patch [ 12521810 ]
        Arvind Prabhakar made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Fix Version/s v1.2.0 [ 12320243 ]
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4677/#review6768
        -----------------------------------------------------------

        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java
        <https://reviews.apache.org/r/4677/#comment14920>

        for readability:
        SYSPRO=>SYSPROP
        (here and in all referenced locations)

        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java
        <https://reviews.apache.org/r/4677/#comment14924>

        SYSPRO=>SYSPROP

        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java
        <https://reviews.apache.org/r/4677/#comment14921>

        For readability:
        PROPERTIES=>PROPS
        (here and all referring locations)

        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java
        <https://reviews.apache.org/r/4677/#comment14925>

        PROPERTIES=>PROPS

        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java
        <https://reviews.apache.org/r/4677/#comment14922>

        For readability:
        CONNECTION=>CONNECTIONS
        ...here and in all referring locations

        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java
        <https://reviews.apache.org/r/4677/#comment14923>

        CONNECTION=>CONNECTIONS

        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java
        <https://reviews.apache.org/r/4677/#comment14927>

        Long=>long
        new form => new short form

        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java
        <https://reviews.apache.org/r/4677/#comment14928>

        @param defaultValue default value, null if no default

        • Will

        On 2012-04-07 08:32:03, Arvind Prabhakar wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4677/

        -----------------------------------------------------------

        (Updated 2012-04-07 08:32:03)

        Review request for Flume.

        Summary

        -------

        Modified the implementation to deprecate the old form of configuration keys for JDBC channel. The new form takes precedence if both types are present.

        This addresses bug FLUME-1107.

        https://issues.apache.org/jira/browse/FLUME-1107

        Diffs

        -----

        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 1310683

        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 1310683

        Diff: https://reviews.apache.org/r/4677/diff

        Testing

        -------

        Ran JDBC channel unit tests with the deprecated old form of configuration keys. Updated the tests to use the new form and tested as well.

        Thanks,

        Arvind

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4677/#review6768 ----------------------------------------------------------- /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java < https://reviews.apache.org/r/4677/#comment14920 > for readability: SYSPRO=>SYSPROP (here and in all referenced locations) /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java < https://reviews.apache.org/r/4677/#comment14924 > SYSPRO=>SYSPROP /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java < https://reviews.apache.org/r/4677/#comment14921 > For readability: PROPERTIES=>PROPS (here and all referring locations) /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java < https://reviews.apache.org/r/4677/#comment14925 > PROPERTIES=>PROPS /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java < https://reviews.apache.org/r/4677/#comment14922 > For readability: CONNECTION=>CONNECTIONS ...here and in all referring locations /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java < https://reviews.apache.org/r/4677/#comment14923 > CONNECTION=>CONNECTIONS /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java < https://reviews.apache.org/r/4677/#comment14927 > Long=>long new form => new short form /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java < https://reviews.apache.org/r/4677/#comment14928 > @param defaultValue default value, null if no default Will On 2012-04-07 08:32:03, Arvind Prabhakar wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4677/ ----------------------------------------------------------- (Updated 2012-04-07 08:32:03) Review request for Flume. Summary ------- Modified the implementation to deprecate the old form of configuration keys for JDBC channel. The new form takes precedence if both types are present. This addresses bug FLUME-1107 . https://issues.apache.org/jira/browse/FLUME-1107 Diffs ----- /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 1310683 /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 1310683 Diff: https://reviews.apache.org/r/4677/diff Testing ------- Ran JDBC channel unit tests with the deprecated old form of configuration keys. Updated the tests to use the new form and tested as well. Thanks, Arvind
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4677/#review6769
        -----------------------------------------------------------

        Ship it!

        Other than the nits described, lgtm!

        • Will

        On 2012-04-07 08:32:03, Arvind Prabhakar wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4677/

        -----------------------------------------------------------

        (Updated 2012-04-07 08:32:03)

        Review request for Flume.

        Summary

        -------

        Modified the implementation to deprecate the old form of configuration keys for JDBC channel. The new form takes precedence if both types are present.

        This addresses bug FLUME-1107.

        https://issues.apache.org/jira/browse/FLUME-1107

        Diffs

        -----

        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 1310683

        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 1310683

        Diff: https://reviews.apache.org/r/4677/diff

        Testing

        -------

        Ran JDBC channel unit tests with the deprecated old form of configuration keys. Updated the tests to use the new form and tested as well.

        Thanks,

        Arvind

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4677/#review6769 ----------------------------------------------------------- Ship it! Other than the nits described, lgtm! Will On 2012-04-07 08:32:03, Arvind Prabhakar wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4677/ ----------------------------------------------------------- (Updated 2012-04-07 08:32:03) Review request for Flume. Summary ------- Modified the implementation to deprecate the old form of configuration keys for JDBC channel. The new form takes precedence if both types are present. This addresses bug FLUME-1107 . https://issues.apache.org/jira/browse/FLUME-1107 Diffs ----- /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 1310683 /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 1310683 Diff: https://reviews.apache.org/r/4677/diff Testing ------- Ran JDBC channel unit tests with the deprecated old form of configuration keys. Updated the tests to use the new form and tested as well. Thanks, Arvind
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-04-07 12:35:09, Will McQueen wrote:

        > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java, line 27

        > <https://reviews.apache.org/r/4677/diff/1/?file=100845#file100845line27>

        >

        > for readability:

        > SYSPRO=>SYSPROP

        > (here and in all referenced locations)

        done.

        On 2012-04-07 12:35:09, Will McQueen wrote:

        > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java, line 33

        > <https://reviews.apache.org/r/4677/diff/1/?file=100845#file100845line33>

        >

        > SYSPRO=>SYSPROP

        done.

        On 2012-04-07 12:35:09, Will McQueen wrote:

        > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java, line 69

        > <https://reviews.apache.org/r/4677/diff/1/?file=100845#file100845line69>

        >

        > For readability:

        > PROPERTIES=>PROPS

        > (here and all referring locations)

        done.

        On 2012-04-07 12:35:09, Will McQueen wrote:

        > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java, line 75

        > <https://reviews.apache.org/r/4677/diff/1/?file=100845#file100845line75>

        >

        > PROPERTIES=>PROPS

        done.

        On 2012-04-07 12:35:09, Will McQueen wrote:

        > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java, line 121

        > <https://reviews.apache.org/r/4677/diff/1/?file=100845#file100845line121>

        >

        > For readability:

        > CONNECTION=>CONNECTIONS

        > ...here and in all referring locations

        done.

        On 2012-04-07 12:35:09, Will McQueen wrote:

        > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java, line 126

        > <https://reviews.apache.org/r/4677/diff/1/?file=100845#file100845line126>

        >

        > CONNECTION=>CONNECTIONS

        done.

        On 2012-04-07 12:35:09, Will McQueen wrote:

        > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java, line 542

        > <https://reviews.apache.org/r/4677/diff/1/?file=100846#file100846line542>

        >

        > Long=>long

        > new form => new short form

        done.

        On 2012-04-07 12:35:09, Will McQueen wrote:

        > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java, line 550

        > <https://reviews.apache.org/r/4677/diff/1/?file=100846#file100846line550>

        >

        > @param defaultValue default value, null if no default

        done.

        • Arvind

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4677/#review6768
        -----------------------------------------------------------

        On 2012-04-07 08:32:03, Arvind Prabhakar wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4677/

        -----------------------------------------------------------

        (Updated 2012-04-07 08:32:03)

        Review request for Flume.

        Summary

        -------

        Modified the implementation to deprecate the old form of configuration keys for JDBC channel. The new form takes precedence if both types are present.

        This addresses bug FLUME-1107.

        https://issues.apache.org/jira/browse/FLUME-1107

        Diffs

        -----

        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 1310683

        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 1310683

        Diff: https://reviews.apache.org/r/4677/diff

        Testing

        -------

        Ran JDBC channel unit tests with the deprecated old form of configuration keys. Updated the tests to use the new form and tested as well.

        Thanks,

        Arvind

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-04-07 12:35:09, Will McQueen wrote: > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java, line 27 > < https://reviews.apache.org/r/4677/diff/1/?file=100845#file100845line27 > > > for readability: > SYSPRO=>SYSPROP > (here and in all referenced locations) done. On 2012-04-07 12:35:09, Will McQueen wrote: > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java, line 33 > < https://reviews.apache.org/r/4677/diff/1/?file=100845#file100845line33 > > > SYSPRO=>SYSPROP done. On 2012-04-07 12:35:09, Will McQueen wrote: > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java, line 69 > < https://reviews.apache.org/r/4677/diff/1/?file=100845#file100845line69 > > > For readability: > PROPERTIES=>PROPS > (here and all referring locations) done. On 2012-04-07 12:35:09, Will McQueen wrote: > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java, line 75 > < https://reviews.apache.org/r/4677/diff/1/?file=100845#file100845line75 > > > PROPERTIES=>PROPS done. On 2012-04-07 12:35:09, Will McQueen wrote: > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java, line 121 > < https://reviews.apache.org/r/4677/diff/1/?file=100845#file100845line121 > > > For readability: > CONNECTION=>CONNECTIONS > ...here and in all referring locations done. On 2012-04-07 12:35:09, Will McQueen wrote: > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java, line 126 > < https://reviews.apache.org/r/4677/diff/1/?file=100845#file100845line126 > > > CONNECTION=>CONNECTIONS done. On 2012-04-07 12:35:09, Will McQueen wrote: > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java, line 542 > < https://reviews.apache.org/r/4677/diff/1/?file=100846#file100846line542 > > > Long=>long > new form => new short form done. On 2012-04-07 12:35:09, Will McQueen wrote: > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java, line 550 > < https://reviews.apache.org/r/4677/diff/1/?file=100846#file100846line550 > > > @param defaultValue default value, null if no default done. Arvind ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4677/#review6768 ----------------------------------------------------------- On 2012-04-07 08:32:03, Arvind Prabhakar wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4677/ ----------------------------------------------------------- (Updated 2012-04-07 08:32:03) Review request for Flume. Summary ------- Modified the implementation to deprecate the old form of configuration keys for JDBC channel. The new form takes precedence if both types are present. This addresses bug FLUME-1107 . https://issues.apache.org/jira/browse/FLUME-1107 Diffs ----- /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 1310683 /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 1310683 Diff: https://reviews.apache.org/r/4677/diff Testing ------- Ran JDBC channel unit tests with the deprecated old form of configuration keys. Updated the tests to use the new form and tested as well. Thanks, Arvind
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4677/
        -----------------------------------------------------------

        (Updated 2012-04-07 20:01:51.619038)

        Review request for Flume.

        Changes
        -------

        Thanks for the review Will. I have incorporated your suggestions.

        Summary
        -------

        Modified the implementation to deprecate the old form of configuration keys for JDBC channel. The new form takes precedence if both types are present.

        This addresses bug FLUME-1107.
        https://issues.apache.org/jira/browse/FLUME-1107

        Diffs (updated)


        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 1310683
        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 1310683
        /trunk/flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestJdbcChannelProvider.java 1310683

        Diff: https://reviews.apache.org/r/4677/diff

        Testing
        -------

        Ran JDBC channel unit tests with the deprecated old form of configuration keys. Updated the tests to use the new form and tested as well.

        Thanks,

        Arvind

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4677/ ----------------------------------------------------------- (Updated 2012-04-07 20:01:51.619038) Review request for Flume. Changes ------- Thanks for the review Will. I have incorporated your suggestions. Summary ------- Modified the implementation to deprecate the old form of configuration keys for JDBC channel. The new form takes precedence if both types are present. This addresses bug FLUME-1107 . https://issues.apache.org/jira/browse/FLUME-1107 Diffs (updated) /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 1310683 /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 1310683 /trunk/flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestJdbcChannelProvider.java 1310683 Diff: https://reviews.apache.org/r/4677/diff Testing ------- Ran JDBC channel unit tests with the deprecated old form of configuration keys. Updated the tests to use the new form and tested as well. Thanks, Arvind
        Arvind Prabhakar made changes -
        Attachment FLUME-1107-2.patch [ 12521832 ]
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4677/#review6776
        -----------------------------------------------------------

        Ship it!

        • Will

        On 2012-04-07 20:01:51, Arvind Prabhakar wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4677/

        -----------------------------------------------------------

        (Updated 2012-04-07 20:01:51)

        Review request for Flume.

        Summary

        -------

        Modified the implementation to deprecate the old form of configuration keys for JDBC channel. The new form takes precedence if both types are present.

        This addresses bug FLUME-1107.

        https://issues.apache.org/jira/browse/FLUME-1107

        Diffs

        -----

        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 1310683

        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 1310683

        /trunk/flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestJdbcChannelProvider.java 1310683

        Diff: https://reviews.apache.org/r/4677/diff

        Testing

        -------

        Ran JDBC channel unit tests with the deprecated old form of configuration keys. Updated the tests to use the new form and tested as well.

        Thanks,

        Arvind

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4677/#review6776 ----------------------------------------------------------- Ship it! Will On 2012-04-07 20:01:51, Arvind Prabhakar wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4677/ ----------------------------------------------------------- (Updated 2012-04-07 20:01:51) Review request for Flume. Summary ------- Modified the implementation to deprecate the old form of configuration keys for JDBC channel. The new form takes precedence if both types are present. This addresses bug FLUME-1107 . https://issues.apache.org/jira/browse/FLUME-1107 Diffs ----- /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 1310683 /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 1310683 /trunk/flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestJdbcChannelProvider.java 1310683 Diff: https://reviews.apache.org/r/4677/diff Testing ------- Ran JDBC channel unit tests with the deprecated old form of configuration keys. Updated the tests to use the new form and tested as well. Thanks, Arvind
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4677/#review6804
        -----------------------------------------------------------

        Ship it!

        lgtm

        • Prasad

        On 2012-04-07 20:01:51, Arvind Prabhakar wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4677/

        -----------------------------------------------------------

        (Updated 2012-04-07 20:01:51)

        Review request for Flume.

        Summary

        -------

        Modified the implementation to deprecate the old form of configuration keys for JDBC channel. The new form takes precedence if both types are present.

        This addresses bug FLUME-1107.

        https://issues.apache.org/jira/browse/FLUME-1107

        Diffs

        -----

        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 1310683

        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 1310683

        /trunk/flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestJdbcChannelProvider.java 1310683

        Diff: https://reviews.apache.org/r/4677/diff

        Testing

        -------

        Ran JDBC channel unit tests with the deprecated old form of configuration keys. Updated the tests to use the new form and tested as well.

        Thanks,

        Arvind

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4677/#review6804 ----------------------------------------------------------- Ship it! lgtm Prasad On 2012-04-07 20:01:51, Arvind Prabhakar wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4677/ ----------------------------------------------------------- (Updated 2012-04-07 20:01:51) Review request for Flume. Summary ------- Modified the implementation to deprecate the old form of configuration keys for JDBC channel. The new form takes precedence if both types are present. This addresses bug FLUME-1107 . https://issues.apache.org/jira/browse/FLUME-1107 Diffs ----- /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 1310683 /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 1310683 /trunk/flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestJdbcChannelProvider.java 1310683 Diff: https://reviews.apache.org/r/4677/diff Testing ------- Ran JDBC channel unit tests with the deprecated old form of configuration keys. Updated the tests to use the new form and tested as well. Thanks, Arvind
        Hide
        Hudson added a comment -

        Integrated in flume-trunk #165 (See https://builds.apache.org/job/flume-trunk/165/)
        FLUME-1107: Configuration keys for JDBC channel contain redundant prefix.
        (Arvind Prabhakar via Prasad Mujumdar) (Revision 1311483)

        Result = SUCCESS
        prasadm : http://svn.apache.org/viewvc/?view=rev&rev=1311483
        Files :

        • /incubator/flume/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java
        • /incubator/flume/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java
        • /incubator/flume/trunk/flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestJdbcChannelProvider.java
        Show
        Hudson added a comment - Integrated in flume-trunk #165 (See https://builds.apache.org/job/flume-trunk/165/ ) FLUME-1107 : Configuration keys for JDBC channel contain redundant prefix. (Arvind Prabhakar via Prasad Mujumdar) (Revision 1311483) Result = SUCCESS prasadm : http://svn.apache.org/viewvc/?view=rev&rev=1311483 Files : /incubator/flume/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java /incubator/flume/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java /incubator/flume/trunk/flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestJdbcChannelProvider.java
        Prasad Mujumdar made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        16h 27m 1 Arvind Prabhakar 07/Apr/12 09:39
        Patch Available Patch Available Resolved Resolved
        2d 14h 24m 1 Prasad Mujumdar 10/Apr/12 00:03

          People

          • Assignee:
            Arvind Prabhakar
            Reporter:
            Arvind Prabhakar
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development