Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: v1.2.0
    • Component/s: Channel
    • Labels:
      None

      Description

      The JDFC Channel uses Foreign Key constraints by default. There should be an option to create the schema without such constraints if desired.

      1. FLUME-1105-2.patch
        16 kB
        Arvind Prabhakar
      2. FLUME-1105-1.patch
        16 kB
        Arvind Prabhakar

        Activity

        Arvind Prabhakar created issue -
        Arvind Prabhakar made changes -
        Field Original Value New Value
        Component/s Channel [ 12316614 ]
        Arvind Prabhakar made changes -
        Attachment FLUME-1105-1.patch [ 12521647 ]
        Arvind Prabhakar made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Fix Version/s v1.2.0 [ 12320243 ]
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4667/
        -----------------------------------------------------------

        Review request for Flume.

        Summary
        -------

        Created a configuration option which controls the creation of foreign key constraints for the jdbc channel. The value of this option is true by default, which implies that the FK constraints will be created. To disable these constraints, the user must explicitly turn it off via configuration.

        This addresses bug FLUME-1105.
        https://issues.apache.org/jira/browse/FLUME-1105

        Diffs


        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 1310152
        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/DerbySchemaHandler.java 1310152
        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 1310152
        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/MySQLSchemaHandler.java 1310152
        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/SchemaHandler.java 1310152
        /trunk/flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestDerbySchemaHandlerQueries.java 1310152

        Diff: https://reviews.apache.org/r/4667/diff

        Testing
        -------

        Ran full tests. Also manually verified that the fk constraints could be created or not via the configuration option.

        Thanks,

        Arvind

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4667/ ----------------------------------------------------------- Review request for Flume. Summary ------- Created a configuration option which controls the creation of foreign key constraints for the jdbc channel. The value of this option is true by default, which implies that the FK constraints will be created. To disable these constraints, the user must explicitly turn it off via configuration. This addresses bug FLUME-1105 . https://issues.apache.org/jira/browse/FLUME-1105 Diffs /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 1310152 /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/DerbySchemaHandler.java 1310152 /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 1310152 /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/MySQLSchemaHandler.java 1310152 /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/SchemaHandler.java 1310152 /trunk/flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestDerbySchemaHandlerQueries.java 1310152 Diff: https://reviews.apache.org/r/4667/diff Testing ------- Ran full tests. Also manually verified that the fk constraints could be created or not via the configuration option. Thanks, Arvind
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4667/#review6736
        -----------------------------------------------------------

        Ship it!

        lgtm.
        just a minor comment about the log message.

        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java
        <https://reviews.apache.org/r/4667/#comment14686>

        It would be better to make it an info message than warning.

        • Prasad

        On 2012-04-06 04:40:53, Arvind Prabhakar wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4667/

        -----------------------------------------------------------

        (Updated 2012-04-06 04:40:53)

        Review request for Flume.

        Summary

        -------

        Created a configuration option which controls the creation of foreign key constraints for the jdbc channel. The value of this option is true by default, which implies that the FK constraints will be created. To disable these constraints, the user must explicitly turn it off via configuration.

        This addresses bug FLUME-1105.

        https://issues.apache.org/jira/browse/FLUME-1105

        Diffs

        -----

        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 1310152

        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/DerbySchemaHandler.java 1310152

        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 1310152

        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/MySQLSchemaHandler.java 1310152

        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/SchemaHandler.java 1310152

        /trunk/flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestDerbySchemaHandlerQueries.java 1310152

        Diff: https://reviews.apache.org/r/4667/diff

        Testing

        -------

        Ran full tests. Also manually verified that the fk constraints could be created or not via the configuration option.

        Thanks,

        Arvind

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4667/#review6736 ----------------------------------------------------------- Ship it! lgtm. just a minor comment about the log message. /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java < https://reviews.apache.org/r/4667/#comment14686 > It would be better to make it an info message than warning. Prasad On 2012-04-06 04:40:53, Arvind Prabhakar wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4667/ ----------------------------------------------------------- (Updated 2012-04-06 04:40:53) Review request for Flume. Summary ------- Created a configuration option which controls the creation of foreign key constraints for the jdbc channel. The value of this option is true by default, which implies that the FK constraints will be created. To disable these constraints, the user must explicitly turn it off via configuration. This addresses bug FLUME-1105 . https://issues.apache.org/jira/browse/FLUME-1105 Diffs ----- /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 1310152 /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/DerbySchemaHandler.java 1310152 /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 1310152 /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/MySQLSchemaHandler.java 1310152 /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/SchemaHandler.java 1310152 /trunk/flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestDerbySchemaHandlerQueries.java 1310152 Diff: https://reviews.apache.org/r/4667/diff Testing ------- Ran full tests. Also manually verified that the fk constraints could be created or not via the configuration option. Thanks, Arvind
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-04-06 07:24:16, Prasad Mujumdar wrote:

        > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java, line 167

        > <https://reviews.apache.org/r/4667/diff/2/?file=100401#file100401line167>

        >

        > It would be better to make it an info message than warning.

        Will do.

        • Arvind

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4667/#review6736
        -----------------------------------------------------------

        On 2012-04-06 04:40:53, Arvind Prabhakar wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4667/

        -----------------------------------------------------------

        (Updated 2012-04-06 04:40:53)

        Review request for Flume.

        Summary

        -------

        Created a configuration option which controls the creation of foreign key constraints for the jdbc channel. The value of this option is true by default, which implies that the FK constraints will be created. To disable these constraints, the user must explicitly turn it off via configuration.

        This addresses bug FLUME-1105.

        https://issues.apache.org/jira/browse/FLUME-1105

        Diffs

        -----

        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 1310152

        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/DerbySchemaHandler.java 1310152

        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 1310152

        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/MySQLSchemaHandler.java 1310152

        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/SchemaHandler.java 1310152

        /trunk/flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestDerbySchemaHandlerQueries.java 1310152

        Diff: https://reviews.apache.org/r/4667/diff

        Testing

        -------

        Ran full tests. Also manually verified that the fk constraints could be created or not via the configuration option.

        Thanks,

        Arvind

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-04-06 07:24:16, Prasad Mujumdar wrote: > /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java, line 167 > < https://reviews.apache.org/r/4667/diff/2/?file=100401#file100401line167 > > > It would be better to make it an info message than warning. Will do. Arvind ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4667/#review6736 ----------------------------------------------------------- On 2012-04-06 04:40:53, Arvind Prabhakar wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4667/ ----------------------------------------------------------- (Updated 2012-04-06 04:40:53) Review request for Flume. Summary ------- Created a configuration option which controls the creation of foreign key constraints for the jdbc channel. The value of this option is true by default, which implies that the FK constraints will be created. To disable these constraints, the user must explicitly turn it off via configuration. This addresses bug FLUME-1105 . https://issues.apache.org/jira/browse/FLUME-1105 Diffs ----- /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 1310152 /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/DerbySchemaHandler.java 1310152 /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 1310152 /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/MySQLSchemaHandler.java 1310152 /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/SchemaHandler.java 1310152 /trunk/flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestDerbySchemaHandlerQueries.java 1310152 Diff: https://reviews.apache.org/r/4667/diff Testing ------- Ran full tests. Also manually verified that the fk constraints could be created or not via the configuration option. Thanks, Arvind
        Arvind Prabhakar made changes -
        Attachment FLUME-1105-2.patch [ 12521687 ]
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4667/
        -----------------------------------------------------------

        (Updated 2012-04-06 16:07:53.025971)

        Review request for Flume.

        Changes
        -------

        Incorporated review feedback.

        Summary
        -------

        Created a configuration option which controls the creation of foreign key constraints for the jdbc channel. The value of this option is true by default, which implies that the FK constraints will be created. To disable these constraints, the user must explicitly turn it off via configuration.

        This addresses bug FLUME-1105.
        https://issues.apache.org/jira/browse/FLUME-1105

        Diffs (updated)


        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 1310152
        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/DerbySchemaHandler.java 1310152
        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 1310152
        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/MySQLSchemaHandler.java 1310152
        /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/SchemaHandler.java 1310152
        /trunk/flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestDerbySchemaHandlerQueries.java 1310152

        Diff: https://reviews.apache.org/r/4667/diff

        Testing
        -------

        Ran full tests. Also manually verified that the fk constraints could be created or not via the configuration option.

        Thanks,

        Arvind

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4667/ ----------------------------------------------------------- (Updated 2012-04-06 16:07:53.025971) Review request for Flume. Changes ------- Incorporated review feedback. Summary ------- Created a configuration option which controls the creation of foreign key constraints for the jdbc channel. The value of this option is true by default, which implies that the FK constraints will be created. To disable these constraints, the user must explicitly turn it off via configuration. This addresses bug FLUME-1105 . https://issues.apache.org/jira/browse/FLUME-1105 Diffs (updated) /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java 1310152 /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/DerbySchemaHandler.java 1310152 /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 1310152 /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/MySQLSchemaHandler.java 1310152 /trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/SchemaHandler.java 1310152 /trunk/flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestDerbySchemaHandlerQueries.java 1310152 Diff: https://reviews.apache.org/r/4667/diff Testing ------- Ran full tests. Also manually verified that the fk constraints could be created or not via the configuration option. Thanks, Arvind
        Hide
        Hudson added a comment -

        Integrated in flume-trunk #162 (See https://builds.apache.org/job/flume-trunk/162/)
        FLUME-1105: Allow the optional disabling of foreign keys
        (Arvind Prabhakar via Prasad Mujumdar) (Revision 1310467)

        Result = SUCCESS
        prasadm : http://svn.apache.org/viewvc/?view=rev&rev=1310467
        Files :

        • /incubator/flume/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java
        • /incubator/flume/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/DerbySchemaHandler.java
        • /incubator/flume/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java
        • /incubator/flume/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/MySQLSchemaHandler.java
        • /incubator/flume/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/SchemaHandler.java
        • /incubator/flume/trunk/flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestDerbySchemaHandlerQueries.java
        Show
        Hudson added a comment - Integrated in flume-trunk #162 (See https://builds.apache.org/job/flume-trunk/162/ ) FLUME-1105 : Allow the optional disabling of foreign keys (Arvind Prabhakar via Prasad Mujumdar) (Revision 1310467) Result = SUCCESS prasadm : http://svn.apache.org/viewvc/?view=rev&rev=1310467 Files : /incubator/flume/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/ConfigurationConstants.java /incubator/flume/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/DerbySchemaHandler.java /incubator/flume/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java /incubator/flume/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/MySQLSchemaHandler.java /incubator/flume/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/SchemaHandler.java /incubator/flume/trunk/flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestDerbySchemaHandlerQueries.java
        Prasad Mujumdar made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Prasad Mujumdar made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Prasad Mujumdar made changes -
        Comment [ Patch committed trunk
        Thanks Arvind!
        ]
        Prasad Mujumdar made changes -
        Comment [ Only the Flume-1105 is addressed the moment ]
        Hide
        Prasad Mujumdar added a comment -

        Patch committed trunk
        Thanks Arvind!

        Show
        Prasad Mujumdar added a comment - Patch committed trunk Thanks Arvind!
        Prasad Mujumdar made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        33m 38s 1 Arvind Prabhakar 06/Apr/12 05:42
        Patch Available Patch Available Resolved Resolved
        13h 1m 1 Prasad Mujumdar 06/Apr/12 18:43
        Resolved Resolved Reopened Reopened
        1m 9s 1 Prasad Mujumdar 06/Apr/12 18:44
        Reopened Reopened Resolved Resolved
        1m 32s 1 Prasad Mujumdar 06/Apr/12 18:46

          People

          • Assignee:
            Arvind Prabhakar
            Reporter:
            Arvind Prabhakar
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development