[FLUME-11] Tests are setting logger level and should not be.

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.9.4
• Fix Version/s: 1.1.0
• Component/s: Test
• Assignee: Alexander Alten-Lorenz
• Reporter: Patrick D. Hunt
• Created: 03/Jul/10 00:06
• Updated: 07/Mar/12 09:57
• Resolved: 07/Mar/12 09:53

Description

I'm seeing the following on my system, at which point junit stops:

[junit] Running com.cloudera.flume.agent.diskfailover.TestConcurrentDFOMan
[junit] Tests run: 11, Failures: 5, Errors: 0, Time elapsed: 161.737 sec
[junit] Exception in thread "main" java.lang.OutOfMemoryError: Java heap space
[junit] at java.util.Arrays.copyOf(Arrays.java:2786)
[junit] at java.lang.StringCoding.safeTrim(StringCoding.java:64)
[junit] at java.lang.StringCoding.access$300(StringCoding.java:34)
[junit] at java.lang.StringCoding$StringEncoder.encode(StringCoding.java:251)
[junit] at java.lang.StringCoding.encode(StringCoding.java:272)
[junit] at java.lang.StringCoding.encode(StringCoding.java:284)
[junit] at java.lang.String.getBytes(String.java:986)
[junit] at org.apache.tools.ant.taskdefs.optional.junit.PlainJUnitResultFormatter.endTestSuite(PlainJUnitResultFormatter.java:152)
[junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.fireEndTestSuite(JUnitTestRunner.java:619)
[junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:452)
[junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestRunner.java:911)
[junit] at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:768)

Notice that it's junit that's running out of memory - it's unable to handle the huge amount of dfo test logs that are being output at debug level due to this in the test:

@Before
public void setDebug()

{ Logger.getRootLogger().setLevel(Level.DEBUG); }

The test should not set the debugging level, rather this should be set in the log4j.properties file. Such code should be removed from all tests.

Issue Links

• blocks: FLUME-318 Convert tests from Log4J to SLF4J
• blocks: FLUME-283 Change logging to slf4j