Flume
  1. Flume
  2. FLUME-1090

JDBC Channel: Minimize logging under nominal conditions

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: v1.2.0
    • Component/s: None
    • Labels:
      None

      Description

      Minimize the logging that we do under normal conditions in JDBC channel, for performance and usability reasons.

        Activity

        Hide
        Hudson added a comment -

        Integrated in flume-trunk #156 (See https://builds.apache.org/job/flume-trunk/156/)
        FLUME-1090. JDBC Channel - Minimize logging under nominal conditions.

        (Mike Percy via Arvind Prabhakar) (Revision 1308548)

        Result = UNSTABLE
        arvind : http://svn.apache.org/viewvc/?view=rev&rev=1308548
        Files :

        • /incubator/flume/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java
        • /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/sink/NullSink.java
        Show
        Hudson added a comment - Integrated in flume-trunk #156 (See https://builds.apache.org/job/flume-trunk/156/ ) FLUME-1090 . JDBC Channel - Minimize logging under nominal conditions. (Mike Percy via Arvind Prabhakar) (Revision 1308548) Result = UNSTABLE arvind : http://svn.apache.org/viewvc/?view=rev&rev=1308548 Files : /incubator/flume/trunk/flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/sink/NullSink.java
        Hide
        Arvind Prabhakar added a comment -

        Patch committed. Thanks Mike!

        Show
        Arvind Prabhakar added a comment - Patch committed. Thanks Mike!
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4610/#review6636
        -----------------------------------------------------------

        Ship it!

        +1

        • Arvind

        On 2012-04-02 20:32:49, Mike Percy wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4610/

        -----------------------------------------------------------

        (Updated 2012-04-02 20:32:49)

        Review request for Flume.

        Summary

        -------

        This patch changes loglevel to debug for stuff like successful event read & write. This should improve performance at the INFO level. Other similar changes have been made.

        One additional change I have snuck into this patch is logging the event metrics at info level for the Null sink, to make it consistent with the Logger sink.

        This addresses bug FLUME-1090.

        https://issues.apache.org/jira/browse/FLUME-1090

        Diffs

        -----

        flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 307ae89

        flume-ng-core/src/main/java/org/apache/flume/sink/NullSink.java c11a002

        Diff: https://reviews.apache.org/r/4610/diff

        Testing

        -------

        Unit tests pass.

        Thanks,

        Mike

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4610/#review6636 ----------------------------------------------------------- Ship it! +1 Arvind On 2012-04-02 20:32:49, Mike Percy wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4610/ ----------------------------------------------------------- (Updated 2012-04-02 20:32:49) Review request for Flume. Summary ------- This patch changes loglevel to debug for stuff like successful event read & write. This should improve performance at the INFO level. Other similar changes have been made. One additional change I have snuck into this patch is logging the event metrics at info level for the Null sink, to make it consistent with the Logger sink. This addresses bug FLUME-1090 . https://issues.apache.org/jira/browse/FLUME-1090 Diffs ----- flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 307ae89 flume-ng-core/src/main/java/org/apache/flume/sink/NullSink.java c11a002 Diff: https://reviews.apache.org/r/4610/diff Testing ------- Unit tests pass. Thanks, Mike
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4610/
        -----------------------------------------------------------

        Review request for Flume.

        Summary
        -------

        This patch changes loglevel to debug for stuff like successful event read & write. This should improve performance at the INFO level. Other similar changes have been made.

        One additional change I have snuck into this patch is logging the event metrics at info level for the Null sink, to make it consistent with the Logger sink.

        This addresses bug FLUME-1090.
        https://issues.apache.org/jira/browse/FLUME-1090

        Diffs


        flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 307ae89
        flume-ng-core/src/main/java/org/apache/flume/sink/NullSink.java c11a002

        Diff: https://reviews.apache.org/r/4610/diff

        Testing
        -------

        Unit tests pass.

        Thanks,

        Mike

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4610/ ----------------------------------------------------------- Review request for Flume. Summary ------- This patch changes loglevel to debug for stuff like successful event read & write. This should improve performance at the INFO level. Other similar changes have been made. One additional change I have snuck into this patch is logging the event metrics at info level for the Null sink, to make it consistent with the Logger sink. This addresses bug FLUME-1090 . https://issues.apache.org/jira/browse/FLUME-1090 Diffs flume-ng-channels/flume-jdbc-channel/src/main/java/org/apache/flume/channel/jdbc/impl/JdbcChannelProviderImpl.java 307ae89 flume-ng-core/src/main/java/org/apache/flume/sink/NullSink.java c11a002 Diff: https://reviews.apache.org/r/4610/diff Testing ------- Unit tests pass. Thanks, Mike

          People

          • Assignee:
            Mike Percy
            Reporter:
            Mike Percy
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development