Flume
  1. Flume
  2. FLUME-1087

Restore Client API compat with v1.1.0

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: v1.2.0
    • Component/s: None
    • Labels:
      None

      Description

      Restore backcompat with client API in v1.1.0

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          1h 20m 1 Mike Percy 01/Apr/12 10:45
          Patch Available Patch Available Resolved Resolved
          8h 18m 1 Arvind Prabhakar 01/Apr/12 19:03
          Hide
          Hudson added a comment -

          Integrated in flume-trunk #153 (See https://builds.apache.org/job/flume-trunk/153/)
          FLUME-1087. Restore Client API compatibility with v1.1.0.

          (Mike Percy via Arvind Prabhakar) (Revision 1308164)

          Result = UNSTABLE
          arvind : http://svn.apache.org/viewvc/?view=rev&rev=1308164
          Files :

          • /incubator/flume/trunk/flume-ng-sdk/src/main/java/org/apache/flume/api/RpcClientFactory.java
          • /incubator/flume/trunk/flume-ng-sdk/src/test/java/org/apache/flume/api/TestRpcClientFactory.java
          Show
          Hudson added a comment - Integrated in flume-trunk #153 (See https://builds.apache.org/job/flume-trunk/153/ ) FLUME-1087 . Restore Client API compatibility with v1.1.0. (Mike Percy via Arvind Prabhakar) (Revision 1308164) Result = UNSTABLE arvind : http://svn.apache.org/viewvc/?view=rev&rev=1308164 Files : /incubator/flume/trunk/flume-ng-sdk/src/main/java/org/apache/flume/api/RpcClientFactory.java /incubator/flume/trunk/flume-ng-sdk/src/test/java/org/apache/flume/api/TestRpcClientFactory.java
          Arvind Prabhakar made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s v1.2.0 [ 12320243 ]
          Resolution Fixed [ 1 ]
          Hide
          Arvind Prabhakar added a comment -

          Patch committed. Thanks Mike!

          Show
          Arvind Prabhakar added a comment - Patch committed. Thanks Mike!
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/4602/#review6608
          -----------------------------------------------------------

          Ship it!

          +1

          • Arvind

          On 2012-04-01 09:19:53, Mike Percy wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/4602/

          -----------------------------------------------------------

          (Updated 2012-04-01 09:19:53)

          Review request for Flume.

          Summary

          -------

          Client API compatibility with Flume 1.1.0 was broken with FLUME-962; This patch restores backcompat.

          This addresses bug FLUME-1087.

          https://issues.apache.org/jira/browse/FLUME-1087

          Diffs

          -----

          flume-ng-sdk/src/main/java/org/apache/flume/api/RpcClientFactory.java 25122a3

          flume-ng-sdk/src/test/java/org/apache/flume/api/TestRpcClientFactory.java 65624b3

          Diff: https://reviews.apache.org/r/4602/diff

          Testing

          -------

          Added simple unit tests, which pass.

          Thanks,

          Mike

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4602/#review6608 ----------------------------------------------------------- Ship it! +1 Arvind On 2012-04-01 09:19:53, Mike Percy wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4602/ ----------------------------------------------------------- (Updated 2012-04-01 09:19:53) Review request for Flume. Summary ------- Client API compatibility with Flume 1.1.0 was broken with FLUME-962 ; This patch restores backcompat. This addresses bug FLUME-1087 . https://issues.apache.org/jira/browse/FLUME-1087 Diffs ----- flume-ng-sdk/src/main/java/org/apache/flume/api/RpcClientFactory.java 25122a3 flume-ng-sdk/src/test/java/org/apache/flume/api/TestRpcClientFactory.java 65624b3 Diff: https://reviews.apache.org/r/4602/diff Testing ------- Added simple unit tests, which pass. Thanks, Mike
          Mike Percy made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Mike Percy made changes -
          Attachment FLUME-1087-1.patch [ 12520818 ]
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/4602/
          -----------------------------------------------------------

          Review request for Flume.

          Summary
          -------

          Client API compatibility with Flume 1.1.0 was broken with FLUME-962; This patch restores backcompat.

          This addresses bug FLUME-1087.
          https://issues.apache.org/jira/browse/FLUME-1087

          Diffs


          flume-ng-sdk/src/main/java/org/apache/flume/api/RpcClientFactory.java 25122a3
          flume-ng-sdk/src/test/java/org/apache/flume/api/TestRpcClientFactory.java 65624b3

          Diff: https://reviews.apache.org/r/4602/diff

          Testing
          -------

          Added simple unit tests, which pass.

          Thanks,

          Mike

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4602/ ----------------------------------------------------------- Review request for Flume. Summary ------- Client API compatibility with Flume 1.1.0 was broken with FLUME-962 ; This patch restores backcompat. This addresses bug FLUME-1087 . https://issues.apache.org/jira/browse/FLUME-1087 Diffs flume-ng-sdk/src/main/java/org/apache/flume/api/RpcClientFactory.java 25122a3 flume-ng-sdk/src/test/java/org/apache/flume/api/TestRpcClientFactory.java 65624b3 Diff: https://reviews.apache.org/r/4602/diff Testing ------- Added simple unit tests, which pass. Thanks, Mike
          Mike Percy made changes -
          Field Original Value New Value
          Link This issue is broken by FLUME-962 [ FLUME-962 ]
          Mike Percy created issue -

            People

            • Assignee:
              Mike Percy
              Reporter:
              Mike Percy
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development