Flume
  1. Flume
  2. FLUME-1084

NetcatSource stop() function returns when client still connected to the source, and can still write to it.

    Details

    • Type: Bug Bug
    • Status: Patch Available
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Sinks+Sources
    • Labels:
      None

      Description

      Previous behavior(commit: 48edaf2) :

      • netcat source runner.stop blocked till the accept handler exited when the nc client connected to it closed the connection
        (logs: [DEBUG - org.apache.flume.source.NetcatSource.stop(NetcatSource.java:208)] Waiting for handler service to stop)

      New behavior(commit: 39aba18):

      • netcat source runner.stop returns but a connected a client can still write to it, while a new source started up for the same agent due to reconfiguration. Note that a new client can startup on the same port as the old netcat source with no bind exception.
      1. FLUME-1084-2.patch
        3 kB
        Hari Shreedharan

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4615/
        -----------------------------------------------------------

        (Updated 2012-04-02 22:01:04.888338)

        Review request for Flume.

        Changes
        -------

        Removed the log4jproperties change.

        Summary
        -------

        Netcat source does not close sockets when stop() is called. Fixed this.

        This addresses bug FLUME-1084.
        https://issues.apache.org/jira/browse/FLUME-1084

        Diffs (updated)


        flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java 9d28cda

        Diff: https://reviews.apache.org/r/4615/diff

        Testing
        -------

        All unit tests pass. Functional testing done.

        Thanks,

        Hari

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4615/ ----------------------------------------------------------- (Updated 2012-04-02 22:01:04.888338) Review request for Flume. Changes ------- Removed the log4jproperties change. Summary ------- Netcat source does not close sockets when stop() is called. Fixed this. This addresses bug FLUME-1084 . https://issues.apache.org/jira/browse/FLUME-1084 Diffs (updated) flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java 9d28cda Diff: https://reviews.apache.org/r/4615/diff Testing ------- All unit tests pass. Functional testing done. Thanks, Hari
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4615/
        -----------------------------------------------------------

        Review request for Flume.

        Summary
        -------

        Netcat source does not close sockets when stop() is called. Fixed this.

        This addresses bug FLUME-1084.
        https://issues.apache.org/jira/browse/FLUME-1084

        Diffs


        conf/log4j.properties 2c476b3
        flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java 9d28cda

        Diff: https://reviews.apache.org/r/4615/diff

        Testing
        -------

        All unit tests pass. Functional testing done.

        Thanks,

        Hari

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4615/ ----------------------------------------------------------- Review request for Flume. Summary ------- Netcat source does not close sockets when stop() is called. Fixed this. This addresses bug FLUME-1084 . https://issues.apache.org/jira/browse/FLUME-1084 Diffs conf/log4j.properties 2c476b3 flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java 9d28cda Diff: https://reviews.apache.org/r/4615/diff Testing ------- All unit tests pass. Functional testing done. Thanks, Hari
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4615/
        -----------------------------------------------------------

        (Updated 2012-04-02 23:14:37.701929)

        Review request for Flume.

        Changes
        -------

        Improving some thread safety guarantees.

        Summary
        -------

        Netcat source does not close sockets when stop() is called. Fixed this.

        This addresses bug FLUME-1084.
        https://issues.apache.org/jira/browse/FLUME-1084

        Diffs (updated)


        flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java 9d28cda

        Diff: https://reviews.apache.org/r/4615/diff

        Testing
        -------

        All unit tests pass. Functional testing done.

        Thanks,

        Hari

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4615/ ----------------------------------------------------------- (Updated 2012-04-02 23:14:37.701929) Review request for Flume. Changes ------- Improving some thread safety guarantees. Summary ------- Netcat source does not close sockets when stop() is called. Fixed this. This addresses bug FLUME-1084 . https://issues.apache.org/jira/browse/FLUME-1084 Diffs (updated) flume-ng-core/src/main/java/org/apache/flume/source/NetcatSource.java 9d28cda Diff: https://reviews.apache.org/r/4615/diff Testing ------- All unit tests pass. Functional testing done. Thanks, Hari

          People

          • Assignee:
            Hari Shreedharan
            Reporter:
            Hari Shreedharan
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Development