Flume
  1. Flume
  2. FLUME-1078

flume-ng script has no way to add, not replace, classpath

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: v1.1.0
    • Fix Version/s: v1.2.0
    • Component/s: Configuration
    • Labels:
      None

      Description

      The only way I can see to add to the classpath is to copy jars into lib/. FLUME_CLASSPATH and -C replace the classpath not add to it.

      1. FLUME-1078-1.patch
        0.9 kB
        Brock Noland

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4574/
        -----------------------------------------------------------

        Review request for Flume.

        Summary
        -------

        Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do.

        This addresses bug FLUME-1078.
        https://issues.apache.org/jira/browse/FLUME-1078

        Diffs


        bin/flume-ng a31f171

        Diff: https://reviews.apache.org/r/4574/diff

        Testing
        -------

        Tested from the command line.

        Thanks,

        Brock

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4574/ ----------------------------------------------------------- Review request for Flume. Summary ------- Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do. This addresses bug FLUME-1078 . https://issues.apache.org/jira/browse/FLUME-1078 Diffs bin/flume-ng a31f171 Diff: https://reviews.apache.org/r/4574/diff Testing ------- Tested from the command line. Thanks, Brock
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4574/#review6588
        -----------------------------------------------------------

        Hi Brock, looks great except that it allows the shell environment to specify $FLUME_CLASSPATH. The intention was to enforce that they come from conf/flume-env.sh. Please restore the line that initializes FLUME_CLASSPATH=""

        One nit: whitespace at the end of line 107

        • Mike

        On 2012-03-30 17:16:57, Brock Noland wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4574/

        -----------------------------------------------------------

        (Updated 2012-03-30 17:16:57)

        Review request for Flume.

        Summary

        -------

        Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do.

        This addresses bug FLUME-1078.

        https://issues.apache.org/jira/browse/FLUME-1078

        Diffs

        -----

        bin/flume-ng a31f171

        Diff: https://reviews.apache.org/r/4574/diff

        Testing

        -------

        Tested from the command line.

        Thanks,

        Brock

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4574/#review6588 ----------------------------------------------------------- Hi Brock, looks great except that it allows the shell environment to specify $FLUME_CLASSPATH. The intention was to enforce that they come from conf/flume-env.sh. Please restore the line that initializes FLUME_CLASSPATH="" One nit: whitespace at the end of line 107 Mike On 2012-03-30 17:16:57, Brock Noland wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4574/ ----------------------------------------------------------- (Updated 2012-03-30 17:16:57) Review request for Flume. Summary ------- Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do. This addresses bug FLUME-1078 . https://issues.apache.org/jira/browse/FLUME-1078 Diffs ----- bin/flume-ng a31f171 Diff: https://reviews.apache.org/r/4574/diff Testing ------- Tested from the command line. Thanks, Brock
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4574/#review6589
        -----------------------------------------------------------

        Ship it!

        +1. Agree with Mike's comment, though I don't see it as blocker.

        • Hari

        On 2012-03-30 17:16:57, Brock Noland wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4574/

        -----------------------------------------------------------

        (Updated 2012-03-30 17:16:57)

        Review request for Flume.

        Summary

        -------

        Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do.

        This addresses bug FLUME-1078.

        https://issues.apache.org/jira/browse/FLUME-1078

        Diffs

        -----

        bin/flume-ng a31f171

        Diff: https://reviews.apache.org/r/4574/diff

        Testing

        -------

        Tested from the command line.

        Thanks,

        Brock

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4574/#review6589 ----------------------------------------------------------- Ship it! +1. Agree with Mike's comment, though I don't see it as blocker. Hari On 2012-03-30 17:16:57, Brock Noland wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4574/ ----------------------------------------------------------- (Updated 2012-03-30 17:16:57) Review request for Flume. Summary ------- Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do. This addresses bug FLUME-1078 . https://issues.apache.org/jira/browse/FLUME-1078 Diffs ----- bin/flume-ng a31f171 Diff: https://reviews.apache.org/r/4574/diff Testing ------- Tested from the command line. Thanks, Brock
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-03-30 20:28:46, Mike Percy wrote:

        > Hi Brock, looks great except that it allows the shell environment to specify $FLUME_CLASSPATH. The intention was to enforce that they come from conf/flume-env.sh. Please restore the line that initializes FLUME_CLASSPATH=""

        >

        > One nit: whitespace at the end of line 107

        Related projects such as hadoop and hbase allow you to append to the classpath via HADOOP_CLASSPATH and HBASE_CLASSPATH from the command line. e.g.:

        env HADOOP_CLASSPATH=/tmp/classpath/entry.jar hadoop command

        Is there a reason we don't want to be compatible?

        • Brock

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4574/#review6588
        -----------------------------------------------------------

        On 2012-03-30 17:16:57, Brock Noland wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4574/

        -----------------------------------------------------------

        (Updated 2012-03-30 17:16:57)

        Review request for Flume.

        Summary

        -------

        Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do.

        This addresses bug FLUME-1078.

        https://issues.apache.org/jira/browse/FLUME-1078

        Diffs

        -----

        bin/flume-ng a31f171

        Diff: https://reviews.apache.org/r/4574/diff

        Testing

        -------

        Tested from the command line.

        Thanks,

        Brock

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-03-30 20:28:46, Mike Percy wrote: > Hi Brock, looks great except that it allows the shell environment to specify $FLUME_CLASSPATH. The intention was to enforce that they come from conf/flume-env.sh. Please restore the line that initializes FLUME_CLASSPATH="" > > One nit: whitespace at the end of line 107 Related projects such as hadoop and hbase allow you to append to the classpath via HADOOP_CLASSPATH and HBASE_CLASSPATH from the command line. e.g.: env HADOOP_CLASSPATH=/tmp/classpath/entry.jar hadoop command Is there a reason we don't want to be compatible? Brock ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4574/#review6588 ----------------------------------------------------------- On 2012-03-30 17:16:57, Brock Noland wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4574/ ----------------------------------------------------------- (Updated 2012-03-30 17:16:57) Review request for Flume. Summary ------- Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do. This addresses bug FLUME-1078 . https://issues.apache.org/jira/browse/FLUME-1078 Diffs ----- bin/flume-ng a31f171 Diff: https://reviews.apache.org/r/4574/diff Testing ------- Tested from the command line. Thanks, Brock
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-03-30 20:33:04, Hari Shreedharan wrote:

        > +1. Agree with Mike's comment, though I don't see it as blocker.

        Comment about the shell specifying $FLUME_CLASSPATH, not the whitespace one

        • Hari

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4574/#review6589
        -----------------------------------------------------------

        On 2012-03-30 17:16:57, Brock Noland wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4574/

        -----------------------------------------------------------

        (Updated 2012-03-30 17:16:57)

        Review request for Flume.

        Summary

        -------

        Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do.

        This addresses bug FLUME-1078.

        https://issues.apache.org/jira/browse/FLUME-1078

        Diffs

        -----

        bin/flume-ng a31f171

        Diff: https://reviews.apache.org/r/4574/diff

        Testing

        -------

        Tested from the command line.

        Thanks,

        Brock

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-03-30 20:33:04, Hari Shreedharan wrote: > +1. Agree with Mike's comment, though I don't see it as blocker. Comment about the shell specifying $FLUME_CLASSPATH, not the whitespace one Hari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4574/#review6589 ----------------------------------------------------------- On 2012-03-30 17:16:57, Brock Noland wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4574/ ----------------------------------------------------------- (Updated 2012-03-30 17:16:57) Review request for Flume. Summary ------- Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do. This addresses bug FLUME-1078 . https://issues.apache.org/jira/browse/FLUME-1078 Diffs ----- bin/flume-ng a31f171 Diff: https://reviews.apache.org/r/4574/diff Testing ------- Tested from the command line. Thanks, Brock
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-03-30 20:28:46, Mike Percy wrote:

        > Hi Brock, looks great except that it allows the shell environment to specify $FLUME_CLASSPATH. The intention was to enforce that they come from conf/flume-env.sh. Please restore the line that initializes FLUME_CLASSPATH=""

        >

        > One nit: whitespace at the end of line 107

        Brock Noland wrote:

        Related projects such as hadoop and hbase allow you to append to the classpath via HADOOP_CLASSPATH and HBASE_CLASSPATH from the command line. e.g.:

        env HADOOP_CLASSPATH=/tmp/classpath/entry.jar hadoop command

        Is there a reason we don't want to be compatible?

        The difference is that the "hadoop" command is a client command-line tool, but the flume-ng script is primarily a startup script for the agent daemon. It's bad practice to start daemons using environment variables since it's not visible in "ps" and not reliably reproducible. So I would prefer not to support it. If you feel that it's an important feature that makes flume easier to use then I'm willing to let it go but I think it's a bad way to run a service.

        • Mike

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4574/#review6588
        -----------------------------------------------------------

        On 2012-03-30 17:16:57, Brock Noland wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4574/

        -----------------------------------------------------------

        (Updated 2012-03-30 17:16:57)

        Review request for Flume.

        Summary

        -------

        Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do.

        This addresses bug FLUME-1078.

        https://issues.apache.org/jira/browse/FLUME-1078

        Diffs

        -----

        bin/flume-ng a31f171

        Diff: https://reviews.apache.org/r/4574/diff

        Testing

        -------

        Tested from the command line.

        Thanks,

        Brock

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-03-30 20:28:46, Mike Percy wrote: > Hi Brock, looks great except that it allows the shell environment to specify $FLUME_CLASSPATH. The intention was to enforce that they come from conf/flume-env.sh. Please restore the line that initializes FLUME_CLASSPATH="" > > One nit: whitespace at the end of line 107 Brock Noland wrote: Related projects such as hadoop and hbase allow you to append to the classpath via HADOOP_CLASSPATH and HBASE_CLASSPATH from the command line. e.g.: env HADOOP_CLASSPATH=/tmp/classpath/entry.jar hadoop command Is there a reason we don't want to be compatible? The difference is that the "hadoop" command is a client command-line tool, but the flume-ng script is primarily a startup script for the agent daemon. It's bad practice to start daemons using environment variables since it's not visible in "ps" and not reliably reproducible. So I would prefer not to support it. If you feel that it's an important feature that makes flume easier to use then I'm willing to let it go but I think it's a bad way to run a service. Mike ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4574/#review6588 ----------------------------------------------------------- On 2012-03-30 17:16:57, Brock Noland wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4574/ ----------------------------------------------------------- (Updated 2012-03-30 17:16:57) Review request for Flume. Summary ------- Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do. This addresses bug FLUME-1078 . https://issues.apache.org/jira/browse/FLUME-1078 Diffs ----- bin/flume-ng a31f171 Diff: https://reviews.apache.org/r/4574/diff Testing ------- Tested from the command line. Thanks, Brock
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4574/
        -----------------------------------------------------------

        (Updated 2012-03-30 21:37:10.578885)

        Review request for Flume.

        Changes
        -------

        Updated patch attached.

        Summary
        -------

        Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do.

        This addresses bug FLUME-1078.
        https://issues.apache.org/jira/browse/FLUME-1078

        Diffs (updated)


        bin/flume-ng a31f171

        Diff: https://reviews.apache.org/r/4574/diff

        Testing
        -------

        Tested from the command line.

        Thanks,

        Brock

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4574/ ----------------------------------------------------------- (Updated 2012-03-30 21:37:10.578885) Review request for Flume. Changes ------- Updated patch attached. Summary ------- Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do. This addresses bug FLUME-1078 . https://issues.apache.org/jira/browse/FLUME-1078 Diffs (updated) bin/flume-ng a31f171 Diff: https://reviews.apache.org/r/4574/diff Testing ------- Tested from the command line. Thanks, Brock
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-03-30 20:28:46, Mike Percy wrote:

        > Hi Brock, looks great except that it allows the shell environment to specify $FLUME_CLASSPATH. The intention was to enforce that they come from conf/flume-env.sh. Please restore the line that initializes FLUME_CLASSPATH=""

        >

        > One nit: whitespace at the end of line 107

        Brock Noland wrote:

        Related projects such as hadoop and hbase allow you to append to the classpath via HADOOP_CLASSPATH and HBASE_CLASSPATH from the command line. e.g.:

        env HADOOP_CLASSPATH=/tmp/classpath/entry.jar hadoop command

        Is there a reason we don't want to be compatible?

        Mike Percy wrote:

        The difference is that the "hadoop" command is a client command-line tool, but the flume-ng script is primarily a startup script for the agent daemon. It's bad practice to start daemons using environment variables since it's not visible in "ps" and not reliably reproducible. So I would prefer not to support it. If you feel that it's an important feature that makes flume easier to use then I'm willing to let it go but I think it's a bad way to run a service.

        I am fine with this approach, I updated the patch. FWIW, the hadoop command is used to start all the hadoop daemons.

        • Brock

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4574/#review6588
        -----------------------------------------------------------

        On 2012-03-30 21:37:10, Brock Noland wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4574/

        -----------------------------------------------------------

        (Updated 2012-03-30 21:37:10)

        Review request for Flume.

        Summary

        -------

        Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do.

        This addresses bug FLUME-1078.

        https://issues.apache.org/jira/browse/FLUME-1078

        Diffs

        -----

        bin/flume-ng a31f171

        Diff: https://reviews.apache.org/r/4574/diff

        Testing

        -------

        Tested from the command line.

        Thanks,

        Brock

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-03-30 20:28:46, Mike Percy wrote: > Hi Brock, looks great except that it allows the shell environment to specify $FLUME_CLASSPATH. The intention was to enforce that they come from conf/flume-env.sh. Please restore the line that initializes FLUME_CLASSPATH="" > > One nit: whitespace at the end of line 107 Brock Noland wrote: Related projects such as hadoop and hbase allow you to append to the classpath via HADOOP_CLASSPATH and HBASE_CLASSPATH from the command line. e.g.: env HADOOP_CLASSPATH=/tmp/classpath/entry.jar hadoop command Is there a reason we don't want to be compatible? Mike Percy wrote: The difference is that the "hadoop" command is a client command-line tool, but the flume-ng script is primarily a startup script for the agent daemon. It's bad practice to start daemons using environment variables since it's not visible in "ps" and not reliably reproducible. So I would prefer not to support it. If you feel that it's an important feature that makes flume easier to use then I'm willing to let it go but I think it's a bad way to run a service. I am fine with this approach, I updated the patch. FWIW, the hadoop command is used to start all the hadoop daemons. Brock ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4574/#review6588 ----------------------------------------------------------- On 2012-03-30 21:37:10, Brock Noland wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4574/ ----------------------------------------------------------- (Updated 2012-03-30 21:37:10) Review request for Flume. Summary ------- Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do. This addresses bug FLUME-1078 . https://issues.apache.org/jira/browse/FLUME-1078 Diffs ----- bin/flume-ng a31f171 Diff: https://reviews.apache.org/r/4574/diff Testing ------- Tested from the command line. Thanks, Brock
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4574/#review6596
        -----------------------------------------------------------

        Looks good. Thanks Brock!

        • Mike

        On 2012-03-30 21:37:10, Brock Noland wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4574/

        -----------------------------------------------------------

        (Updated 2012-03-30 21:37:10)

        Review request for Flume.

        Summary

        -------

        Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do.

        This addresses bug FLUME-1078.

        https://issues.apache.org/jira/browse/FLUME-1078

        Diffs

        -----

        bin/flume-ng a31f171

        Diff: https://reviews.apache.org/r/4574/diff

        Testing

        -------

        Tested from the command line.

        Thanks,

        Brock

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4574/#review6596 ----------------------------------------------------------- Looks good. Thanks Brock! Mike On 2012-03-30 21:37:10, Brock Noland wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4574/ ----------------------------------------------------------- (Updated 2012-03-30 21:37:10) Review request for Flume. Summary ------- Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do. This addresses bug FLUME-1078 . https://issues.apache.org/jira/browse/FLUME-1078 Diffs ----- bin/flume-ng a31f171 Diff: https://reviews.apache.org/r/4574/diff Testing ------- Tested from the command line. Thanks, Brock
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4574/#review6610
        -----------------------------------------------------------

        Ship it!

        +1

        • Arvind

        On 2012-03-30 21:37:10, Brock Noland wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4574/

        -----------------------------------------------------------

        (Updated 2012-03-30 21:37:10)

        Review request for Flume.

        Summary

        -------

        Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do.

        This addresses bug FLUME-1078.

        https://issues.apache.org/jira/browse/FLUME-1078

        Diffs

        -----

        bin/flume-ng a31f171

        Diff: https://reviews.apache.org/r/4574/diff

        Testing

        -------

        Tested from the command line.

        Thanks,

        Brock

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4574/#review6610 ----------------------------------------------------------- Ship it! +1 Arvind On 2012-03-30 21:37:10, Brock Noland wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4574/ ----------------------------------------------------------- (Updated 2012-03-30 21:37:10) Review request for Flume. Summary ------- Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do. This addresses bug FLUME-1078 . https://issues.apache.org/jira/browse/FLUME-1078 Diffs ----- bin/flume-ng a31f171 Diff: https://reviews.apache.org/r/4574/diff Testing ------- Tested from the command line. Thanks, Brock
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-04-01 18:20:08, Arvind Prabhakar wrote:

        > +1

        Thanks for the patch Brock. Please attach it to the Jira.

        • Arvind

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4574/#review6610
        -----------------------------------------------------------

        On 2012-03-30 21:37:10, Brock Noland wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4574/

        -----------------------------------------------------------

        (Updated 2012-03-30 21:37:10)

        Review request for Flume.

        Summary

        -------

        Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do.

        This addresses bug FLUME-1078.

        https://issues.apache.org/jira/browse/FLUME-1078

        Diffs

        -----

        bin/flume-ng a31f171

        Diff: https://reviews.apache.org/r/4574/diff

        Testing

        -------

        Tested from the command line.

        Thanks,

        Brock

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-04-01 18:20:08, Arvind Prabhakar wrote: > +1 Thanks for the patch Brock. Please attach it to the Jira. Arvind ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4574/#review6610 ----------------------------------------------------------- On 2012-03-30 21:37:10, Brock Noland wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4574/ ----------------------------------------------------------- (Updated 2012-03-30 21:37:10) Review request for Flume. Summary ------- Attached changes FLUME_CLASSPATH to append to the classpath like HADOOP_CLASSPATH and HBASE_CLASSPATH do. This addresses bug FLUME-1078 . https://issues.apache.org/jira/browse/FLUME-1078 Diffs ----- bin/flume-ng a31f171 Diff: https://reviews.apache.org/r/4574/diff Testing ------- Tested from the command line. Thanks, Brock
        Hide
        Brock Noland added a comment -

        patch from RB

        Show
        Brock Noland added a comment - patch from RB
        Hide
        Mike Percy added a comment -

        Can we get this checked in?

        Show
        Mike Percy added a comment - Can we get this checked in?
        Hide
        Brock Noland added a comment -

        Sorry I missed the +1 from Arvind. I will commit this now.

        Show
        Brock Noland added a comment - Sorry I missed the +1 from Arvind. I will commit this now.
        Hide
        Brock Noland added a comment -

        1327199

        Show
        Brock Noland added a comment - 1327199
        Hide
        Hudson added a comment -

        Integrated in flume-trunk #173 (See https://builds.apache.org/job/flume-trunk/173/)
        FLUME-1078: flume-ng script has no way to add, not replace, classpath

        (Brock Noland) (Revision 1327199)

        Result = SUCCESS
        brock : http://svn.apache.org/viewvc/?view=rev&rev=1327199
        Files :

        • /incubator/flume/trunk/bin/flume-ng
        Show
        Hudson added a comment - Integrated in flume-trunk #173 (See https://builds.apache.org/job/flume-trunk/173/ ) FLUME-1078 : flume-ng script has no way to add, not replace, classpath (Brock Noland) (Revision 1327199) Result = SUCCESS brock : http://svn.apache.org/viewvc/?view=rev&rev=1327199 Files : /incubator/flume/trunk/bin/flume-ng

          People

          • Assignee:
            Brock Noland
            Reporter:
            Brock Noland
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development