Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: v1.0.0
    • Fix Version/s: v1.2.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently the configuration provider implementation encompasses all the syntactic and structural validation rules for loading the configuration. Externalizing this functionality to a library will allow external tools to easily operate on flume configuration files and be able to help parse and validate these files.

      Currently the configuration of each component sits deep inside the component themselves. There is no way to verify if a configuration is valid before run time. In most systems like Flume, it is likely that these confs will be deployed from one single host, on to the machines where flume agents are running. Only when each agent starts, invalid confs are identified because the Agents would terminate by throwing exceptions. This is a first attempt to make a component-aware configuration system which is independent of the Flume, and does not require the Flume jar to be installed. Each component needs a configuration manager, which configures the components.

      Provide abstract Configuration stubs for each component type, sources, channels, sinks, selectors etc, which are in the new package, independent on ng-core. Now for each of the channels extend the abstract class and check the config properties for each of the required parameters for that component, for example: MultiplexingChannelSelectorConfigurator would look for default channel etc. If a particular component does not have a configuration class then let the current mechanism continue.

      This will require implementation for each component, but it should not be too complex. One additional advantage we get from this is that we can separate out the config validation from the components into these stubs, but we will still need to read the values out of the Context as we do currently(else we end up making the configuration dependent on flume-ng-core itself which we wanted to avoid).

      A problem with this is making a change to the configuration would require changes in the configuration classes and in the components also(where the configuration is read and the component is actually configured). I could not figure out a way of avoiding this.

      1. FLUME-1052-2.patch
        169 kB
        Hari Shreedharan

        Activity

        Hari Shreedharan created issue -
        Hari Shreedharan made changes -
        Field Original Value New Value
        Summary CLONE - Need a library that would allow external tools to parse and validate flume properties file configuration Core configuration component
        Hari Shreedharan made changes -
        Description Currently the configuration provider implementation encompasses all the syntactic and structural validation rules for loading the configuration. Externalizing this functionality to a library will allow external tools to easily operate on flume configuration files and be able to help parse and validate these files. Currently the configuration provider implementation encompasses all the syntactic and structural validation rules for loading the configuration. Externalizing this functionality to a library will allow external tools to easily operate on flume configuration files and be able to help parse and validate these files.

        Currently the configuration of each component sits deep inside the component themselves. There is no way to verify if a configuration is valid before run time. In most systems like Flume, it is likely that these confs will be deployed from one single host, on to the machines where flume agents are running. Only when each agent starts, invalid confs are identified because the Agents would terminate by throwing exceptions. This is a first attempt to make a component-aware configuration system which is independent of the Flume, and does not require the Flume jar to be installed. Each component needs a configuration manager, which configures the components.

        Provide abstract Configuration stubs for each component type, sources, channels, sinks, selectors etc, which are in the new package, independent on ng-core. Now for each of the channels extend the abstract class and check the config properties for each of the required parameters for that component, for example: MultiplexingChannelSelectorConfigurator would look for default channel etc. If a particular component does not have a configuration class then let the current mechanism continue.

        This will require implementation for each component, but it should not be too complex. One additional advantage we get from this is that we can separate out the config validation from the components into these stubs, but we will still need to read the values out of the Context as we do currently(else we end up making the configuration dependent on flume-ng-core itself which we wanted to avoid).

        A problem with this is making a change to the configuration would require changes in the configuration classes and in the components also(where the configuration is read and the component is actually configured). I could not figure out a way of avoiding this.
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4502/
        -----------------------------------------------------------

        Review request for Flume.

        Summary
        -------

        Main config component.

        This addresses bug FLUME-1052.
        https://issues.apache.org/jira/browse/FLUME-1052

        Diffs


        flume-ng-configuration/pom.xml PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/Context.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION
        flume-ng-core/pom.xml 37fb112
        flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31
        flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java PRE-CREATION
        flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5
        flume-ng-core/src/test/java/org/apache/flume/sink/TestFailoverSinkProcessor.java 3358cf4
        flume-ng-core/src/test/java/org/apache/flume/sink/TestLoggerSink.java 92ff6fe
        flume-ng-core/src/test/java/org/apache/flume/sink/TestRollingFileSink.java 7e26e2a
        flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1
        flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 50b9f0c
        pom.xml c91222f

        Diff: https://reviews.apache.org/r/4502/diff

        Testing
        -------

        Functional testing done.

        Thanks,

        Hari

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4502/ ----------------------------------------------------------- Review request for Flume. Summary ------- Main config component. This addresses bug FLUME-1052 . https://issues.apache.org/jira/browse/FLUME-1052 Diffs flume-ng-configuration/pom.xml PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/Context.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION flume-ng-core/pom.xml 37fb112 flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31 flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java PRE-CREATION flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5 flume-ng-core/src/test/java/org/apache/flume/sink/TestFailoverSinkProcessor.java 3358cf4 flume-ng-core/src/test/java/org/apache/flume/sink/TestLoggerSink.java 92ff6fe flume-ng-core/src/test/java/org/apache/flume/sink/TestRollingFileSink.java 7e26e2a flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1 flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 50b9f0c pom.xml c91222f Diff: https://reviews.apache.org/r/4502/diff Testing ------- Functional testing done. Thanks, Hari
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4502/#review6429
        -----------------------------------------------------------

        Thanks for the patch Hari. The changes look good. Some minor feedback follows:

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java
        <https://reviews.apache.org/r/4502/#comment14024>

        This constant is defined twice - ComponentConfiguration and FlumeConfiguration. It will be better to externalize it in one constants class and reference it from there. Same for other constants too.

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java
        <https://reviews.apache.org/r/4502/#comment14023>

        please use different variable name as it is error prone to use names that shadow member variables.

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java
        <https://reviews.apache.org/r/4502/#comment14025>

        nit: suggest renaming this to failIfConfigured

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java
        <https://reviews.apache.org/r/4502/#comment14026>

        nit: suggest using a switch/case

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java
        <https://reviews.apache.org/r/4502/#comment14027>

        ("Cannot create configuration! Unknown Type specified: " + component)

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java
        <https://reviews.apache.org/r/4502/#comment14028>

        This should extend FlumeException to be consistent.

        flume-ng-configuration/src/main/java/org/apache/flume/conf/Context.java
        <https://reviews.apache.org/r/4502/#comment14022>

        Please do not change the package as that will break backward compatibility.

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java
        <https://reviews.apache.org/r/4502/#comment14021>

        These dependencies are missing. You need to move them into this module.

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java
        <https://reviews.apache.org/r/4502/#comment14029>

        This seems redundant as the addRawProperty() method will perform these checks anyway.

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java
        <https://reviews.apache.org/r/4502/#comment14032>

        I see that this check has been disabled for various components. Without this, the active component check, required attribute checks will not happen. How is the code handling those right now?

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java
        <https://reviews.apache.org/r/4502/#comment14030>

        Looks like this check needs to happen before the if(channelSet.size() == 0) check.

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java
        <https://reviews.apache.org/r/4502/#comment14034>

        Need to handle the case where the config is not specified, but the component is a standard component. In such cases, the component type enum should be used to determine the config holder class.

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java
        <https://reviews.apache.org/r/4502/#comment14035>

        Please do not use exclamation marks in error messages.

        flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java
        <https://reviews.apache.org/r/4502/#comment14036>

        s/Configuring channels

        • Arvind

        On 2012-03-27 06:17:30, Hari Shreedharan wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4502/

        -----------------------------------------------------------

        (Updated 2012-03-27 06:17:30)

        Review request for Flume.

        Summary

        -------

        Main config component.

        This addresses bug FLUME-1052.

        https://issues.apache.org/jira/browse/FLUME-1052

        Diffs

        -----

        flume-ng-configuration/pom.xml PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/Context.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION

        flume-ng-core/pom.xml 37fb112

        flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31

        flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java PRE-CREATION

        flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5

        flume-ng-core/src/test/java/org/apache/flume/sink/TestFailoverSinkProcessor.java 3358cf4

        flume-ng-core/src/test/java/org/apache/flume/sink/TestLoggerSink.java 92ff6fe

        flume-ng-core/src/test/java/org/apache/flume/sink/TestRollingFileSink.java 7e26e2a

        flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1

        flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 50b9f0c

        pom.xml c91222f

        Diff: https://reviews.apache.org/r/4502/diff

        Testing

        -------

        Functional testing done.

        Thanks,

        Hari

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4502/#review6429 ----------------------------------------------------------- Thanks for the patch Hari. The changes look good. Some minor feedback follows: We follow the a variant of standard Java coding conventions. Please make sure your code is formatted accordingly. More details on this can be found at https://cwiki.apache.org/confluence/display/FLUME/How+to+Contribute#HowtoContribute-CodeQuality . flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java < https://reviews.apache.org/r/4502/#comment14024 > This constant is defined twice - ComponentConfiguration and FlumeConfiguration. It will be better to externalize it in one constants class and reference it from there. Same for other constants too. flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java < https://reviews.apache.org/r/4502/#comment14023 > please use different variable name as it is error prone to use names that shadow member variables. flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java < https://reviews.apache.org/r/4502/#comment14025 > nit: suggest renaming this to failIfConfigured flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java < https://reviews.apache.org/r/4502/#comment14026 > nit: suggest using a switch/case flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java < https://reviews.apache.org/r/4502/#comment14027 > ("Cannot create configuration! Unknown Type specified: " + component) flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java < https://reviews.apache.org/r/4502/#comment14028 > This should extend FlumeException to be consistent. flume-ng-configuration/src/main/java/org/apache/flume/conf/Context.java < https://reviews.apache.org/r/4502/#comment14022 > Please do not change the package as that will break backward compatibility. flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java < https://reviews.apache.org/r/4502/#comment14021 > These dependencies are missing. You need to move them into this module. flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java < https://reviews.apache.org/r/4502/#comment14029 > This seems redundant as the addRawProperty() method will perform these checks anyway. flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java < https://reviews.apache.org/r/4502/#comment14032 > I see that this check has been disabled for various components. Without this, the active component check, required attribute checks will not happen. How is the code handling those right now? flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java < https://reviews.apache.org/r/4502/#comment14030 > Looks like this check needs to happen before the if(channelSet.size() == 0) check. flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java < https://reviews.apache.org/r/4502/#comment14034 > Need to handle the case where the config is not specified, but the component is a standard component. In such cases, the component type enum should be used to determine the config holder class. flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java < https://reviews.apache.org/r/4502/#comment14035 > Please do not use exclamation marks in error messages. flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java < https://reviews.apache.org/r/4502/#comment14036 > s/Configuring channels Arvind On 2012-03-27 06:17:30, Hari Shreedharan wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4502/ ----------------------------------------------------------- (Updated 2012-03-27 06:17:30) Review request for Flume. Summary ------- Main config component. This addresses bug FLUME-1052 . https://issues.apache.org/jira/browse/FLUME-1052 Diffs ----- flume-ng-configuration/pom.xml PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/Context.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION flume-ng-core/pom.xml 37fb112 flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31 flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java PRE-CREATION flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5 flume-ng-core/src/test/java/org/apache/flume/sink/TestFailoverSinkProcessor.java 3358cf4 flume-ng-core/src/test/java/org/apache/flume/sink/TestLoggerSink.java 92ff6fe flume-ng-core/src/test/java/org/apache/flume/sink/TestRollingFileSink.java 7e26e2a flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1 flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 50b9f0c pom.xml c91222f Diff: https://reviews.apache.org/r/4502/diff Testing ------- Functional testing done. Thanks, Hari
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-03-27 17:31:44, Arvind Prabhakar wrote:

        > flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java, line 399

        > <https://reviews.apache.org/r/4502/diff/1/?file=96766#file96766line399>

        >

        > Need to handle the case where the config is not specified, but the component is a standard component. In such cases, the component type enum should be used to determine the config holder class.

        If it is a known component, the getKnownChannel function returns the ChannelType enum instance which points to that channel, and that is set to the config object. This config object is what is used to create the configuration object. If we have memory in the conf, chType will be ChannelType.MEMORY and toString() will return MEMORY. This is then used to create the MemoryChannelConfiguration object.

        Therefore, standard components are handled, so the case mentioned above works ok.

        On 2012-03-27 17:31:44, Arvind Prabhakar wrote:

        > flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java, line 312

        > <https://reviews.apache.org/r/4502/diff/1/?file=96766#file96766line312>

        >

        > Looks like this check needs to happen before the if(channelSet.size() == 0) check.

        Yes, will move it up.

        On 2012-03-27 17:31:44, Arvind Prabhakar wrote:

        > flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java, lines 300-301

        > <https://reviews.apache.org/r/4502/diff/1/?file=96766#file96766line300>

        >

        > I see that this check has been disabled for various components. Without this, the active component check, required attribute checks will not happen. How is the code handling those right now?

        Each of the basic configuration types - SourceConfiguration, SinkConfiguration, ChannelConfiguration etc. do the basic checks required for individual components.

        On 2012-03-27 17:31:44, Arvind Prabhakar wrote:

        > flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java, lines 88-90

        > <https://reviews.apache.org/r/4502/diff/1/?file=96766#file96766line88>

        >

        > This seems redundant as the addRawProperty() method will perform these checks anyway.

        I believe this is done in FlumeConfiguration even now, I will remove it anyway.

        On 2012-03-27 17:31:44, Arvind Prabhakar wrote:

        > flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java, lines 36-42

        > <https://reviews.apache.org/r/4502/diff/1/?file=96766#file96766line36>

        >

        > These dependencies are missing. You need to move them into this module.

        These are in a different patch, I will add them here.

        On 2012-03-27 17:31:44, Arvind Prabhakar wrote:

        > flume-ng-configuration/src/main/java/org/apache/flume/conf/Context.java, line 20

        > <https://reviews.apache.org/r/4502/diff/1/?file=96765#file96765line20>

        >

        > Please do not change the package as that will break backward compatibility.

        Yes.will do.

        On 2012-03-27 17:31:44, Arvind Prabhakar wrote:

        > flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java, line 21

        > <https://reviews.apache.org/r/4502/diff/1/?file=96764#file96764line21>

        >

        > This should extend FlumeException to be consistent.

        ok

        • Hari

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4502/#review6429
        -----------------------------------------------------------

        On 2012-03-27 06:17:30, Hari Shreedharan wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4502/

        -----------------------------------------------------------

        (Updated 2012-03-27 06:17:30)

        Review request for Flume.

        Summary

        -------

        Main config component.

        This addresses bug FLUME-1052.

        https://issues.apache.org/jira/browse/FLUME-1052

        Diffs

        -----

        flume-ng-configuration/pom.xml PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/Context.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION

        flume-ng-core/pom.xml 37fb112

        flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31

        flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java PRE-CREATION

        flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5

        flume-ng-core/src/test/java/org/apache/flume/sink/TestFailoverSinkProcessor.java 3358cf4

        flume-ng-core/src/test/java/org/apache/flume/sink/TestLoggerSink.java 92ff6fe

        flume-ng-core/src/test/java/org/apache/flume/sink/TestRollingFileSink.java 7e26e2a

        flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1

        flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 50b9f0c

        pom.xml c91222f

        Diff: https://reviews.apache.org/r/4502/diff

        Testing

        -------

        Functional testing done.

        Thanks,

        Hari

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-03-27 17:31:44, Arvind Prabhakar wrote: > flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java, line 399 > < https://reviews.apache.org/r/4502/diff/1/?file=96766#file96766line399 > > > Need to handle the case where the config is not specified, but the component is a standard component. In such cases, the component type enum should be used to determine the config holder class. If it is a known component, the getKnownChannel function returns the ChannelType enum instance which points to that channel, and that is set to the config object. This config object is what is used to create the configuration object. If we have memory in the conf, chType will be ChannelType.MEMORY and toString() will return MEMORY. This is then used to create the MemoryChannelConfiguration object. Therefore, standard components are handled, so the case mentioned above works ok. On 2012-03-27 17:31:44, Arvind Prabhakar wrote: > flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java, line 312 > < https://reviews.apache.org/r/4502/diff/1/?file=96766#file96766line312 > > > Looks like this check needs to happen before the if(channelSet.size() == 0) check. Yes, will move it up. On 2012-03-27 17:31:44, Arvind Prabhakar wrote: > flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java, lines 300-301 > < https://reviews.apache.org/r/4502/diff/1/?file=96766#file96766line300 > > > I see that this check has been disabled for various components. Without this, the active component check, required attribute checks will not happen. How is the code handling those right now? Each of the basic configuration types - SourceConfiguration, SinkConfiguration, ChannelConfiguration etc. do the basic checks required for individual components. On 2012-03-27 17:31:44, Arvind Prabhakar wrote: > flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java, lines 88-90 > < https://reviews.apache.org/r/4502/diff/1/?file=96766#file96766line88 > > > This seems redundant as the addRawProperty() method will perform these checks anyway. I believe this is done in FlumeConfiguration even now, I will remove it anyway. On 2012-03-27 17:31:44, Arvind Prabhakar wrote: > flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java, lines 36-42 > < https://reviews.apache.org/r/4502/diff/1/?file=96766#file96766line36 > > > These dependencies are missing. You need to move them into this module. These are in a different patch, I will add them here. On 2012-03-27 17:31:44, Arvind Prabhakar wrote: > flume-ng-configuration/src/main/java/org/apache/flume/conf/Context.java, line 20 > < https://reviews.apache.org/r/4502/diff/1/?file=96765#file96765line20 > > > Please do not change the package as that will break backward compatibility. Yes.will do. On 2012-03-27 17:31:44, Arvind Prabhakar wrote: > flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java, line 21 > < https://reviews.apache.org/r/4502/diff/1/?file=96764#file96764line21 > > > This should extend FlumeException to be consistent. ok Hari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4502/#review6429 ----------------------------------------------------------- On 2012-03-27 06:17:30, Hari Shreedharan wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4502/ ----------------------------------------------------------- (Updated 2012-03-27 06:17:30) Review request for Flume. Summary ------- Main config component. This addresses bug FLUME-1052 . https://issues.apache.org/jira/browse/FLUME-1052 Diffs ----- flume-ng-configuration/pom.xml PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/Context.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION flume-ng-core/pom.xml 37fb112 flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31 flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java PRE-CREATION flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5 flume-ng-core/src/test/java/org/apache/flume/sink/TestFailoverSinkProcessor.java 3358cf4 flume-ng-core/src/test/java/org/apache/flume/sink/TestLoggerSink.java 92ff6fe flume-ng-core/src/test/java/org/apache/flume/sink/TestRollingFileSink.java 7e26e2a flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1 flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 50b9f0c pom.xml c91222f Diff: https://reviews.apache.org/r/4502/diff Testing ------- Functional testing done. Thanks, Hari
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-03-27 17:31:44, Arvind Prabhakar wrote:

        > flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java, lines 36-42

        > <https://reviews.apache.org/r/4502/diff/1/?file=96766#file96766line36>

        >

        > These dependencies are missing. You need to move them into this module.

        Hari Shreedharan wrote:

        These are in a different patch, I will add them here.

        Thanks. Otherwise I cannot compile your patch.

        On 2012-03-27 17:31:44, Arvind Prabhakar wrote:

        > flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java, line 399

        > <https://reviews.apache.org/r/4502/diff/1/?file=96766#file96766line399>

        >

        > Need to handle the case where the config is not specified, but the component is a standard component. In such cases, the component type enum should be used to determine the config holder class.

        Hari Shreedharan wrote:

        If it is a known component, the getKnownChannel function returns the ChannelType enum instance which points to that channel, and that is set to the config object. This config object is what is used to create the configuration object. If we have memory in the conf, chType will be ChannelType.MEMORY and toString() will return MEMORY. This is then used to create the MemoryChannelConfiguration object.

        Therefore, standard components are handled, so the case mentioned above works ok.

        Thanks for the explanation Hari.

        • Arvind

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4502/#review6429
        -----------------------------------------------------------

        On 2012-03-27 06:17:30, Hari Shreedharan wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4502/

        -----------------------------------------------------------

        (Updated 2012-03-27 06:17:30)

        Review request for Flume.

        Summary

        -------

        Main config component.

        This addresses bug FLUME-1052.

        https://issues.apache.org/jira/browse/FLUME-1052

        Diffs

        -----

        flume-ng-configuration/pom.xml PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/Context.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION

        flume-ng-core/pom.xml 37fb112

        flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31

        flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java PRE-CREATION

        flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5

        flume-ng-core/src/test/java/org/apache/flume/sink/TestFailoverSinkProcessor.java 3358cf4

        flume-ng-core/src/test/java/org/apache/flume/sink/TestLoggerSink.java 92ff6fe

        flume-ng-core/src/test/java/org/apache/flume/sink/TestRollingFileSink.java 7e26e2a

        flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1

        flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 50b9f0c

        pom.xml c91222f

        Diff: https://reviews.apache.org/r/4502/diff

        Testing

        -------

        Functional testing done.

        Thanks,

        Hari

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-03-27 17:31:44, Arvind Prabhakar wrote: > flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java, lines 36-42 > < https://reviews.apache.org/r/4502/diff/1/?file=96766#file96766line36 > > > These dependencies are missing. You need to move them into this module. Hari Shreedharan wrote: These are in a different patch, I will add them here. Thanks. Otherwise I cannot compile your patch. On 2012-03-27 17:31:44, Arvind Prabhakar wrote: > flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java, line 399 > < https://reviews.apache.org/r/4502/diff/1/?file=96766#file96766line399 > > > Need to handle the case where the config is not specified, but the component is a standard component. In such cases, the component type enum should be used to determine the config holder class. Hari Shreedharan wrote: If it is a known component, the getKnownChannel function returns the ChannelType enum instance which points to that channel, and that is set to the config object. This config object is what is used to create the configuration object. If we have memory in the conf, chType will be ChannelType.MEMORY and toString() will return MEMORY. This is then used to create the MemoryChannelConfiguration object. Therefore, standard components are handled, so the case mentioned above works ok. Thanks for the explanation Hari. Arvind ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4502/#review6429 ----------------------------------------------------------- On 2012-03-27 06:17:30, Hari Shreedharan wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4502/ ----------------------------------------------------------- (Updated 2012-03-27 06:17:30) Review request for Flume. Summary ------- Main config component. This addresses bug FLUME-1052 . https://issues.apache.org/jira/browse/FLUME-1052 Diffs ----- flume-ng-configuration/pom.xml PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/Context.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION flume-ng-core/pom.xml 37fb112 flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31 flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java PRE-CREATION flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5 flume-ng-core/src/test/java/org/apache/flume/sink/TestFailoverSinkProcessor.java 3358cf4 flume-ng-core/src/test/java/org/apache/flume/sink/TestLoggerSink.java 92ff6fe flume-ng-core/src/test/java/org/apache/flume/sink/TestRollingFileSink.java 7e26e2a flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1 flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 50b9f0c pom.xml c91222f Diff: https://reviews.apache.org/r/4502/diff Testing ------- Functional testing done. Thanks, Hari
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4502/
        -----------------------------------------------------------

        (Updated 2012-03-29 21:58:26.193754)

        Review request for Flume.

        Changes
        -------

        Added the dependencies into this patch. Made sure it builds.

        Summary
        -------

        Main config component.

        This addresses bug FLUME-1052.
        https://issues.apache.org/jira/browse/FLUME-1052

        Diffs (updated)


        flume-ng-configuration/pom.xml PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/Context.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorType.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkGroupConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorType.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java PRE-CREATION
        flume-ng-core/pom.xml 37fb112
        flume-ng-core/src/main/java/org/apache/flume/ChannelSelector.java fba2dcb
        flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31
        flume-ng-core/src/main/java/org/apache/flume/SinkProcessor.java d863ed0
        flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java be1891b
        flume-ng-core/src/main/java/org/apache/flume/channel/AbstractChannel.java 352bf08
        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorFactory.java 800f471
        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorType.java 511fc65
        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java d8419e8
        flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java 963a6a3
        flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java PRE-CREATION
        flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5
        flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkFactory.java b89dfa0
        flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkProcessor.java 257bab3
        flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java 6160a17
        flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 6b08c09
        flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java a610e6f
        flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java 9082470
        flume-ng-core/src/test/java/org/apache/flume/channel/AbstractBasicChannelSemanticsTest.java 6e71e46
        flume-ng-core/src/test/java/org/apache/flume/channel/MockChannel.java 24b01e2
        flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1
        flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 50b9f0c
        pom.xml c91222f

        Diff: https://reviews.apache.org/r/4502/diff

        Testing
        -------

        Functional testing done.

        Thanks,

        Hari

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4502/ ----------------------------------------------------------- (Updated 2012-03-29 21:58:26.193754) Review request for Flume. Changes ------- Added the dependencies into this patch. Made sure it builds. Summary ------- Main config component. This addresses bug FLUME-1052 . https://issues.apache.org/jira/browse/FLUME-1052 Diffs (updated) flume-ng-configuration/pom.xml PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/Context.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkGroupConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java PRE-CREATION flume-ng-core/pom.xml 37fb112 flume-ng-core/src/main/java/org/apache/flume/ChannelSelector.java fba2dcb flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31 flume-ng-core/src/main/java/org/apache/flume/SinkProcessor.java d863ed0 flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java be1891b flume-ng-core/src/main/java/org/apache/flume/channel/AbstractChannel.java 352bf08 flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorFactory.java 800f471 flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorType.java 511fc65 flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java d8419e8 flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java 963a6a3 flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java PRE-CREATION flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5 flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkFactory.java b89dfa0 flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkProcessor.java 257bab3 flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java 6160a17 flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 6b08c09 flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java a610e6f flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java 9082470 flume-ng-core/src/test/java/org/apache/flume/channel/AbstractBasicChannelSemanticsTest.java 6e71e46 flume-ng-core/src/test/java/org/apache/flume/channel/MockChannel.java 24b01e2 flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1 flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 50b9f0c pom.xml c91222f Diff: https://reviews.apache.org/r/4502/diff Testing ------- Functional testing done. Thanks, Hari
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4502/
        -----------------------------------------------------------

        (Updated 2012-03-30 07:32:58.686432)

        Review request for Flume.

        Changes
        -------

        Adding many default features to the core conf patch. Flume node now works with even the built in components, even without config stubs.

        Summary
        -------

        Main config component.

        This addresses bug FLUME-1052.
        https://issues.apache.org/jira/browse/FLUME-1052

        Diffs (updated)


        flume-ng-configuration/pom.xml PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/Context.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorType.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkGroupConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorType.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java PRE-CREATION
        flume-ng-core/pom.xml 37fb112
        flume-ng-core/src/main/java/org/apache/flume/ChannelSelector.java fba2dcb
        flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31
        flume-ng-core/src/main/java/org/apache/flume/SinkProcessor.java d863ed0
        flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java be1891b
        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorFactory.java 800f471
        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorType.java 511fc65
        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java d8419e8
        flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java 963a6a3
        flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java PRE-CREATION
        flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5
        flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkFactory.java b89dfa0
        flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkProcessor.java 257bab3
        flume-ng-core/src/main/java/org/apache/flume/sink/SinkGroup.java 0dffd69
        flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java 6160a17
        flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 6b08c09
        flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java a610e6f
        flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java 9082470
        flume-ng-dist/pom.xml 4c49452
        flume-ng-dist/src/main/assembly/dist.xml 7e401ae
        flume-ng-dist/src/main/assembly/src.xml bd4f090
        flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1
        flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 50b9f0c
        pom.xml c91222f

        Diff: https://reviews.apache.org/r/4502/diff

        Testing
        -------

        Functional testing done.

        Thanks,

        Hari

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4502/ ----------------------------------------------------------- (Updated 2012-03-30 07:32:58.686432) Review request for Flume. Changes ------- Adding many default features to the core conf patch. Flume node now works with even the built in components, even without config stubs. Summary ------- Main config component. This addresses bug FLUME-1052 . https://issues.apache.org/jira/browse/FLUME-1052 Diffs (updated) flume-ng-configuration/pom.xml PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/Context.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkGroupConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java PRE-CREATION flume-ng-core/pom.xml 37fb112 flume-ng-core/src/main/java/org/apache/flume/ChannelSelector.java fba2dcb flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31 flume-ng-core/src/main/java/org/apache/flume/SinkProcessor.java d863ed0 flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java be1891b flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorFactory.java 800f471 flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorType.java 511fc65 flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java d8419e8 flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java 963a6a3 flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java PRE-CREATION flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5 flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkFactory.java b89dfa0 flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkProcessor.java 257bab3 flume-ng-core/src/main/java/org/apache/flume/sink/SinkGroup.java 0dffd69 flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java 6160a17 flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 6b08c09 flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java a610e6f flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java 9082470 flume-ng-dist/pom.xml 4c49452 flume-ng-dist/src/main/assembly/dist.xml 7e401ae flume-ng-dist/src/main/assembly/src.xml bd4f090 flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1 flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 50b9f0c pom.xml c91222f Diff: https://reviews.apache.org/r/4502/diff Testing ------- Functional testing done. Thanks, Hari
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4502/
        -----------------------------------------------------------

        (Updated 2012-04-13 21:52:25.670555)

        Review request for Flume.

        Changes
        -------

        Rebased on trunk.

        Summary
        -------

        Main config component.

        This addresses bug FLUME-1052.
        https://issues.apache.org/jira/browse/FLUME-1052

        Diffs (updated)


        flume-ng-configuration/pom.xml PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/Context.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorType.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkGroupConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorType.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java PRE-CREATION
        flume-ng-core/pom.xml 37fb112
        flume-ng-core/src/main/java/org/apache/flume/ChannelSelector.java fba2dcb
        flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31
        flume-ng-core/src/main/java/org/apache/flume/SinkProcessor.java d863ed0
        flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java be1891b
        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorFactory.java 800f471
        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorType.java 511fc65
        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java d8419e8
        flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java 963a6a3
        flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java PRE-CREATION
        flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5
        flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkFactory.java b89dfa0
        flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkProcessor.java 257bab3
        flume-ng-core/src/main/java/org/apache/flume/sink/SinkGroup.java 0dffd69
        flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java 6160a17
        flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 6b08c09
        flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java a610e6f
        flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java cd8991e
        flume-ng-dist/pom.xml 642e681
        flume-ng-dist/src/main/assembly/dist.xml 7e401ae
        flume-ng-dist/src/main/assembly/src.xml bd4f090
        flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1
        flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 1f0e8c6
        pom.xml 3a9bc42

        Diff: https://reviews.apache.org/r/4502/diff

        Testing
        -------

        Functional testing done.

        Thanks,

        Hari

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4502/ ----------------------------------------------------------- (Updated 2012-04-13 21:52:25.670555) Review request for Flume. Changes ------- Rebased on trunk. Summary ------- Main config component. This addresses bug FLUME-1052 . https://issues.apache.org/jira/browse/FLUME-1052 Diffs (updated) flume-ng-configuration/pom.xml PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/Context.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkGroupConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java PRE-CREATION flume-ng-core/pom.xml 37fb112 flume-ng-core/src/main/java/org/apache/flume/ChannelSelector.java fba2dcb flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31 flume-ng-core/src/main/java/org/apache/flume/SinkProcessor.java d863ed0 flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java be1891b flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorFactory.java 800f471 flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorType.java 511fc65 flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java d8419e8 flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java 963a6a3 flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java PRE-CREATION flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5 flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkFactory.java b89dfa0 flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkProcessor.java 257bab3 flume-ng-core/src/main/java/org/apache/flume/sink/SinkGroup.java 0dffd69 flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java 6160a17 flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 6b08c09 flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java a610e6f flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java cd8991e flume-ng-dist/pom.xml 642e681 flume-ng-dist/src/main/assembly/dist.xml 7e401ae flume-ng-dist/src/main/assembly/src.xml bd4f090 flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1 flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 1f0e8c6 pom.xml 3a9bc42 Diff: https://reviews.apache.org/r/4502/diff Testing ------- Functional testing done. Thanks, Hari
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4502/#review6970
        -----------------------------------------------------------

        I finally had time to go through this huge patch. Great work!
        In general it looks good, with a small number of minor niggles. Hopefully we can get this in before more major changes take place on the trunk.
        One other issue I have is that there is a lot of non-DRY code that looks like editted copy-paste. It may be a bit much to fix now, but hopefully in the future it can be refactored.

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java
        <https://reviews.apache.org/r/4502/#comment15524>

        s/PropertiesFileConfgurationProvider/PropertiesFileConfigurationProvider/

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java
        <https://reviews.apache.org/r/4502/#comment15523>

        s/configuation/configuration/

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java
        <https://reviews.apache.org/r/4502/#comment15526>

        do you think you could rename this to channelName for code clarity? Same thing for the validateSource/Sinks

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java
        <https://reviews.apache.org/r/4502/#comment15527>

        ChannelType->SourceType

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java
        <https://reviews.apache.org/r/4502/#comment15528>

        ChannelType-> SinkType

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java
        <https://reviews.apache.org/r/4502/#comment15529>

        I don't think this doc applies for the validateGroups as there is only one type of group configuration and it is handled here

        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java
        <https://reviews.apache.org/r/4502/#comment15547>

        I believe you'll need to add in the new channels here

        • Juhani

        On 2012-04-13 21:52:25, Hari Shreedharan wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4502/

        -----------------------------------------------------------

        (Updated 2012-04-13 21:52:25)

        Review request for Flume.

        Summary

        -------

        Main config component.

        This addresses bug FLUME-1052.

        https://issues.apache.org/jira/browse/FLUME-1052

        Diffs

        -----

        flume-ng-configuration/pom.xml PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/Context.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorType.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkGroupConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorType.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java PRE-CREATION

        flume-ng-core/pom.xml 37fb112

        flume-ng-core/src/main/java/org/apache/flume/ChannelSelector.java fba2dcb

        flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31

        flume-ng-core/src/main/java/org/apache/flume/SinkProcessor.java d863ed0

        flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java be1891b

        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorFactory.java 800f471

        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorType.java 511fc65

        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java d8419e8

        flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java 963a6a3

        flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java PRE-CREATION

        flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5

        flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkFactory.java b89dfa0

        flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkProcessor.java 257bab3

        flume-ng-core/src/main/java/org/apache/flume/sink/SinkGroup.java 0dffd69

        flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java 6160a17

        flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 6b08c09

        flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java a610e6f

        flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java cd8991e

        flume-ng-dist/pom.xml 642e681

        flume-ng-dist/src/main/assembly/dist.xml 7e401ae

        flume-ng-dist/src/main/assembly/src.xml bd4f090

        flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1

        flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 1f0e8c6

        pom.xml 3a9bc42

        Diff: https://reviews.apache.org/r/4502/diff

        Testing

        -------

        Functional testing done.

        Thanks,

        Hari

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4502/#review6970 ----------------------------------------------------------- I finally had time to go through this huge patch. Great work! In general it looks good, with a small number of minor niggles. Hopefully we can get this in before more major changes take place on the trunk. One other issue I have is that there is a lot of non-DRY code that looks like editted copy-paste. It may be a bit much to fix now, but hopefully in the future it can be refactored. flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java < https://reviews.apache.org/r/4502/#comment15524 > s/PropertiesFileConfgurationProvider/PropertiesFileConfigurationProvider/ flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java < https://reviews.apache.org/r/4502/#comment15523 > s/configuation/configuration/ flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java < https://reviews.apache.org/r/4502/#comment15526 > do you think you could rename this to channelName for code clarity? Same thing for the validateSource/Sinks flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java < https://reviews.apache.org/r/4502/#comment15527 > ChannelType->SourceType flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java < https://reviews.apache.org/r/4502/#comment15528 > ChannelType-> SinkType flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java < https://reviews.apache.org/r/4502/#comment15529 > I don't think this doc applies for the validateGroups as there is only one type of group configuration and it is handled here flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java < https://reviews.apache.org/r/4502/#comment15547 > I believe you'll need to add in the new channels here Juhani On 2012-04-13 21:52:25, Hari Shreedharan wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4502/ ----------------------------------------------------------- (Updated 2012-04-13 21:52:25) Review request for Flume. Summary ------- Main config component. This addresses bug FLUME-1052 . https://issues.apache.org/jira/browse/FLUME-1052 Diffs ----- flume-ng-configuration/pom.xml PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/Context.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkGroupConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java PRE-CREATION flume-ng-core/pom.xml 37fb112 flume-ng-core/src/main/java/org/apache/flume/ChannelSelector.java fba2dcb flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31 flume-ng-core/src/main/java/org/apache/flume/SinkProcessor.java d863ed0 flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java be1891b flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorFactory.java 800f471 flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorType.java 511fc65 flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java d8419e8 flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java 963a6a3 flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java PRE-CREATION flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5 flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkFactory.java b89dfa0 flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkProcessor.java 257bab3 flume-ng-core/src/main/java/org/apache/flume/sink/SinkGroup.java 0dffd69 flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java 6160a17 flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 6b08c09 flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java a610e6f flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java cd8991e flume-ng-dist/pom.xml 642e681 flume-ng-dist/src/main/assembly/dist.xml 7e401ae flume-ng-dist/src/main/assembly/src.xml bd4f090 flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1 flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 1f0e8c6 pom.xml 3a9bc42 Diff: https://reviews.apache.org/r/4502/diff Testing ------- Functional testing done. Thanks, Hari
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-04-18 03:11:55, Juhani Connolly wrote:

        > I finally had time to go through this huge patch. Great work!

        > In general it looks good, with a small number of minor niggles. Hopefully we can get this in before more major changes take place on the trunk.

        > One other issue I have is that there is a lot of non-DRY code that looks like editted copy-paste. It may be a bit much to fix now, but hopefully in the future it can be refactored.

        Thanks Juhani! Actually there are a bunch of files which were simply moved, not changed, but review board and git see them as new files added and old ones deleted. Also files like FlumeConfiguration, which was already huge was quite a lot refactored and some functions were rewritten. If you can give me some examples of the non-dry code you were talking about, I will take a look at it (over email is better - you can send it to the flume dev list, because reviewboard tends to create a lot of noise, here and on the dev list).

        On 2012-04-18 03:11:55, Juhani Connolly wrote:

        > flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java, line 50

        > <https://reviews.apache.org/r/4502/diff/4/?file=101742#file101742line50>

        >

        > s/PropertiesFileConfgurationProvider/PropertiesFileConfigurationProvider/

        will fix it.

        On 2012-04-18 03:11:55, Juhani Connolly wrote:

        > flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java, line 133

        > <https://reviews.apache.org/r/4502/diff/4/?file=101742#file101742line133>

        >

        > s/configuation/configuration/

        will fix.

        On 2012-04-18 03:11:55, Juhani Connolly wrote:

        > flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java, line 408

        > <https://reviews.apache.org/r/4502/diff/4/?file=101742#file101742line408>

        >

        > do you think you could rename this to channelName for code clarity? Same thing for the validateSource/Sinks

        ok. will do that.

        On 2012-04-18 03:11:55, Juhani Connolly wrote:

        > flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java, line 480

        > <https://reviews.apache.org/r/4502/diff/4/?file=101742#file101742line480>

        >

        > ChannelType->SourceType

        ah copy-paste issue.

        On 2012-04-18 03:11:55, Juhani Connolly wrote:

        > flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java, line 574

        > <https://reviews.apache.org/r/4502/diff/4/?file=101742#file101742line574>

        >

        > ChannelType-> SinkType

        same as above. will fix both

        On 2012-04-18 03:11:55, Juhani Connolly wrote:

        > flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java, lines 665-683

        > <https://reviews.apache.org/r/4502/diff/4/?file=101742#file101742line665>

        >

        > I don't think this doc applies for the validateGroups as there is only one type of group configuration and it is handled here

        yes. true.

        On 2012-04-18 03:11:55, Juhani Connolly wrote:

        > flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java, line 41

        > <https://reviews.apache.org/r/4502/diff/4/?file=101748#file101748line41>

        >

        > I believe you'll need to add in the new channels here

        Yes, I need to add recoverable memory channel. Do you have a preference for a nickname?

        • Hari

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4502/#review6970
        -----------------------------------------------------------

        On 2012-04-13 21:52:25, Hari Shreedharan wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4502/

        -----------------------------------------------------------

        (Updated 2012-04-13 21:52:25)

        Review request for Flume.

        Summary

        -------

        Main config component.

        This addresses bug FLUME-1052.

        https://issues.apache.org/jira/browse/FLUME-1052

        Diffs

        -----

        flume-ng-configuration/pom.xml PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/Context.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorType.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkGroupConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorType.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java PRE-CREATION

        flume-ng-core/pom.xml 37fb112

        flume-ng-core/src/main/java/org/apache/flume/ChannelSelector.java fba2dcb

        flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31

        flume-ng-core/src/main/java/org/apache/flume/SinkProcessor.java d863ed0

        flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java be1891b

        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorFactory.java 800f471

        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorType.java 511fc65

        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java d8419e8

        flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java 963a6a3

        flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java PRE-CREATION

        flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5

        flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkFactory.java b89dfa0

        flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkProcessor.java 257bab3

        flume-ng-core/src/main/java/org/apache/flume/sink/SinkGroup.java 0dffd69

        flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java 6160a17

        flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 6b08c09

        flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java a610e6f

        flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java cd8991e

        flume-ng-dist/pom.xml 642e681

        flume-ng-dist/src/main/assembly/dist.xml 7e401ae

        flume-ng-dist/src/main/assembly/src.xml bd4f090

        flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1

        flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 1f0e8c6

        pom.xml 3a9bc42

        Diff: https://reviews.apache.org/r/4502/diff

        Testing

        -------

        Functional testing done.

        Thanks,

        Hari

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-04-18 03:11:55, Juhani Connolly wrote: > I finally had time to go through this huge patch. Great work! > In general it looks good, with a small number of minor niggles. Hopefully we can get this in before more major changes take place on the trunk. > One other issue I have is that there is a lot of non-DRY code that looks like editted copy-paste. It may be a bit much to fix now, but hopefully in the future it can be refactored. Thanks Juhani! Actually there are a bunch of files which were simply moved, not changed, but review board and git see them as new files added and old ones deleted. Also files like FlumeConfiguration, which was already huge was quite a lot refactored and some functions were rewritten. If you can give me some examples of the non-dry code you were talking about, I will take a look at it (over email is better - you can send it to the flume dev list, because reviewboard tends to create a lot of noise, here and on the dev list). On 2012-04-18 03:11:55, Juhani Connolly wrote: > flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java, line 50 > < https://reviews.apache.org/r/4502/diff/4/?file=101742#file101742line50 > > > s/PropertiesFileConfgurationProvider/PropertiesFileConfigurationProvider/ will fix it. On 2012-04-18 03:11:55, Juhani Connolly wrote: > flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java, line 133 > < https://reviews.apache.org/r/4502/diff/4/?file=101742#file101742line133 > > > s/configuation/configuration/ will fix. On 2012-04-18 03:11:55, Juhani Connolly wrote: > flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java, line 408 > < https://reviews.apache.org/r/4502/diff/4/?file=101742#file101742line408 > > > do you think you could rename this to channelName for code clarity? Same thing for the validateSource/Sinks ok. will do that. On 2012-04-18 03:11:55, Juhani Connolly wrote: > flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java, line 480 > < https://reviews.apache.org/r/4502/diff/4/?file=101742#file101742line480 > > > ChannelType->SourceType ah copy-paste issue. On 2012-04-18 03:11:55, Juhani Connolly wrote: > flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java, line 574 > < https://reviews.apache.org/r/4502/diff/4/?file=101742#file101742line574 > > > ChannelType-> SinkType same as above. will fix both On 2012-04-18 03:11:55, Juhani Connolly wrote: > flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java, lines 665-683 > < https://reviews.apache.org/r/4502/diff/4/?file=101742#file101742line665 > > > I don't think this doc applies for the validateGroups as there is only one type of group configuration and it is handled here yes. true. On 2012-04-18 03:11:55, Juhani Connolly wrote: > flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java, line 41 > < https://reviews.apache.org/r/4502/diff/4/?file=101748#file101748line41 > > > I believe you'll need to add in the new channels here Yes, I need to add recoverable memory channel. Do you have a preference for a nickname? Hari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4502/#review6970 ----------------------------------------------------------- On 2012-04-13 21:52:25, Hari Shreedharan wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4502/ ----------------------------------------------------------- (Updated 2012-04-13 21:52:25) Review request for Flume. Summary ------- Main config component. This addresses bug FLUME-1052 . https://issues.apache.org/jira/browse/FLUME-1052 Diffs ----- flume-ng-configuration/pom.xml PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/Context.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkGroupConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java PRE-CREATION flume-ng-core/pom.xml 37fb112 flume-ng-core/src/main/java/org/apache/flume/ChannelSelector.java fba2dcb flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31 flume-ng-core/src/main/java/org/apache/flume/SinkProcessor.java d863ed0 flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java be1891b flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorFactory.java 800f471 flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorType.java 511fc65 flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java d8419e8 flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java 963a6a3 flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java PRE-CREATION flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5 flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkFactory.java b89dfa0 flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkProcessor.java 257bab3 flume-ng-core/src/main/java/org/apache/flume/sink/SinkGroup.java 0dffd69 flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java 6160a17 flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 6b08c09 flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java a610e6f flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java cd8991e flume-ng-dist/pom.xml 642e681 flume-ng-dist/src/main/assembly/dist.xml 7e401ae flume-ng-dist/src/main/assembly/src.xml bd4f090 flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1 flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 1f0e8c6 pom.xml 3a9bc42 Diff: https://reviews.apache.org/r/4502/diff Testing ------- Functional testing done. Thanks, Hari
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4502/
        -----------------------------------------------------------

        (Updated 2012-04-19 01:23:41.296962)

        Review request for Flume.

        Changes
        -------

        Incorporated Juhani's feedback. For some reason, git seems to have reordered the files in the diff, sorry about that.

        Summary
        -------

        Main config component.

        This addresses bug FLUME-1052.
        https://issues.apache.org/jira/browse/FLUME-1052

        Diffs (updated)


        flume-ng-core/pom.xml b9f1e12
        flume-ng-core/src/main/java/org/apache/flume/ChannelSelector.java fba2dcb
        flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31
        flume-ng-core/src/main/java/org/apache/flume/SinkProcessor.java d863ed0
        flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java be1891b
        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorFactory.java 800f471
        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorType.java 511fc65
        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java d8419e8
        flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java 963a6a3
        flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5
        flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkFactory.java b89dfa0
        flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkProcessor.java 257bab3
        flume-ng-core/src/main/java/org/apache/flume/sink/SinkGroup.java 0dffd69
        flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java 6160a17
        flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 6b08c09
        flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java a610e6f
        flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java cd8991e
        flume-ng-dist/pom.xml 642e681
        flume-ng-dist/src/main/assembly/dist.xml 917ac02
        flume-ng-dist/src/main/assembly/src.xml 3b24b39
        flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1
        flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 1f0e8c6
        pom.xml ed8092d

        Diff: https://reviews.apache.org/r/4502/diff

        Testing
        -------

        Functional testing done.

        Thanks,

        Hari

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4502/ ----------------------------------------------------------- (Updated 2012-04-19 01:23:41.296962) Review request for Flume. Changes ------- Incorporated Juhani's feedback. For some reason, git seems to have reordered the files in the diff, sorry about that. Summary ------- Main config component. This addresses bug FLUME-1052 . https://issues.apache.org/jira/browse/FLUME-1052 Diffs (updated) flume-ng-core/pom.xml b9f1e12 flume-ng-core/src/main/java/org/apache/flume/ChannelSelector.java fba2dcb flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31 flume-ng-core/src/main/java/org/apache/flume/SinkProcessor.java d863ed0 flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java be1891b flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorFactory.java 800f471 flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorType.java 511fc65 flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java d8419e8 flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java 963a6a3 flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5 flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkFactory.java b89dfa0 flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkProcessor.java 257bab3 flume-ng-core/src/main/java/org/apache/flume/sink/SinkGroup.java 0dffd69 flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java 6160a17 flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 6b08c09 flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java a610e6f flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java cd8991e flume-ng-dist/pom.xml 642e681 flume-ng-dist/src/main/assembly/dist.xml 917ac02 flume-ng-dist/src/main/assembly/src.xml 3b24b39 flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1 flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 1f0e8c6 pom.xml ed8092d Diff: https://reviews.apache.org/r/4502/diff Testing ------- Functional testing done. Thanks, Hari
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4502/
        -----------------------------------------------------------

        (Updated 2012-04-19 01:33:31.872414)

        Review request for Flume.

        Changes
        -------

        Incorporated Juhani's feedback. Last diff missed the new files.

        Summary
        -------

        Main config component.

        This addresses bug FLUME-1052.
        https://issues.apache.org/jira/browse/FLUME-1052

        Diffs (updated)


        flume-ng-configuration/pom.xml PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/Context.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorType.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkGroupConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorType.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java PRE-CREATION
        flume-ng-core/pom.xml b9f1e12
        flume-ng-core/src/main/java/org/apache/flume/ChannelSelector.java fba2dcb
        flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31
        flume-ng-core/src/main/java/org/apache/flume/SinkProcessor.java d863ed0
        flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java be1891b
        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorFactory.java 800f471
        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorType.java 511fc65
        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java d8419e8
        flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java 963a6a3
        flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java PRE-CREATION
        flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5
        flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkFactory.java b89dfa0
        flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkProcessor.java 257bab3
        flume-ng-core/src/main/java/org/apache/flume/sink/SinkGroup.java 0dffd69
        flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java 6160a17
        flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 6b08c09
        flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java a610e6f
        flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java cd8991e
        flume-ng-dist/pom.xml 642e681
        flume-ng-dist/src/main/assembly/dist.xml 917ac02
        flume-ng-dist/src/main/assembly/src.xml 3b24b39
        flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1
        flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 1f0e8c6
        pom.xml ed8092d

        Diff: https://reviews.apache.org/r/4502/diff

        Testing
        -------

        Functional testing done.

        Thanks,

        Hari

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4502/ ----------------------------------------------------------- (Updated 2012-04-19 01:33:31.872414) Review request for Flume. Changes ------- Incorporated Juhani's feedback. Last diff missed the new files. Summary ------- Main config component. This addresses bug FLUME-1052 . https://issues.apache.org/jira/browse/FLUME-1052 Diffs (updated) flume-ng-configuration/pom.xml PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/Context.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkGroupConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java PRE-CREATION flume-ng-core/pom.xml b9f1e12 flume-ng-core/src/main/java/org/apache/flume/ChannelSelector.java fba2dcb flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31 flume-ng-core/src/main/java/org/apache/flume/SinkProcessor.java d863ed0 flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java be1891b flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorFactory.java 800f471 flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorType.java 511fc65 flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java d8419e8 flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java 963a6a3 flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java PRE-CREATION flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5 flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkFactory.java b89dfa0 flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkProcessor.java 257bab3 flume-ng-core/src/main/java/org/apache/flume/sink/SinkGroup.java 0dffd69 flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java 6160a17 flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 6b08c09 flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java a610e6f flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java cd8991e flume-ng-dist/pom.xml 642e681 flume-ng-dist/src/main/assembly/dist.xml 917ac02 flume-ng-dist/src/main/assembly/src.xml 3b24b39 flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1 flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 1f0e8c6 pom.xml ed8092d Diff: https://reviews.apache.org/r/4502/diff Testing ------- Functional testing done. Thanks, Hari
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4502/#review7018
        -----------------------------------------------------------

        Looks good to me except for some changes from another patch look like they've slipped in
        Once that's fixed if you can attach the patch to the jira it should be good to go

        pom.xml
        <https://reviews.apache.org/r/4502/#comment15590>

        These changes don't look like they belong here... Maybe your patch was based against the wrong version?

        • Juhani

        On 2012-04-19 01:33:31, Hari Shreedharan wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4502/

        -----------------------------------------------------------

        (Updated 2012-04-19 01:33:31)

        Review request for Flume.

        Summary

        -------

        Main config component.

        This addresses bug FLUME-1052.

        https://issues.apache.org/jira/browse/FLUME-1052

        Diffs

        -----

        flume-ng-configuration/pom.xml PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/Context.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorType.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkGroupConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorType.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java PRE-CREATION

        flume-ng-core/pom.xml b9f1e12

        flume-ng-core/src/main/java/org/apache/flume/ChannelSelector.java fba2dcb

        flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31

        flume-ng-core/src/main/java/org/apache/flume/SinkProcessor.java d863ed0

        flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java be1891b

        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorFactory.java 800f471

        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorType.java 511fc65

        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java d8419e8

        flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java 963a6a3

        flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java PRE-CREATION

        flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5

        flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkFactory.java b89dfa0

        flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkProcessor.java 257bab3

        flume-ng-core/src/main/java/org/apache/flume/sink/SinkGroup.java 0dffd69

        flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java 6160a17

        flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 6b08c09

        flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java a610e6f

        flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java cd8991e

        flume-ng-dist/pom.xml 642e681

        flume-ng-dist/src/main/assembly/dist.xml 917ac02

        flume-ng-dist/src/main/assembly/src.xml 3b24b39

        flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1

        flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 1f0e8c6

        pom.xml ed8092d

        Diff: https://reviews.apache.org/r/4502/diff

        Testing

        -------

        Functional testing done.

        Thanks,

        Hari

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4502/#review7018 ----------------------------------------------------------- Looks good to me except for some changes from another patch look like they've slipped in Once that's fixed if you can attach the patch to the jira it should be good to go pom.xml < https://reviews.apache.org/r/4502/#comment15590 > These changes don't look like they belong here... Maybe your patch was based against the wrong version? Juhani On 2012-04-19 01:33:31, Hari Shreedharan wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4502/ ----------------------------------------------------------- (Updated 2012-04-19 01:33:31) Review request for Flume. Summary ------- Main config component. This addresses bug FLUME-1052 . https://issues.apache.org/jira/browse/FLUME-1052 Diffs ----- flume-ng-configuration/pom.xml PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/Context.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkGroupConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java PRE-CREATION flume-ng-core/pom.xml b9f1e12 flume-ng-core/src/main/java/org/apache/flume/ChannelSelector.java fba2dcb flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31 flume-ng-core/src/main/java/org/apache/flume/SinkProcessor.java d863ed0 flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java be1891b flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorFactory.java 800f471 flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorType.java 511fc65 flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java d8419e8 flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java 963a6a3 flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java PRE-CREATION flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5 flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkFactory.java b89dfa0 flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkProcessor.java 257bab3 flume-ng-core/src/main/java/org/apache/flume/sink/SinkGroup.java 0dffd69 flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java 6160a17 flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 6b08c09 flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java a610e6f flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java cd8991e flume-ng-dist/pom.xml 642e681 flume-ng-dist/src/main/assembly/dist.xml 917ac02 flume-ng-dist/src/main/assembly/src.xml 3b24b39 flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1 flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 1f0e8c6 pom.xml ed8092d Diff: https://reviews.apache.org/r/4502/diff Testing ------- Functional testing done. Thanks, Hari
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-04-19 07:02:57, Juhani Connolly wrote:

        > pom.xml, line 41

        > <https://reviews.apache.org/r/4502/diff/4-6/?file=101779#file101779line41>

        >

        > These changes don't look like they belong here... Maybe your patch was based against the wrong version?

        Hi Juhani,

        Thanks for the feedback. This appears in the diff because I rebased the patch on trunk (sorry, I may have forgotten to mention this). Please see : https://github.com/apache/flume/blob/trunk/pom.xml(lines 41 to 46). Thats the reason you see it as added when you diff between patch versions 4 and 6. This patch should be applied to trunk.

        • Hari

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4502/#review7018
        -----------------------------------------------------------

        On 2012-04-19 01:33:31, Hari Shreedharan wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4502/

        -----------------------------------------------------------

        (Updated 2012-04-19 01:33:31)

        Review request for Flume.

        Summary

        -------

        Main config component.

        This addresses bug FLUME-1052.

        https://issues.apache.org/jira/browse/FLUME-1052

        Diffs

        -----

        flume-ng-configuration/pom.xml PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/Context.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorType.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkGroupConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorType.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java PRE-CREATION

        flume-ng-core/pom.xml b9f1e12

        flume-ng-core/src/main/java/org/apache/flume/ChannelSelector.java fba2dcb

        flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31

        flume-ng-core/src/main/java/org/apache/flume/SinkProcessor.java d863ed0

        flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java be1891b

        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorFactory.java 800f471

        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorType.java 511fc65

        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java d8419e8

        flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java 963a6a3

        flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java PRE-CREATION

        flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5

        flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkFactory.java b89dfa0

        flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkProcessor.java 257bab3

        flume-ng-core/src/main/java/org/apache/flume/sink/SinkGroup.java 0dffd69

        flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java 6160a17

        flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 6b08c09

        flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java a610e6f

        flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java cd8991e

        flume-ng-dist/pom.xml 642e681

        flume-ng-dist/src/main/assembly/dist.xml 917ac02

        flume-ng-dist/src/main/assembly/src.xml 3b24b39

        flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1

        flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 1f0e8c6

        pom.xml ed8092d

        Diff: https://reviews.apache.org/r/4502/diff

        Testing

        -------

        Functional testing done.

        Thanks,

        Hari

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-04-19 07:02:57, Juhani Connolly wrote: > pom.xml, line 41 > < https://reviews.apache.org/r/4502/diff/4-6/?file=101779#file101779line41 > > > These changes don't look like they belong here... Maybe your patch was based against the wrong version? Hi Juhani, Thanks for the feedback. This appears in the diff because I rebased the patch on trunk (sorry, I may have forgotten to mention this). Please see : https://github.com/apache/flume/blob/trunk/pom.xml(lines 41 to 46). Thats the reason you see it as added when you diff between patch versions 4 and 6. This patch should be applied to trunk. Hari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4502/#review7018 ----------------------------------------------------------- On 2012-04-19 01:33:31, Hari Shreedharan wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4502/ ----------------------------------------------------------- (Updated 2012-04-19 01:33:31) Review request for Flume. Summary ------- Main config component. This addresses bug FLUME-1052 . https://issues.apache.org/jira/browse/FLUME-1052 Diffs ----- flume-ng-configuration/pom.xml PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/Context.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkGroupConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java PRE-CREATION flume-ng-core/pom.xml b9f1e12 flume-ng-core/src/main/java/org/apache/flume/ChannelSelector.java fba2dcb flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31 flume-ng-core/src/main/java/org/apache/flume/SinkProcessor.java d863ed0 flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java be1891b flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorFactory.java 800f471 flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorType.java 511fc65 flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java d8419e8 flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java 963a6a3 flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java PRE-CREATION flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5 flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkFactory.java b89dfa0 flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkProcessor.java 257bab3 flume-ng-core/src/main/java/org/apache/flume/sink/SinkGroup.java 0dffd69 flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java 6160a17 flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 6b08c09 flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java a610e6f flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java cd8991e flume-ng-dist/pom.xml 642e681 flume-ng-dist/src/main/assembly/dist.xml 917ac02 flume-ng-dist/src/main/assembly/src.xml 3b24b39 flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1 flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 1f0e8c6 pom.xml ed8092d Diff: https://reviews.apache.org/r/4502/diff Testing ------- Functional testing done. Thanks, Hari
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4502/
        -----------------------------------------------------------

        (Updated 2012-04-19 17:20:28.083324)

        Review request for Flume.

        Changes
        -------

        Adding recoverable memory channel to ChannelConfiguration too.

        Summary
        -------

        Main config component.

        This addresses bug FLUME-1052.
        https://issues.apache.org/jira/browse/FLUME-1052

        Diffs (updated)


        flume-ng-configuration/pom.xml PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/Context.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorType.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkGroupConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorType.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java PRE-CREATION
        flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java PRE-CREATION
        flume-ng-core/pom.xml b9f1e12
        flume-ng-core/src/main/java/org/apache/flume/ChannelSelector.java fba2dcb
        flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31
        flume-ng-core/src/main/java/org/apache/flume/SinkProcessor.java d863ed0
        flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java be1891b
        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorFactory.java 800f471
        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorType.java 511fc65
        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java d8419e8
        flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java 963a6a3
        flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java PRE-CREATION
        flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5
        flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkFactory.java b89dfa0
        flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkProcessor.java 257bab3
        flume-ng-core/src/main/java/org/apache/flume/sink/SinkGroup.java 0dffd69
        flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java 6160a17
        flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 6b08c09
        flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java a610e6f
        flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java cd8991e
        flume-ng-dist/pom.xml 642e681
        flume-ng-dist/src/main/assembly/dist.xml 917ac02
        flume-ng-dist/src/main/assembly/src.xml 3b24b39
        flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1
        flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 1f0e8c6
        pom.xml ed8092d

        Diff: https://reviews.apache.org/r/4502/diff

        Testing
        -------

        Functional testing done.

        Thanks,

        Hari

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4502/ ----------------------------------------------------------- (Updated 2012-04-19 17:20:28.083324) Review request for Flume. Changes ------- Adding recoverable memory channel to ChannelConfiguration too. Summary ------- Main config component. This addresses bug FLUME-1052 . https://issues.apache.org/jira/browse/FLUME-1052 Diffs (updated) flume-ng-configuration/pom.xml PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/Context.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkGroupConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java PRE-CREATION flume-ng-core/pom.xml b9f1e12 flume-ng-core/src/main/java/org/apache/flume/ChannelSelector.java fba2dcb flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31 flume-ng-core/src/main/java/org/apache/flume/SinkProcessor.java d863ed0 flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java be1891b flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorFactory.java 800f471 flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorType.java 511fc65 flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java d8419e8 flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java 963a6a3 flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java PRE-CREATION flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5 flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkFactory.java b89dfa0 flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkProcessor.java 257bab3 flume-ng-core/src/main/java/org/apache/flume/sink/SinkGroup.java 0dffd69 flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java 6160a17 flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 6b08c09 flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java a610e6f flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java cd8991e flume-ng-dist/pom.xml 642e681 flume-ng-dist/src/main/assembly/dist.xml 917ac02 flume-ng-dist/src/main/assembly/src.xml 3b24b39 flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1 flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 1f0e8c6 pom.xml ed8092d Diff: https://reviews.apache.org/r/4502/diff Testing ------- Functional testing done. Thanks, Hari
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4502/#review7121
        -----------------------------------------------------------

        Ship it!

        +1

        Looks good to me too. Please attach the patch to the Jira.

        • Arvind

        On 2012-04-19 17:20:28, Hari Shreedharan wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4502/

        -----------------------------------------------------------

        (Updated 2012-04-19 17:20:28)

        Review request for Flume.

        Summary

        -------

        Main config component.

        This addresses bug FLUME-1052.

        https://issues.apache.org/jira/browse/FLUME-1052

        Diffs

        -----

        flume-ng-configuration/pom.xml PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/Context.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorType.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkGroupConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorType.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java PRE-CREATION

        flume-ng-core/pom.xml b9f1e12

        flume-ng-core/src/main/java/org/apache/flume/ChannelSelector.java fba2dcb

        flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31

        flume-ng-core/src/main/java/org/apache/flume/SinkProcessor.java d863ed0

        flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java be1891b

        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorFactory.java 800f471

        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorType.java 511fc65

        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java d8419e8

        flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java 963a6a3

        flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java PRE-CREATION

        flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5

        flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkFactory.java b89dfa0

        flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkProcessor.java 257bab3

        flume-ng-core/src/main/java/org/apache/flume/sink/SinkGroup.java 0dffd69

        flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java 6160a17

        flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 6b08c09

        flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java a610e6f

        flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java cd8991e

        flume-ng-dist/pom.xml 642e681

        flume-ng-dist/src/main/assembly/dist.xml 917ac02

        flume-ng-dist/src/main/assembly/src.xml 3b24b39

        flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1

        flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 1f0e8c6

        pom.xml ed8092d

        Diff: https://reviews.apache.org/r/4502/diff

        Testing

        -------

        Functional testing done.

        Thanks,

        Hari

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4502/#review7121 ----------------------------------------------------------- Ship it! +1 Looks good to me too. Please attach the patch to the Jira. Arvind On 2012-04-19 17:20:28, Hari Shreedharan wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4502/ ----------------------------------------------------------- (Updated 2012-04-19 17:20:28) Review request for Flume. Summary ------- Main config component. This addresses bug FLUME-1052 . https://issues.apache.org/jira/browse/FLUME-1052 Diffs ----- flume-ng-configuration/pom.xml PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/Context.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkGroupConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java PRE-CREATION flume-ng-core/pom.xml b9f1e12 flume-ng-core/src/main/java/org/apache/flume/ChannelSelector.java fba2dcb flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31 flume-ng-core/src/main/java/org/apache/flume/SinkProcessor.java d863ed0 flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java be1891b flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorFactory.java 800f471 flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorType.java 511fc65 flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java d8419e8 flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java 963a6a3 flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java PRE-CREATION flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5 flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkFactory.java b89dfa0 flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkProcessor.java 257bab3 flume-ng-core/src/main/java/org/apache/flume/sink/SinkGroup.java 0dffd69 flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java 6160a17 flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 6b08c09 flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java a610e6f flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java cd8991e flume-ng-dist/pom.xml 642e681 flume-ng-dist/src/main/assembly/dist.xml 917ac02 flume-ng-dist/src/main/assembly/src.xml 3b24b39 flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1 flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 1f0e8c6 pom.xml ed8092d Diff: https://reviews.apache.org/r/4502/diff Testing ------- Functional testing done. Thanks, Hari
        Hari Shreedharan made changes -
        Attachment FLUME-1052-2.patch [ 12523733 ]
        Hari Shreedharan made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-04-19 07:02:57, Juhani Connolly wrote:

        > pom.xml, line 41

        > <https://reviews.apache.org/r/4502/diff/4-6/?file=101779#file101779line41>

        >

        > These changes don't look like they belong here... Maybe your patch was based against the wrong version?

        Hari Shreedharan wrote:

        Hi Juhani,

        Thanks for the feedback. This appears in the diff because I rebased the patch on trunk (sorry, I may have forgotten to mention this). Please see : https://github.com/apache/flume/blob/trunk/pom.xml(lines 41 to 46). Thats the reason you see it as added when you diff between patch versions 4 and 6. This patch should be applied to trunk.

        right, my bad!

        Everything looks good to me with the addition of the other memory channel. I'll check over individual components as soon as this is committed

        • Juhani

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4502/#review7018
        -----------------------------------------------------------

        On 2012-04-19 17:20:28, Hari Shreedharan wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4502/

        -----------------------------------------------------------

        (Updated 2012-04-19 17:20:28)

        Review request for Flume.

        Summary

        -------

        Main config component.

        This addresses bug FLUME-1052.

        https://issues.apache.org/jira/browse/FLUME-1052

        Diffs

        -----

        flume-ng-configuration/pom.xml PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/Context.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorType.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkGroupConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorType.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java PRE-CREATION

        flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java PRE-CREATION

        flume-ng-core/pom.xml b9f1e12

        flume-ng-core/src/main/java/org/apache/flume/ChannelSelector.java fba2dcb

        flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31

        flume-ng-core/src/main/java/org/apache/flume/SinkProcessor.java d863ed0

        flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java be1891b

        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorFactory.java 800f471

        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorType.java 511fc65

        flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java d8419e8

        flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java 963a6a3

        flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java PRE-CREATION

        flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5

        flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkFactory.java b89dfa0

        flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkProcessor.java 257bab3

        flume-ng-core/src/main/java/org/apache/flume/sink/SinkGroup.java 0dffd69

        flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java 6160a17

        flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 6b08c09

        flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java a610e6f

        flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java cd8991e

        flume-ng-dist/pom.xml 642e681

        flume-ng-dist/src/main/assembly/dist.xml 917ac02

        flume-ng-dist/src/main/assembly/src.xml 3b24b39

        flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1

        flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 1f0e8c6

        pom.xml ed8092d

        Diff: https://reviews.apache.org/r/4502/diff

        Testing

        -------

        Functional testing done.

        Thanks,

        Hari

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-04-19 07:02:57, Juhani Connolly wrote: > pom.xml, line 41 > < https://reviews.apache.org/r/4502/diff/4-6/?file=101779#file101779line41 > > > These changes don't look like they belong here... Maybe your patch was based against the wrong version? Hari Shreedharan wrote: Hi Juhani, Thanks for the feedback. This appears in the diff because I rebased the patch on trunk (sorry, I may have forgotten to mention this). Please see : https://github.com/apache/flume/blob/trunk/pom.xml(lines 41 to 46). Thats the reason you see it as added when you diff between patch versions 4 and 6. This patch should be applied to trunk. right, my bad! Everything looks good to me with the addition of the other memory channel. I'll check over individual components as soon as this is committed Juhani ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4502/#review7018 ----------------------------------------------------------- On 2012-04-19 17:20:28, Hari Shreedharan wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4502/ ----------------------------------------------------------- (Updated 2012-04-19 17:20:28) Review request for Flume. Summary ------- Main config component. This addresses bug FLUME-1052 . https://issues.apache.org/jira/browse/FLUME-1052 Diffs ----- flume-ng-configuration/pom.xml PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/Context.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkGroupConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java PRE-CREATION flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java PRE-CREATION flume-ng-core/pom.xml b9f1e12 flume-ng-core/src/main/java/org/apache/flume/ChannelSelector.java fba2dcb flume-ng-core/src/main/java/org/apache/flume/Context.java 5294e31 flume-ng-core/src/main/java/org/apache/flume/SinkProcessor.java d863ed0 flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java be1891b flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorFactory.java 800f471 flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorType.java 511fc65 flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java d8419e8 flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java 963a6a3 flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java PRE-CREATION flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java 84492e5 flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkFactory.java b89dfa0 flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkProcessor.java 257bab3 flume-ng-core/src/main/java/org/apache/flume/sink/SinkGroup.java 0dffd69 flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java 6160a17 flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java 6b08c09 flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java a610e6f flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java cd8991e flume-ng-dist/pom.xml 642e681 flume-ng-dist/src/main/assembly/dist.xml 917ac02 flume-ng-dist/src/main/assembly/src.xml 3b24b39 flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java d66f6d1 flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 1f0e8c6 pom.xml ed8092d Diff: https://reviews.apache.org/r/4502/diff Testing ------- Functional testing done. Thanks, Hari
        Hide
        Arvind Prabhakar added a comment -

        Patch committed. Thanks Hari!

        Show
        Arvind Prabhakar added a comment - Patch committed. Thanks Hari!
        Arvind Prabhakar made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in flume-trunk #179 (See https://builds.apache.org/job/flume-trunk/179/)
        FLUME-1052. Main configuration component as separate module.

        (Hari Shreedharan via Arvind Prabhakar) (Revision 1329280)

        Result = SUCCESS
        arvind : http://svn.apache.org/viewvc/?view=rev&rev=1329280
        Files :

        • /incubator/flume/trunk/flume-ng-configuration
        • /incubator/flume/trunk/flume-ng-configuration/pom.xml
        • /incubator/flume/trunk/flume-ng-configuration/src
        • /incubator/flume/trunk/flume-ng-configuration/src/main
        • /incubator/flume/trunk/flume-ng-configuration/src/main/java
        • /incubator/flume/trunk/flume-ng-configuration/src/main/java/org
        • /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache
        • /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume
        • /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/Context.java
        • /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf
        • /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java
        • /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java
        • /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java
        • /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java
        • /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java
        • /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java
        • /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/channel
        • /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java
        • /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorConfiguration.java
        • /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorType.java
        • /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java
        • /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/sink
        • /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java
        • /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkGroupConfiguration.java
        • /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorConfiguration.java
        • /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorType.java
        • /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java
        • /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/source
        • /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java
        • /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java
        • /incubator/flume/trunk/flume-ng-core/pom.xml
        • /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/ChannelSelector.java
        • /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/Context.java
        • /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/SinkProcessor.java
        • /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java
        • /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorFactory.java
        • /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorType.java
        • /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java
        • /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java
        • /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java
        • /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java
        • /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkFactory.java
        • /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkProcessor.java
        • /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/sink/SinkGroup.java
        • /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java
        • /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java
        • /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java
        • /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java
        • /incubator/flume/trunk/flume-ng-dist/pom.xml
        • /incubator/flume/trunk/flume-ng-dist/src/main/assembly/dist.xml
        • /incubator/flume/trunk/flume-ng-dist/src/main/assembly/src.xml
        • /incubator/flume/trunk/flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java
        • /incubator/flume/trunk/flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java
        • /incubator/flume/trunk/pom.xml
        Show
        Hudson added a comment - Integrated in flume-trunk #179 (See https://builds.apache.org/job/flume-trunk/179/ ) FLUME-1052 . Main configuration component as separate module. (Hari Shreedharan via Arvind Prabhakar) (Revision 1329280) Result = SUCCESS arvind : http://svn.apache.org/viewvc/?view=rev&rev=1329280 Files : /incubator/flume/trunk/flume-ng-configuration /incubator/flume/trunk/flume-ng-configuration/pom.xml /incubator/flume/trunk/flume-ng-configuration/src /incubator/flume/trunk/flume-ng-configuration/src/main /incubator/flume/trunk/flume-ng-configuration/src/main/java /incubator/flume/trunk/flume-ng-configuration/src/main/java/org /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/Context.java /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfiguration.java /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/ComponentConfigurationFactory.java /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/ConfigurationException.java /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfiguration.java /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationError.java /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/FlumeConfigurationErrorType.java /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/channel /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelConfiguration.java /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorConfiguration.java /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelSelectorType.java /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/channel/ChannelType.java /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/sink /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkGroupConfiguration.java /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorConfiguration.java /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkProcessorType.java /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/source /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java /incubator/flume/trunk/flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java /incubator/flume/trunk/flume-ng-core/pom.xml /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/ChannelSelector.java /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/Context.java /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/SinkProcessor.java /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/SinkProcessorType.java /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorFactory.java /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/channel/ChannelSelectorType.java /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/channel/ChannelType.java /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/channel/DefaultChannelFactory.java /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/conf/ConfigurableComponent.java /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/conf/Configurables.java /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkFactory.java /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/sink/DefaultSinkProcessor.java /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/sink/SinkGroup.java /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/sink/SinkProcessorFactory.java /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/sink/SinkType.java /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/source/DefaultSourceFactory.java /incubator/flume/trunk/flume-ng-core/src/main/java/org/apache/flume/source/SourceType.java /incubator/flume/trunk/flume-ng-dist/pom.xml /incubator/flume/trunk/flume-ng-dist/src/main/assembly/dist.xml /incubator/flume/trunk/flume-ng-dist/src/main/assembly/src.xml /incubator/flume/trunk/flume-ng-node/src/main/java/org/apache/flume/conf/properties/FlumeConfiguration.java /incubator/flume/trunk/flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java /incubator/flume/trunk/pom.xml

          People

          • Assignee:
            Hari Shreedharan
            Reporter:
            Hari Shreedharan
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development