Flume
  1. Flume
  2. FLUME-1048

speed up mvn package: stop building .zip packages

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: v1.2.0
    • Component/s: None
    • Labels:
      None

      Description

      We are targeting 'nix with Flume NG. Why are we building zip packages? It adds time to the edit/build/test cycle. Also, it's duplicate artifacts to verify if we wanted to include them in a release.

      I propose removing the zip archives and just keeping the tarballs.

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4459/
        -----------------------------------------------------------

        Review request for Flume.

        Summary
        -------

        Building these takes extra time and provides extra artifacts to verify. Let's speed up the edit/build/run cycle.

        This addresses bug FLUME-1048.
        https://issues.apache.org/jira/browse/FLUME-1048

        Diffs


        flume-ng-dist/src/main/assembly/dist.xml 40c450d
        flume-ng-dist/src/main/assembly/src.xml 5bfef59

        Diff: https://reviews.apache.org/r/4459/diff

        Testing
        -------

        mvn package -DskipTests is faster

        Thanks,

        Mike

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4459/ ----------------------------------------------------------- Review request for Flume. Summary ------- Building these takes extra time and provides extra artifacts to verify. Let's speed up the edit/build/run cycle. This addresses bug FLUME-1048 . https://issues.apache.org/jira/browse/FLUME-1048 Diffs flume-ng-dist/src/main/assembly/dist.xml 40c450d flume-ng-dist/src/main/assembly/src.xml 5bfef59 Diff: https://reviews.apache.org/r/4459/diff Testing ------- mvn package -DskipTests is faster Thanks, Mike
        Hide
        Andrew Bayer added a comment -

        +1. Redundancies are redundant. =)

        Show
        Andrew Bayer added a comment - +1. Redundancies are redundant. =)
        Hide
        Arvind Prabhakar added a comment -

        Patch committed. Thanks Mike!

        Show
        Arvind Prabhakar added a comment - Patch committed. Thanks Mike!
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4459/#review6305
        -----------------------------------------------------------

        Ship it!

        +1

        • Arvind

        On 2012-03-23 00:46:31, Mike Percy wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4459/

        -----------------------------------------------------------

        (Updated 2012-03-23 00:46:31)

        Review request for Flume.

        Summary

        -------

        Building these takes extra time and provides extra artifacts to verify. Let's speed up the edit/build/run cycle.

        This addresses bug FLUME-1048.

        https://issues.apache.org/jira/browse/FLUME-1048

        Diffs

        -----

        flume-ng-dist/src/main/assembly/dist.xml 40c450d

        flume-ng-dist/src/main/assembly/src.xml 5bfef59

        Diff: https://reviews.apache.org/r/4459/diff

        Testing

        -------

        mvn package -DskipTests is faster

        Thanks,

        Mike

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4459/#review6305 ----------------------------------------------------------- Ship it! +1 Arvind On 2012-03-23 00:46:31, Mike Percy wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4459/ ----------------------------------------------------------- (Updated 2012-03-23 00:46:31) Review request for Flume. Summary ------- Building these takes extra time and provides extra artifacts to verify. Let's speed up the edit/build/run cycle. This addresses bug FLUME-1048 . https://issues.apache.org/jira/browse/FLUME-1048 Diffs ----- flume-ng-dist/src/main/assembly/dist.xml 40c450d flume-ng-dist/src/main/assembly/src.xml 5bfef59 Diff: https://reviews.apache.org/r/4459/diff Testing ------- mvn package -DskipTests is faster Thanks, Mike
        Hide
        Hudson added a comment -

        Integrated in flume-trunk #142 (See https://builds.apache.org/job/flume-trunk/142/)
        FLUME-1048. Build speed up by removing redundant package.

        (Mike Percy via Arvind Prabhakar) (Revision 1304579)

        Result = SUCCESS
        arvind : http://svn.apache.org/viewvc/?view=rev&rev=1304579
        Files :

        • /incubator/flume/trunk/flume-ng-dist/src/main/assembly/dist.xml
        • /incubator/flume/trunk/flume-ng-dist/src/main/assembly/src.xml
        Show
        Hudson added a comment - Integrated in flume-trunk #142 (See https://builds.apache.org/job/flume-trunk/142/ ) FLUME-1048 . Build speed up by removing redundant package. (Mike Percy via Arvind Prabhakar) (Revision 1304579) Result = SUCCESS arvind : http://svn.apache.org/viewvc/?view=rev&rev=1304579 Files : /incubator/flume/trunk/flume-ng-dist/src/main/assembly/dist.xml /incubator/flume/trunk/flume-ng-dist/src/main/assembly/src.xml

          People

          • Assignee:
            Mike Percy
            Reporter:
            Mike Percy
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development