Flume
  1. Flume
  2. FLUME-1035

slf4j error in flume sdk unit tests

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: v1.1.0, v1.2.0
    • Fix Version/s: v1.2.0
    • Component/s: None
    • Labels:
      None

      Description

      There is a problem in the SDK unit tests with slf4j where the SDK does not include an implementation of SLF4J in the classpath while it uses JUL for logging.

      We should make it consistent by using SLF4J and also provide an implementation (Log4j) in the classpath for the SDK unit tests.

        Activity

        Hide
        Hudson added a comment -

        Integrated in flume-trunk #132 (See https://builds.apache.org/job/flume-trunk/132/)
        FLUME-1035: slf4j error in flume sdk unit tests

        (Mike Percy via Brock Noland) (Revision 1302638)

        Result = SUCCESS
        brock : http://svn.apache.org/viewvc/?view=rev&rev=1302638
        Files :

        • /incubator/flume/trunk/flume-ng-sdk/pom.xml
        • /incubator/flume/trunk/flume-ng-sdk/src/test/java/org/apache/flume/api/RpcTestUtils.java
        • /incubator/flume/trunk/flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java
        Show
        Hudson added a comment - Integrated in flume-trunk #132 (See https://builds.apache.org/job/flume-trunk/132/ ) FLUME-1035 : slf4j error in flume sdk unit tests (Mike Percy via Brock Noland) (Revision 1302638) Result = SUCCESS brock : http://svn.apache.org/viewvc/?view=rev&rev=1302638 Files : /incubator/flume/trunk/flume-ng-sdk/pom.xml /incubator/flume/trunk/flume-ng-sdk/src/test/java/org/apache/flume/api/RpcTestUtils.java /incubator/flume/trunk/flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java
        Hide
        Brock Noland added a comment -

        Committed in 1302638. Thank you Mike for your contribution!

        Show
        Brock Noland added a comment - Committed in 1302638. Thank you Mike for your contribution!
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-03-17 13:33:38, Brock Noland wrote:

        > Attach the patch to the JIRA and I will see if my commit privileges are working.

        Done. Thanks Brock!

        • Mike

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4392/#review6063
        -----------------------------------------------------------

        On 2012-03-17 02:03:05, Mike Percy wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4392/

        -----------------------------------------------------------

        (Updated 2012-03-17 02:03:05)

        Review request for Flume.

        Summary

        -------

        This patch fixes issues with unit test logging in the SDK.

        This addresses bug FLUME-1035.

        https://issues.apache.org/jira/browse/FLUME-1035

        Diffs

        -----

        flume-ng-sdk/src/test/resources/log4j.properties PRE-CREATION

        flume-ng-sdk/pom.xml d1c6adf

        flume-ng-sdk/src/test/java/org/apache/flume/api/RpcTestUtils.java 9497a3d

        flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java 8c40aa4

        Diff: https://reviews.apache.org/r/4392/diff

        Testing

        -------

        Thanks,

        Mike

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-03-17 13:33:38, Brock Noland wrote: > Attach the patch to the JIRA and I will see if my commit privileges are working. Done. Thanks Brock! Mike ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4392/#review6063 ----------------------------------------------------------- On 2012-03-17 02:03:05, Mike Percy wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4392/ ----------------------------------------------------------- (Updated 2012-03-17 02:03:05) Review request for Flume. Summary ------- This patch fixes issues with unit test logging in the SDK. This addresses bug FLUME-1035 . https://issues.apache.org/jira/browse/FLUME-1035 Diffs ----- flume-ng-sdk/src/test/resources/log4j.properties PRE-CREATION flume-ng-sdk/pom.xml d1c6adf flume-ng-sdk/src/test/java/org/apache/flume/api/RpcTestUtils.java 9497a3d flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java 8c40aa4 Diff: https://reviews.apache.org/r/4392/diff Testing ------- Thanks, Mike
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4392/#review6063
        -----------------------------------------------------------

        Ship it!

        Attach the patch to the JIRA and I will see if my commit privileges are working.

        • Brock

        On 2012-03-17 02:03:05, Mike Percy wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4392/

        -----------------------------------------------------------

        (Updated 2012-03-17 02:03:05)

        Review request for Flume.

        Summary

        -------

        This patch fixes issues with unit test logging in the SDK.

        This addresses bug FLUME-1035.

        https://issues.apache.org/jira/browse/FLUME-1035

        Diffs

        -----

        flume-ng-sdk/src/test/resources/log4j.properties PRE-CREATION

        flume-ng-sdk/pom.xml d1c6adf

        flume-ng-sdk/src/test/java/org/apache/flume/api/RpcTestUtils.java 9497a3d

        flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java 8c40aa4

        Diff: https://reviews.apache.org/r/4392/diff

        Testing

        -------

        Thanks,

        Mike

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4392/#review6063 ----------------------------------------------------------- Ship it! Attach the patch to the JIRA and I will see if my commit privileges are working. Brock On 2012-03-17 02:03:05, Mike Percy wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4392/ ----------------------------------------------------------- (Updated 2012-03-17 02:03:05) Review request for Flume. Summary ------- This patch fixes issues with unit test logging in the SDK. This addresses bug FLUME-1035 . https://issues.apache.org/jira/browse/FLUME-1035 Diffs ----- flume-ng-sdk/src/test/resources/log4j.properties PRE-CREATION flume-ng-sdk/pom.xml d1c6adf flume-ng-sdk/src/test/java/org/apache/flume/api/RpcTestUtils.java 9497a3d flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java 8c40aa4 Diff: https://reviews.apache.org/r/4392/diff Testing ------- Thanks, Mike
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4392/
        -----------------------------------------------------------

        (Updated 2012-03-17 02:03:05.530063)

        Review request for Flume.

        Changes
        -------

        There is a weird issue with Maven (bug?) where if one of my dependencies has a dependency set to "test", the distribution will not include it if I have the same dependency set to "compile". For the moment, the workaround is to specify slf4j-api as a dependency, along with slf4j-log4j12, even though they are only used in the tests.

        Summary
        -------

        This patch fixes issues with unit test logging in the SDK.

        This addresses bug FLUME-1035.
        https://issues.apache.org/jira/browse/FLUME-1035

        Diffs (updated)


        flume-ng-sdk/src/test/resources/log4j.properties PRE-CREATION
        flume-ng-sdk/pom.xml d1c6adf
        flume-ng-sdk/src/test/java/org/apache/flume/api/RpcTestUtils.java 9497a3d
        flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java 8c40aa4

        Diff: https://reviews.apache.org/r/4392/diff

        Testing
        -------

        Thanks,

        Mike

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4392/ ----------------------------------------------------------- (Updated 2012-03-17 02:03:05.530063) Review request for Flume. Changes ------- There is a weird issue with Maven (bug?) where if one of my dependencies has a dependency set to "test", the distribution will not include it if I have the same dependency set to "compile". For the moment, the workaround is to specify slf4j-api as a dependency, along with slf4j-log4j12, even though they are only used in the tests. Summary ------- This patch fixes issues with unit test logging in the SDK. This addresses bug FLUME-1035 . https://issues.apache.org/jira/browse/FLUME-1035 Diffs (updated) flume-ng-sdk/src/test/resources/log4j.properties PRE-CREATION flume-ng-sdk/pom.xml d1c6adf flume-ng-sdk/src/test/java/org/apache/flume/api/RpcTestUtils.java 9497a3d flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java 8c40aa4 Diff: https://reviews.apache.org/r/4392/diff Testing ------- Thanks, Mike
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4392/
        -----------------------------------------------------------

        Review request for Flume.

        Summary
        -------

        This patch fixes issues with unit test logging in the SDK.

        This addresses bug FLUME-1035.
        https://issues.apache.org/jira/browse/FLUME-1035

        Diffs


        flume-ng-sdk/pom.xml d1c6adf
        flume-ng-sdk/src/test/java/org/apache/flume/api/RpcTestUtils.java 9497a3d
        flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java 8c40aa4
        flume-ng-sdk/src/test/resources/log4j.properties PRE-CREATION

        Diff: https://reviews.apache.org/r/4392/diff

        Testing
        -------

        Thanks,

        Mike

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4392/ ----------------------------------------------------------- Review request for Flume. Summary ------- This patch fixes issues with unit test logging in the SDK. This addresses bug FLUME-1035 . https://issues.apache.org/jira/browse/FLUME-1035 Diffs flume-ng-sdk/pom.xml d1c6adf flume-ng-sdk/src/test/java/org/apache/flume/api/RpcTestUtils.java 9497a3d flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java 8c40aa4 flume-ng-sdk/src/test/resources/log4j.properties PRE-CREATION Diff: https://reviews.apache.org/r/4392/diff Testing ------- Thanks, Mike

          People

          • Assignee:
            Mike Percy
            Reporter:
            Mike Percy
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development