[FLINK-9743] PackagedProgram.extractContainedLibraries fails on Windows

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4.2, 1.5.0, 1.6.0
• Fix Version/s: 1.4.3, 1.5.2, 1.6.0
• Component/s: Command Line Client, Runtime / Coordination
• Labels: pull-request-available
• Assignee: Sergey Nuyanzin
• Reporter: Chesnay Schepler
• Created: 04/Jul/18 14:37
• Updated: 28/Feb/19 13:30
• Resolved: 11/Jul/18 10:06

Description

Submitting a jar that contains other jars on Windows fails with an exception:

org.apache.flink.client.program.ProgramInvocationException: Unknown I/O error while extracting contained jar files.
        at org.apache.flink.client.program.PackagedProgram.extractContainedLibraries(PackagedProgram.java:752)
        at org.apache.flink.client.program.PackagedProgram.<init>(PackagedProgram.java:194)
        at org.apache.flink.client.cli.CliFrontend.buildProgram(CliFrontend.java:833)
        at org.apache.flink.client.cli.CliFrontend.run(CliFrontend.java:201)
        at org.apache.flink.client.cli.CliFrontend.parseParameters(CliFrontend.java:1020)
        at org.apache.flink.client.cli.CliFrontend.lambda$main$9(CliFrontend.java:1096)
        at org.apache.flink.runtime.security.NoOpSecurityContext.runSecured(NoOpSecurityContext.java:30)
        at org.apache.flink.client.cli.CliFrontend.main(CliFrontend.java:1096)
Caused by: org.apache.flink.client.program.ProgramInvocationException: An I/O error occurred while creating temporary file to extract nested library 'lib/antrunner.jar'.
        at org.apache.flink.client.program.PackagedProgram.extractContainedLibraries(PackagedProgram.java:708)
        ... 7 more
Caused by: java.io.IOException: Unable to create temporary file, C:\Users\XXX\AppData\Local\Temp\1751416743_6922010711856647205lib\antrunner.jar
        at java.io.File$TempDirectory.generateFile(Unknown Source)
        at java.io.File.createTempFile(Unknown Source)
        at java.io.File.createTempFile(Unknown Source)
        at org.apache.flink.client.program.PackagedProgram.extractContainedLibraries(PackagedProgram.java:702)
        ... 7 more

PackagedProgram.extractContainedLibraries tries to replace all path separators using the platform-dependent File.separateChar, however the path separator for jars (and zips for that matter) is always /.

final JarEntry entry = containedJarFileEntries.get(i);
String name = entry.getName();
name = name.replace(File.separatorChar, '_');

Issue Links

• is duplicated by: FLINK-4058 Error uploading JAR with dependencies using flink.bat on a Windows stand-alone instance
• links to: GitHub Pull Request #6263