[FLINK-9614] Improve the error message for Compiler#compile

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: 1.5.0
• Component/s: Table SQL / API
• Labels: pull-request-available
• Assignee: zhangminglei
• Reporter: zhangminglei
• Created: 19/Jun/18 13:12
• Updated: 29/Jul/18 07:42
• Resolved: 29/Jul/18 07:42

Description

When the below sql has too long. Like

case when .... case when .....
when host in ('114.67.56.94','114.67.56.102','114.67.56.103','114.67.56.106','114.67.56.107','183.60.220.231','183.60.220.232','183.60.219.247','114.67.56.94','114.67.56.102','114.67.56.103','114.67.56.106','114.67.56.107','183.60.220.231','183.60.220.232','183.60.219.247','114.67.56.94','114.67.56.102','114.67.56.103','114.67.56.106','114.67.56.107','183.60.220.231','183.60.220.232','183.60.219.247') then 'condition'

Then cause the StackOverflowError. And the current code is below, we can solve this by setting -Xss 20m, instead of This is a bug......

trait Compiler[T] {

  @throws(classOf[CompileException])
  def compile(cl: ClassLoader, name: String, code: String): Class[T] = {
    require(cl != null, "Classloader must not be null.")
    val compiler = new SimpleCompiler()
    compiler.setParentClassLoader(cl)
    try {
      compiler.cook(code)
    } catch {
      case t: Throwable =>
        throw new InvalidProgramException("Table program cannot be compiled. " +
          "This is a bug. Please file an issue.", t)
    }
    compiler.getClassLoader.loadClass(name).asInstanceOf[Class[T]]
  }
}

Issue Links

• links to: GitHub Pull Request #6380
• links to: GitHub Pull Request #6380