[FLINK-9022] fix resource close in `StreamTaskStateInitializerImpl.streamOperatorStateContext()`

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.5.0
• Fix Version/s: 1.5.0
• Component/s: Runtime / State Backends
• Assignee: Stefan Richter
• Reporter: Sihua Zhou
• Created: 19/Mar/18 11:42
• Updated: 19/Apr/18 09:16
• Resolved: 19/Apr/18 09:16

Description

We have the following code in StreamTaskStateInitializerImpl.streamOperatorStateContext() which is incorrect:

} catch (Exception ex) {
	// cleanup if something went wrong before results got published.
	if (streamTaskCloseableRegistry.unregisterCloseable(keyedStatedBackend)) {
		IOUtils.closeQuietly(keyedStatedBackend);
	}

	if (streamTaskCloseableRegistry.unregisterCloseable(operatorStateBackend)) {
		IOUtils.closeQuietly(keyedStatedBackend); // this should close operatorStateBackend
	}

	if (streamTaskCloseableRegistry.unregisterCloseable(rawKeyedStateInputs)) {
		IOUtils.closeQuietly(rawKeyedStateInputs);
	}

	if (streamTaskCloseableRegistry.unregisterCloseable(rawOperatorStateInputs)) {
		IOUtils.closeQuietly(rawOperatorStateInputs);
	}

	if (streamTaskCloseableRegistry.unregisterCloseable(rawOperatorStateInputs)) {
		IOUtils.closeQuietly(rawOperatorStateInputs);
	}

	throw new Exception("Exception while creating StreamOperatorStateContext.", ex);
}

Issue Links

• links to: GitHub Pull Request #5716