[FLINK-8984] Disabling credit based flow control deadlocks Flink on checkpoint

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.5.0
• Fix Version/s: 1.5.0
• Component/s: Runtime / Configuration, Runtime / Network
• Assignee: Piotr Nowojski
• Reporter: Piotr Nowojski
• Created: 16/Mar/18 12:27
• Updated: 21/Mar/18 22:41
• Resolved: 21/Mar/18 22:41

Description

This is configuration issue. There are two options: 

taskmanager.network.credit-based-flow-control.enabled

and

taskmanager.exactly-once.blocking.data.enabled

If we disable first one, but remain default value for the second one deadlocks will occur. I think we can safely drop the second config value altogether and always use blocking BarrierBuffer for credit based flow control and spilling BarrierBuffer for non credit based flow control.

cc zjwang

Issue Links

• links to: GitHub Pull Request #5708