[FLINK-8921] Split code generated call expression

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Abandoned
• Component/s: Table SQL / Legacy Planner
• Labels: pull-request-available
• Assignee: xueyu
• Reporter: Timo Walther
• Created: 12/Mar/18 09:19
• Updated: 18/Jun/20 07:52
• Resolved: 05/Feb/20 14:09

Description

In FLINK-8274 we introduced the possibility of splitting the generated code into multiple methods in order to exceed the JVMs maximum method size (see also https://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.9).

At the moment we only split methods by fields, however, this is not enough in all case. We should also split expressions. I suggest to split the operands of a RexCall in org.apache.flink.table.codegen.CodeGenerator#visitCall if we reach a certain threshold. However, this should happen as lazily as possible to keep the runtime overhead low.

Issue Links

• links to: GitHub Pull Request #6921