[FLINK-8057] KvStateRegistry#registerKvState may randomly fail

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: 1.4.0
• Component/s: Runtime / Queryable State
• Assignee: Unassigned
• Reporter: Chesnay Schepler
• Created: 13/Nov/17 14:52
• Updated: 22/Sep/20 15:37
• Resolved: 22/Sep/20 15:37

Description

The KvStateRegistry#registerKvState method is a bit weird. On each call, a new KvStateID is generated, and we then check whether a state for this ID was already registered. Realistically, this is never the case making the check unnecessary, and on the off-chance that it does happen the job will fail for no good reason.

KvStateID kvStateId = new KvStateID();

if (registeredKvStates.putIfAbsent(kvStateId, kvState) == null) {
	KvStateRegistryListener listener = this.listener.get();
	if (listener != null) {
		listener.notifyKvStateRegistered(
				jobId,
				jobVertexId,
				keyGroupRange,
				registrationName,
				kvStateId);
	}

	return kvStateId;
} else {
	throw new IllegalStateException(kvStateId + " is already registered.");
}

Issue Links

• links to: GitHub Pull Request #5028