[FLINK-7995] Created curator/zk module in flink-shaded

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 1.4.0
• Component/s: Build System
• Assignee: Unassigned
• Reporter: Chesnay Schepler
• Created: 06/Nov/17 12:13
• Updated: 31/Jan/20 10:21
• Resolved: 31/Jan/20 10:21

Description

I propose creating a dedicated curator/zookeeper module in flink-shaded.

Zookeeper & curator are dependencies that are used in multiple modules (kafka 0.8, runtime, mesos), which, since these dependencies are shaded, cause more headaches than ultimately necessary.

For example, the shading of curator is done in flink-runtime, when really it should happen in flink-shaded curator. This is done as otherwise the shading pattern in flink-runtime would have to be kept in sync with the one in flink-shaded-curator.
This is also exactly what the kafka connector does, whereas flink-mesos goes through utility methods in flink-runtime that wrap the actual zk/curator accesses.

What's worse is that you have to know that you must account for the shading. Any module depending on flink-runtime is free to import unshaded curator, neither the IDE nor maven will complain, and tests generally don't catch shading issues.

A separate flink-shaded module that bundles zookeeper and curator would alleviate these issues.

Issue Links

• duplicates: FLINK-15742 Add zk+curator module to flink-shaded
• relates to: FLINK-5513 Remove relocation of internal API classes