Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-7609

WindowWordCount example doesn't print countWindow output with default configs

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.0
    • Fix Version/s: 1.4.0
    • Component/s: Examples
    • Labels:
      None

      Description

      When running WindowWordCount example with no params (using default params), no output is generated and thus printed, because the default 'window' and 'slide' value is too large (250 and 150).

      The solution is to lower default 'window' and 'slide' values to probably 4 and 2

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user bowenli86 opened a pull request:

          https://github.com/apache/flink/pull/4662

          FLINK-7609[examples] WindowWordCount example doesn't print countWindow output with default configs

            1. What is the purpose of the change

          When running WindowWordCount example with no params (using default params), no output is generated and thus printed, because the default 'window' and 'slide' value is too large (250 and 150).

          The solution is to lower default 'window' and 'slide' values to probably 4 and 2

            1. Brief change log

          Lower default 'window' and 'slide' values in this example to 4 and 2

            1. Verifying this change

          This change is a trivial rework / code cleanup without any test coverage.

          I tested the example with updated default values, and it now generates and prints output.

            1. Does this pull request potentially affect one of the following parts:
            1. Documentation
          • Does this pull request introduce a new feature? (no)

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/bowenli86/flink FLINK-7609

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/4662.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #4662



          Show
          githubbot ASF GitHub Bot added a comment - GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/4662 FLINK-7609 [examples] WindowWordCount example doesn't print countWindow output with default configs What is the purpose of the change When running WindowWordCount example with no params (using default params), no output is generated and thus printed, because the default 'window' and 'slide' value is too large (250 and 150). The solution is to lower default 'window' and 'slide' values to probably 4 and 2 Brief change log Lower default 'window' and 'slide' values in this example to 4 and 2 Verifying this change This change is a trivial rework / code cleanup without any test coverage. I tested the example with updated default values, and it now generates and prints output. Does this pull request potentially affect one of the following parts: Documentation Does this pull request introduce a new feature? (no) You can merge this pull request into a Git repository by running: $ git pull https://github.com/bowenli86/flink FLINK-7609 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4662.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4662
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/4662

          Aren't these values a bit too low? (I'm specifically worried about cases where users supply their own data)
          Would 100/50 maybe work?

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/4662 Aren't these values a bit too low? (I'm specifically worried about cases where users supply their own data) Would 100/50 maybe work?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user bowenli86 commented on the issue:

          https://github.com/apache/flink/pull/4662

          There's no output with 100/50 either, because the default text we use at WordCountData.WORDS is not very long and cannot satisfy the count window size. There's only 11 window ouputs even with 10/5, which are still a bigger size.

          I prefer 4/2, but also think 10/5 is also ok, because the program is for demo purpose and new users would doubt the program's accuracy if it doesn't generate enough output. What do you think? @zentol

          Show
          githubbot ASF GitHub Bot added a comment - Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4662 There's no output with 100/50 either, because the default text we use at WordCountData.WORDS is not very long and cannot satisfy the count window size. There's only 11 window ouputs even with 10/5, which are still a bigger size. I prefer 4/2, but also think 10/5 is also ok, because the program is for demo purpose and new users would doubt the program's accuracy if it doesn't generate enough output. What do you think? @zentol
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/4662

          lets go with 10/5 then.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/4662 lets go with 10/5 then.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user bowenli86 commented on the issue:

          https://github.com/apache/flink/pull/4662

          @zentol Done

          Show
          githubbot ASF GitHub Bot added a comment - Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4662 @zentol Done
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user bowenli86 commented on the issue:

          https://github.com/apache/flink/pull/4662

          @zentol and this one. Thanks!

          Show
          githubbot ASF GitHub Bot added a comment - Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4662 @zentol and this one. Thanks!
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/4662

          merging.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/4662 merging.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/4662

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4662
          Hide
          Zentol Chesnay Schepler added a comment -

          1.4: baebbabfc6913598122fc5df8645097172bd9e65

          Show
          Zentol Chesnay Schepler added a comment - 1.4: baebbabfc6913598122fc5df8645097172bd9e65

            People

            • Assignee:
              phoenixjiangnan Bowen Li
              Reporter:
              phoenixjiangnan Bowen Li
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development