Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-7228

Harden HistoryServerStaticFileHandlerTest

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3.1, 1.4.0
    • Fix Version/s: 1.4.0, 1.3.2
    • Component/s: Tests, Webfrontend
    • Labels:
      None

      Description

      We can harden the test to use a free port instead of the hard-coded 8081.

        Issue Links

          Activity

          Hide
          Zentol Chesnay Schepler added a comment -

          1.3: e3e71052efc33e384c916b9960077b21cd2b9ee3
          1.4: e5afe563ad254ae0d5be300475b732f4b17a9770

          Show
          Zentol Chesnay Schepler added a comment - 1.3: e3e71052efc33e384c916b9960077b21cd2b9ee3 1.4: e5afe563ad254ae0d5be300475b732f4b17a9770
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/4366

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4366
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/4366

          This looks good.

          +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/4366 This looks good. +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user zentol opened a pull request:

          https://github.com/apache/flink/pull/4366

          FLINK-7228 [history] Use free port in HistoryServerStaticFileServer…

          This PR changes `HistoryServerStaticFileServerHandlerTest#testRespondWithFile` to select a free port.

          Previously the test always tried to use port 8081, which could lead to test failures if this port was taken, for example by another web interface.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/zentol/flink 7228

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/4366.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #4366


          commit 55d972fe580323836971151acee81e858433b859
          Author: zentol <chesnay@apache.org>
          Date: 2017-07-19T12:45:49Z

          FLINK-7228 [history] Use free port in HistoryServerStaticFileServerHandlerTest


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/4366 FLINK-7228 [history] Use free port in HistoryServerStaticFileServer… This PR changes `HistoryServerStaticFileServerHandlerTest#testRespondWithFile` to select a free port. Previously the test always tried to use port 8081, which could lead to test failures if this port was taken, for example by another web interface. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zentol/flink 7228 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4366.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4366 commit 55d972fe580323836971151acee81e858433b859 Author: zentol <chesnay@apache.org> Date: 2017-07-19T12:45:49Z FLINK-7228 [history] Use free port in HistoryServerStaticFileServerHandlerTest

            People

            • Assignee:
              Zentol Chesnay Schepler
              Reporter:
              Zentol Chesnay Schepler
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development