Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-7226

REST responses contain invalid content-encoding header

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0, 1.1.4, 1.3.1, 1.4.0
    • Fix Version/s: 1.4.0, 1.3.2
    • Component/s: Webfrontend
    • Labels:
      None

      Description

      FLINK-5705 made changes to the RuntimeMonitorHandler to set the content-encoding header to UTF-8. This however isn't a valid value for this header, and should instead be included in the content-type header.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user zentol opened a pull request:

          https://github.com/apache/flink/pull/4392

          FLINK-7226 [webUI] Properly include UTF-8 in content-type header

          This PR corrects the `content-encoding` header introduced in FLINK-5705. As documented [here](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Encoding) this header is used to denote how the content is compressed (for example, with gzip or deflate).

          That the strings are encoded using `UTF-8` should be documented in the `content-type` header instead, using the `charset` parameter, as documented [here](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Type).

          There was also a bug in `TestBaseUtils#getFromHTTP`, where the UTF-8 charset was retrieved from the `content-encoding` header.

          I've added tests to make sure we don't break this again.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/zentol/flink 7226

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/4392.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #4392


          commit 3093d53f6f07afcc351b99a39586463fb0a0b83e
          Author: zentol <chesnay@apache.org>
          Date: 2017-07-19T11:51:35Z

          FLINK-7226 [webUI] Properly include UTF-8 in content-type header


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/4392 FLINK-7226 [webUI] Properly include UTF-8 in content-type header This PR corrects the `content-encoding` header introduced in FLINK-5705 . As documented [here] ( https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Encoding ) this header is used to denote how the content is compressed (for example, with gzip or deflate). That the strings are encoded using `UTF-8` should be documented in the `content-type` header instead, using the `charset` parameter, as documented [here] ( https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Type ). There was also a bug in `TestBaseUtils#getFromHTTP`, where the UTF-8 charset was retrieved from the `content-encoding` header. I've added tests to make sure we don't break this again . You can merge this pull request into a Git repository by running: $ git pull https://github.com/zentol/flink 7226 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4392.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4392 commit 3093d53f6f07afcc351b99a39586463fb0a0b83e Author: zentol <chesnay@apache.org> Date: 2017-07-19T11:51:35Z FLINK-7226 [webUI] Properly include UTF-8 in content-type header
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user greghogan commented on a diff in the pull request:

          https://github.com/apache/flink/pull/4392#discussion_r129317438

          — Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JobCancellationWithSavepointHandlers.java —
          @@ -266,7 +266,7 @@ public void onComplete(Throwable failure, Object resp) throws Throwable {

          response.headers().set(HttpHeaders.Names.LOCATION, location);

          • response.headers().set(HttpHeaders.Names.CONTENT_TYPE, "application/json");
            + response.headers().set(HttpHeaders.Names.CONTENT_TYPE, "application/json; charset=UTF-8");
              • End diff –

          Should this also use `ENCODING.name()`?

          Show
          githubbot ASF GitHub Bot added a comment - Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/4392#discussion_r129317438 — Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JobCancellationWithSavepointHandlers.java — @@ -266,7 +266,7 @@ public void onComplete(Throwable failure, Object resp) throws Throwable { response.headers().set(HttpHeaders.Names.LOCATION, location); response.headers().set(HttpHeaders.Names.CONTENT_TYPE, "application/json"); + response.headers().set(HttpHeaders.Names.CONTENT_TYPE, "application/json; charset=UTF-8"); End diff – Should this also use `ENCODING.name()`?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on a diff in the pull request:

          https://github.com/apache/flink/pull/4392#discussion_r129514223

          — Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JobCancellationWithSavepointHandlers.java —
          @@ -266,7 +266,7 @@ public void onComplete(Throwable failure, Object resp) throws Throwable {

          response.headers().set(HttpHeaders.Names.LOCATION, location);

          • response.headers().set(HttpHeaders.Names.CONTENT_TYPE, "application/json");
            + response.headers().set(HttpHeaders.Names.CONTENT_TYPE, "application/json; charset=UTF-8");
              • End diff –

          yes, will fix it and search for other occurrences while merging.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4392#discussion_r129514223 — Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JobCancellationWithSavepointHandlers.java — @@ -266,7 +266,7 @@ public void onComplete(Throwable failure, Object resp) throws Throwable { response.headers().set(HttpHeaders.Names.LOCATION, location); response.headers().set(HttpHeaders.Names.CONTENT_TYPE, "application/json"); + response.headers().set(HttpHeaders.Names.CONTENT_TYPE, "application/json; charset=UTF-8"); End diff – yes, will fix it and search for other occurrences while merging.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/4392

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4392
          Hide
          Zentol Chesnay Schepler added a comment -

          1.4: 113b8c41da4b5d5be2e890e3e38567272f7dff9a

          Show
          Zentol Chesnay Schepler added a comment - 1.4: 113b8c41da4b5d5be2e890e3e38567272f7dff9a
          Hide
          Zentol Chesnay Schepler added a comment -

          1.3: 64d249eb00b16115fd38d1b01b9ac0caa54f0637

          Show
          Zentol Chesnay Schepler added a comment - 1.3: 64d249eb00b16115fd38d1b01b9ac0caa54f0637
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user willddy commented on the issue:

          https://github.com/apache/flink/pull/4392

          I still found this issue only when the job id not found as follows in the latest v1.3.2. Pls. reopen the issue
          localhost:8001/jobs/0e12860ffae73f23dc104aedb814d6d2

          Show
          githubbot ASF GitHub Bot added a comment - Github user willddy commented on the issue: https://github.com/apache/flink/pull/4392 I still found this issue only when the job id not found as follows in the latest v1.3.2. Pls. reopen the issue localhost:8001/jobs/0e12860ffae73f23dc104aedb814d6d2
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/4392

          @willddy Please open a new JIRA @ https://issues.apache.org/jira/browse/FLINK with a description of what error you are encountering. I looked through the code and we never set the encoding header anywhere; i expect your issue to be separate from this one.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/4392 @willddy Please open a new JIRA @ https://issues.apache.org/jira/browse/FLINK with a description of what error you are encountering. I looked through the code and we never set the encoding header anywhere ; i expect your issue to be separate from this one.

            People

            • Assignee:
              Zentol Chesnay Schepler
              Reporter:
              Zentol Chesnay Schepler
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development