Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-7154

Missing call to build CsvTableSource example

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.4.0, 1.3.2
    • Fix Version/s: 1.4.0, 1.3.2
    • Component/s: Documentation
    • Labels:
      None

      Description

      The Java and Scala example code for CsvTableSource create a builder but are missing the final call to build.

      https://ci.apache.org/projects/flink/flink-docs-release-1.3/dev/table/sourceSinks.html#csvtablesource

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user greghogan opened a pull request:

          https://github.com/apache/flink/pull/4313

          FLINK-7154 [docs] Missing call to build CsvTableSource example

          The Java and Scala example code for CsvTableSource create a builder but are missing the final call to build.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/greghogan/flink 7154_missing_call_to_build_csvtablesource_example

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/4313.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #4313


          commit d32c4526398856de03557940cb430a5a4f0cff93
          Author: Greg Hogan <code@greghogan.com>
          Date: 2017-07-11T18:21:50Z

          FLINK-7154 [docs] Missing call to build CsvTableSource example

          The Java and Scala example code for CsvTableSource create a builder but
          are missing the final call to build.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/4313 FLINK-7154 [docs] Missing call to build CsvTableSource example The Java and Scala example code for CsvTableSource create a builder but are missing the final call to build. You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink 7154_missing_call_to_build_csvtablesource_example Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4313.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4313 commit d32c4526398856de03557940cb430a5a4f0cff93 Author: Greg Hogan <code@greghogan.com> Date: 2017-07-11T18:21:50Z FLINK-7154 [docs] Missing call to build CsvTableSource example The Java and Scala example code for CsvTableSource create a builder but are missing the final call to build.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fhueske commented on the issue:

          https://github.com/apache/flink/pull/4313

          Thanks for the fix @greghogan.
          I'll merge this.

          Show
          githubbot ASF GitHub Bot added a comment - Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4313 Thanks for the fix @greghogan. I'll merge this.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/4313

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4313
          Hide
          fhueske Fabian Hueske added a comment -

          Fixed for 1.3.2 with 1ed2ef4389d1814b5353df6675295a93b54cc5c7
          Fixed for 1.4.0 with 94d3166b474ca4b4270ee87725ee0f9a08c8bd56

          Show
          fhueske Fabian Hueske added a comment - Fixed for 1.3.2 with 1ed2ef4389d1814b5353df6675295a93b54cc5c7 Fixed for 1.4.0 with 94d3166b474ca4b4270ee87725ee0f9a08c8bd56

            People

            • Assignee:
              greghogan Greg Hogan
              Reporter:
              greghogan Greg Hogan
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development