[FLINK-7070] Rework ScalaShellITCase#testSubmissionOfExternalLibraryStream

• Type: Improvement
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.4.0
• Fix Version/s: 1.4.0
• Component/s: Scala Shell, Tests
• Assignee: Aljoscha Krettek
• Reporter: Chesnay Schepler
• Created: 03/Jul/17 13:59
• Updated: 04/Jul/17 12:36
• Resolved: 04/Jul/17 12:36

Description

The ScalaShellITCase makes use of flink-ml jar in one of it's tests. Since flink-ml is not even declared as a dependency the test only works because by coincidence flink-ml is build before flink-scala-shell.

  @Test
  def testSubmissionOfExternalLibraryBatch: Unit = {
  ...
  val folder = findLibraryFolder(
    "../flink-libraries/flink-ml/target/",
    "../../flink-libraries/flink-ml/target/")
  ...
  }

  def findLibraryFolder(paths: String*): File = {
    for (path <- paths) {
      val folder = new File(path)
      if (folder.exists()) {
        return folder
      }
    }
    throw new RuntimeException("Library folder not found in any of the supplied paths!")
  }

At the very least we should declare the dependency, or even better rework this test to rely on a custom jar built in flink-scala-shell to reduce dependencies.

Also, the exception message in findLibraryFolder should contain the folder it couldn't find.

Issue Links

• links to: GitHub Pull Request #4249