[FLINK-7069] Catch exceptions for each reporter separately

• Type: Improvement
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.3.1, 1.4.0
• Fix Version/s: 1.3.2, 1.4.0
• Component/s: Runtime / Metrics
• Assignee: Chesnay Schepler
• Reporter: Chesnay Schepler
• Created: 03/Jul/17 13:46
• Updated: 11/Jul/17 12:39
• Resolved: 11/Jul/17 12:39

Description

The metric system can be effectively disabled by a reporter that throws exceptions whenever it is notified of adding metrics.

The reason is that the catching of exceptions isn't granular enough, as this peace of psude code shows:

addMetric(metric):
	try
		for reporter in reporters:
			reporter.addMetric(metric)
		metricQueryService.addMetric(metric)
	catch (e)
		logError(e)	

If a reporter throws an exception we never even attempt the other reporters, not notify the MQS which disabled metrics in the WebUI.

Issue Links

• links to: GitHub Pull Request #4248