Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-7034

GraphiteReporter cannot recover from lost connection

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.4.0, 1.3.2
    • Component/s: Metrics
    • Labels:
      None

      Description

      Now Flink uses metric version 1.3.0 in which there is a Bug. I think you should use version 1.3.1 or higher

        Issue Links

          Activity

          Hide
          aljoscha Aljoscha Krettek added a comment -

          Chesnay Schepler Do you think we can bump this to 3.2.3?

          Show
          aljoscha Aljoscha Krettek added a comment - Chesnay Schepler Do you think we can bump this to 3.2.3?
          Hide
          Zentol Chesnay Schepler added a comment -

          should be okay since we're just bumping the bugfix version.

          Show
          Zentol Chesnay Schepler added a comment - should be okay since we're just bumping the bugfix version.
          Hide
          StephanEwen Stephan Ewen added a comment -

          +1 to include this

          Show
          StephanEwen Stephan Ewen added a comment - +1 to include this
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user aljoscha opened a pull request:

          https://github.com/apache/flink/pull/4306

          FLINK-7034 Bump Dropwizard Metrics version to 3.2.3

          R: @zentol

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/aljoscha/flink jira-7034-bump-metrics-version

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/4306.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #4306


          commit fffdaaee902a4154594697b0e727abbd8b955d2f
          Author: Aljoscha Krettek <aljoscha.krettek@gmail.com>
          Date: 2017-07-12T08:12:33Z

          FLINK-7034 Bump Dropwizard Metrics version to 3.2.3


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/4306 FLINK-7034 Bump Dropwizard Metrics version to 3.2.3 R: @zentol You can merge this pull request into a Git repository by running: $ git pull https://github.com/aljoscha/flink jira-7034-bump-metrics-version Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4306.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4306 commit fffdaaee902a4154594697b0e727abbd8b955d2f Author: Aljoscha Krettek <aljoscha.krettek@gmail.com> Date: 2017-07-12T08:12:33Z FLINK-7034 Bump Dropwizard Metrics version to 3.2.3
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/4306

          I would only bump it to `3.1.5`. This version also contains the required fix.

          Switching to 3.2 should imo only be done after manually testing all reporters since we don't have IT cases in place.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/4306 I would only bump it to `3.1.5`. This version also contains the required fix. Switching to 3.2 should imo only be done after manually testing all reporters since we don't have IT cases in place.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user aljoscha commented on the issue:

          https://github.com/apache/flink/pull/4306

          Gotcha, I'll "downgrade" to `3.1.5`.

          Show
          githubbot ASF GitHub Bot added a comment - Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4306 Gotcha, I'll "downgrade" to `3.1.5`.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user aljoscha commented on the issue:

          https://github.com/apache/flink/pull/4306

          (And yes, this already seems to complicated for a one-line version change. 😅)

          Show
          githubbot ASF GitHub Bot added a comment - Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4306 (And yes, this already seems to complicated for a one-line version change. 😅)
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/4306

          +1.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/4306 +1.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user aljoscha closed the pull request at:

          https://github.com/apache/flink/pull/4306

          Show
          githubbot ASF GitHub Bot added a comment - Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/4306
          Hide
          aljoscha Aljoscha Krettek added a comment -

          Fixed on master in
          b3b142283b7eec297eebbd18e2b534a78553b69c

          Fixed on release-1.3 in
          bf06171198e13299396a80cd777563f6e3185c02

          Show
          aljoscha Aljoscha Krettek added a comment - Fixed on master in b3b142283b7eec297eebbd18e2b534a78553b69c Fixed on release-1.3 in bf06171198e13299396a80cd777563f6e3185c02
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user aljoscha commented on the issue:

          https://github.com/apache/flink/pull/4306

          Thanks for reviewing! 😃

          Show
          githubbot ASF GitHub Bot added a comment - Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4306 Thanks for reviewing! 😃

            People

            • Assignee:
              aljoscha Aljoscha Krettek
              Reporter:
              egorko Aleksandr
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development