Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-7025

Using NullByteKeySelector for Unbounded ProcTime NonPartitioned Over

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.1, 1.4.0
    • Fix Version/s: 1.4.0, 1.3.2
    • Component/s: Table API & SQL
    • Labels:
      None

      Description

      Currently we added `Cleanup State` feature. But It not work well if we enabled the stateCleaning on Unbounded ProcTime NonPartitioned Over window, Because in `ProcessFunctionWithCleanupState` we has using the keyed state.

      So, In this JIRA. I'll change the `Unbounded ProcTime NonPartitioned Over` to `partitioned Over` by using NullByteKeySelector. OR created a `NonKeyedProcessFunctionWithCleanupState`. But I think the first way is simpler. What do you think? Fabian Hueske

        Issue Links

          Activity

          Hide
          fhueske Fabian Hueske added a comment -

          Fixed for 1.3.2 with db7f0ffd4f882cdcb294c470a15665752b765816
          Fixed for 1.4.0 with 55ab34ff3b92b2567bcab80f39826a9667f1c9ce

          Show
          fhueske Fabian Hueske added a comment - Fixed for 1.3.2 with db7f0ffd4f882cdcb294c470a15665752b765816 Fixed for 1.4.0 with 55ab34ff3b92b2567bcab80f39826a9667f1c9ce
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/4212

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4212
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fhueske commented on the issue:

          https://github.com/apache/flink/pull/4212

          merging

          Show
          githubbot ASF GitHub Bot added a comment - Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4212 merging
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fhueske commented on the issue:

          https://github.com/apache/flink/pull/4212

          +1 to merge

          Show
          githubbot ASF GitHub Bot added a comment - Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4212 +1 to merge
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user sunjincheng121 opened a pull request:

          https://github.com/apache/flink/pull/4212

          FLINK-7025[table]Using NullByteKeySelector for Unbounded ProcTime N…

          …onPartitioned Over

          Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
          If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
          In addition to going through the list, please provide a meaningful description of your changes.

          • [x] General
          • The pull request references the related JIRA issue ("FLINK-7025[table]Using NullByteKeySelector for Unbounded ProcTime NonPartitioned Over")
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [ ] Documentation
          • Documentation has been added for new functionality
          • Old documentation affected by the pull request has been updated
          • JavaDoc for public methods has been added
          • [x] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/sunjincheng121/flink FLINK-7025-PR

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/4212.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #4212


          commit 37c137547ea6b445b50274297427886fb1c1ae59
          Author: sunjincheng121 <sunjincheng121@gmail.com>
          Date: 2017-06-28T15:19:56Z

          FLINK-7025[table]Using NullByteKeySelector for Unbounded ProcTime NonPartitioned Over


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user sunjincheng121 opened a pull request: https://github.com/apache/flink/pull/4212 FLINK-7025 [table] Using NullByteKeySelector for Unbounded ProcTime N… …onPartitioned Over Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide] ( http://flink.apache.org/how-to-contribute.html ). In addition to going through the list, please provide a meaningful description of your changes. [x] General The pull request references the related JIRA issue (" FLINK-7025 [table] Using NullByteKeySelector for Unbounded ProcTime NonPartitioned Over") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [ ] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [x] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/sunjincheng121/flink FLINK-7025 -PR Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4212.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4212 commit 37c137547ea6b445b50274297427886fb1c1ae59 Author: sunjincheng121 <sunjincheng121@gmail.com> Date: 2017-06-28T15:19:56Z FLINK-7025 [table] Using NullByteKeySelector for Unbounded ProcTime NonPartitioned Over
          Hide
          sunjincheng121 sunjincheng added a comment -

          Yes, Sounds good.

          Show
          sunjincheng121 sunjincheng added a comment - Yes, Sounds good.
          Hide
          fhueske Fabian Hueske added a comment -

          I agree. IMO, we should go for the keyed state (NullByteKeySelector) approach. This will also be more consistent with the other Over window operators.

          Show
          fhueske Fabian Hueske added a comment - I agree. IMO, we should go for the keyed state (NullByteKeySelector) approach. This will also be more consistent with the other Over window operators.

            People

            • Assignee:
              sunjincheng121 sunjincheng
              Reporter:
              sunjincheng121 sunjincheng
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development