Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6789

Remove duplicated test utility reducer in optimizer

        Details

        • Type: Improvement
        • Status: Resolved
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 1.4.0
        • Fix Version/s: 1.4.0, 1.3.2
        • Component/s: Optimizer, Tests
        • Labels:
          None

          Description

          The DummyReducer and SelectOneReducer in org.apache.flink.optimizer.testfunctions are identical; we could remove one of them.

            Issue Links

            links to

            Web Link GitHub Pull Request #4216

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              githubbot ASF GitHub Bot added a comment -

              Github user zhangminglei closed the pull request at:

              https://github.com/apache/flink/pull/4215

              Show
              githubbot ASF GitHub Bot added a comment - Github user zhangminglei closed the pull request at: https://github.com/apache/flink/pull/4215
              Hide
              Permalink
              githubbot ASF GitHub Bot added a comment -

              GitHub user zhangminglei opened a pull request:

              https://github.com/apache/flink/pull/4216

              FLINK-6789 [optimizer] Remove duplicated test utility reducer in op…

              Removed ```DummyReducer``` class, keep ```SelectOneReducer``` instead.

              You can merge this pull request into a Git repository by running:

              $ git pull https://github.com/zhangminglei/flink flink-6789

              Alternatively you can review and apply these changes as the patch at:

              https://github.com/apache/flink/pull/4216.patch

              To close this pull request, make a commit to your master/trunk branch
              with (at least) the following in the commit message:

              This closes #4216

              commit 1426b14198f33ef886498bc46964485b14afb8d0
              Author: zhangminglei <zml13856086071@163.com>
              Date: 2017-06-29T03:49:30Z

              FLINK-6789 [optimizer] Remove duplicated test utility reducer in optimizer

              Show
              githubbot ASF GitHub Bot added a comment - GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/4216 FLINK-6789 [optimizer] Remove duplicated test utility reducer in op… Removed ```DummyReducer``` class, keep ```SelectOneReducer``` instead. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zhangminglei/flink flink-6789 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/4216.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4216 commit 1426b14198f33ef886498bc46964485b14afb8d0 Author: zhangminglei <zml13856086071@163.com> Date: 2017-06-29T03:49:30Z FLINK-6789 [optimizer] Remove duplicated test utility reducer in optimizer
              Hide
              Permalink
              githubbot ASF GitHub Bot added a comment -

              Github user tzulitai commented on the issue:

              https://github.com/apache/flink/pull/4216

              LGTM, merging ...

              Show
              githubbot ASF GitHub Bot added a comment - Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4216 LGTM, merging ...
              Hide
              Permalink
              githubbot ASF GitHub Bot added a comment -

              Github user zhangminglei commented on the issue:

              https://github.com/apache/flink/pull/4216

              Thanks for review.

              Show
              githubbot ASF GitHub Bot added a comment - Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/4216 Thanks for review.
              Hide
              Permalink
              githubbot ASF GitHub Bot added a comment -

              Github user asfgit closed the pull request at:

              https://github.com/apache/flink/pull/4216

              Show
              githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4216
              Hide
              Permalink
              tzulitai Tzu-Li (Gordon) Tai added a comment -

              Fixed for 1.3 via ea48a4d668dbd468b29c1c1ec7055439c164ed57.
              Fixed for master via 9ed9ea6ffdc4f16c1babd1300fe662f2b31d5106.

              Show
              tzulitai Tzu-Li (Gordon) Tai added a comment - Fixed for 1.3 via ea48a4d668dbd468b29c1c1ec7055439c164ed57. Fixed for master via 9ed9ea6ffdc4f16c1babd1300fe662f2b31d5106.

                People

                • Assignee:
                  mingleizhang mingleizhang
                  Reporter:
                  Zentol Chesnay Schepler
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development