[FLINK-6670] Remove CommonTestUtils.createTempDirectory()

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.7.0
• Component/s: Tests
• Labels: pull-request-available
• Assignee: Chesnay Schepler
• Reporter: Nico Kruber
• Created: 23/May/17 07:43
• Updated: 02/Oct/19 17:50
• Resolved: 20/Aug/18 15:37

Description

CommonTestUtils.createTempDirectory() encourages a dangerous design pattern with potential concurrency issues in the unit tests as well as the need to cleanup the created directories.
Instead, it should be solved by using the following pattern:

        @Rule
        public TemporaryFolder tempFolder = new TemporaryFolder();

We should therefore remove CommonTestUtils.createTempDirectory().

Issue Links

• is related to: FLINK-5860 Replace all the file creating from java.io.tmpdir with TemporaryFolder
• links to: GitHub Pull Request #6581