Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6644

Don't register HUP unix signal handler on Windows

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.4.0
    • Fix Version/s: 1.3.0, 1.4.0
    • Component/s: Local Runtime
    • Labels:
      None

      Description

      The JM/TM register UNIX signal handlers for INT, HUP and TERM on startup.

      On Windows, HUP is not available, causing this exception to be logged everytime:

      2017-05-19 16:49:58,777 INFO  org.apache.flink.runtime.taskmanager.TaskManager              - Error while registering signal handler
      java.lang.IllegalArgumentException: Unknown signal: HUP
              at sun.misc.Signal.<init>(Unknown Source)
              at org.apache.flink.runtime.util.SignalHandler$Handler.<init>(SignalHandler.java:41)
              at org.apache.flink.runtime.util.SignalHandler.register(SignalHandler.java:78)
              at org.apache.flink.runtime.taskmanager.TaskManager$.main(TaskManager.scala:1525)
              at org.apache.flink.runtime.taskmanager.TaskManager.main(TaskManager.scala)
      2017-05-19 16:49:58,778 INFO  org.apache.flink.runtime.taskmanager.TaskManager              - Registered UNIX signal handlers for [TERM, INT]
      

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user zentol opened a pull request:

          https://github.com/apache/flink/pull/3955

          FLINK-6644 Don't register HUP signal handler on Windows

          No longer registers the HUP signal handler on Windows to reduce noise in the logs as it is not available on windows.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/zentol/flink 6644_hup_windows

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3955.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3955


          commit 5e972db09853ee7d192ff21b0dc369595b0489ec
          Author: zentol <chesnay@apache.org>
          Date: 2017-05-19T15:34:47Z

          FLINK-6644 Don't register HUP signal handler on Windows


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/3955 FLINK-6644 Don't register HUP signal handler on Windows No longer registers the HUP signal handler on Windows to reduce noise in the logs as it is not available on windows. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zentol/flink 6644_hup_windows Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3955.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3955 commit 5e972db09853ee7d192ff21b0dc369595b0489ec Author: zentol <chesnay@apache.org> Date: 2017-05-19T15:34:47Z FLINK-6644 Don't register HUP signal handler on Windows
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user greghogan commented on the issue:

          https://github.com/apache/flink/pull/3955

          +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3955 +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3955

          merging.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3955 merging.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3955

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3955
          Hide
          Zentol Chesnay Schepler added a comment -

          1.3: fcf8466a5aad27f55915801953ba095a2233a9ff
          1.4: 654d0ede97c4368b8323c6cc7dd382e1860df55e

          Show
          Zentol Chesnay Schepler added a comment - 1.3: fcf8466a5aad27f55915801953ba095a2233a9ff 1.4: 654d0ede97c4368b8323c6cc7dd382e1860df55e

            People

            • Assignee:
              Zentol Chesnay Schepler
              Reporter:
              Zentol Chesnay Schepler
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development