[FLINK-6632] Fix parameter case sensitive error for test passing/rejecting filter API

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.3.0, 1.4.0
• Component/s: Table SQL / API
• Assignee: sunjincheng
• Reporter: sunjincheng
• Created: 19/May/17 03:58
• Updated: 22/May/17 17:03
• Resolved: 22/May/17 17:03

Description

TableAPI testAllPassingFilter:

 
   val t = util.addTable[(Int, Long, String)]('int, 'long, 'string)
    val resScala = t.filter(Literal(true)).select('int as 'myInt, 'string)
    val resJava = t.filter("TrUe").select("int as myInt, string")

We got error:

org.apache.flink.table.api.ValidationException: Cannot resolve [TrUe] given input [int, long, string].

The error is caused by :

    lazy val boolLiteral: PackratParser[Expression] = ("true" | "false") ^^ {
    str => Literal(str.toBoolean)
  }

I want improve the method as follow:

 lazy val boolLiteral: PackratParser[Expression] =
    ("(t|T)(r|R)(u|U)(e|E)".r | "(f|F)(a|A)(l|L)(s|S)(e|E)".r) ^^ { str => Literal(str.toBoolean)}

Is there any drawback to this improvement? Welcome anyone feedback ?

Issue Links

• links to: GitHub Pull Request #3944