Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6593

Fix Bug in ProctimeAttribute or RowtimeAttribute with CodeGenerator

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.3.0, 1.4.0
    • Component/s: Table API & SQL
    • Labels:
      None

      Description

      the ProctimeAttribute or RowtimeAttribute should not be take into codegenerator

        Issue Links

          Activity

          Hide
          twalthr Timo Walther added a comment -

          Fixed in 1.4: 06afac21bca519c50682794fd2610d2f80371897
          Fixed in 1.3: fc2012702b03989a15b2198b1988ca99de7f4889

          Show
          twalthr Timo Walther added a comment - Fixed in 1.4: 06afac21bca519c50682794fd2610d2f80371897 Fixed in 1.3: fc2012702b03989a15b2198b1988ca99de7f4889
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3918

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3918
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user twalthr commented on the issue:

          https://github.com/apache/flink/pull/3918

          Merging this...

          Show
          githubbot ASF GitHub Bot added a comment - Github user twalthr commented on the issue: https://github.com/apache/flink/pull/3918 Merging this...
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user Xpray opened a pull request:

          https://github.com/apache/flink/pull/3918

          FLINK-6593 Fix Bug in ProctimeAttribute or RowtimeAttribute with Co…

          …deGenerator

          Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
          If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
          In addition to going through the list, please provide a meaningful description of your changes.

          • [x] General
          • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
          • The pull request addresses only one issue
          • Each commit in the PR has a meaningful commit message (including the JIRA id)
          • [ ] Documentation
          • Documentation has been added for new functionality
          • Old documentation affected by the pull request has been updated
          • JavaDoc for public methods has been added
          • [x] Tests & Build
          • Functionality added by the pull request is covered by tests
          • `mvn clean verify` has been executed successfully locally or a Travis build has passed

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/Xpray/flink FLINK-6593

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3918.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3918


          commit d94cdf027a14512314c3f58baee996d345d3b2d7
          Author: Xpray <leonxpray@gmail.com>
          Date: 2017-05-16T08:59:14Z

          FLINK-6593 Fix Bug in ProctimeAttribute or RowtimeAttribute with CodeGenerator


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user Xpray opened a pull request: https://github.com/apache/flink/pull/3918 FLINK-6593 Fix Bug in ProctimeAttribute or RowtimeAttribute with Co… …deGenerator Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide] ( http://flink.apache.org/how-to-contribute.html ). In addition to going through the list, please provide a meaningful description of your changes. [x] General The pull request references the related JIRA issue (" [FLINK-XXX] Jira title text") The pull request addresses only one issue Each commit in the PR has a meaningful commit message (including the JIRA id) [ ] Documentation Documentation has been added for new functionality Old documentation affected by the pull request has been updated JavaDoc for public methods has been added [x] Tests & Build Functionality added by the pull request is covered by tests `mvn clean verify` has been executed successfully locally or a Travis build has passed You can merge this pull request into a Git repository by running: $ git pull https://github.com/Xpray/flink FLINK-6593 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3918.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3918 commit d94cdf027a14512314c3f58baee996d345d3b2d7 Author: Xpray <leonxpray@gmail.com> Date: 2017-05-16T08:59:14Z FLINK-6593 Fix Bug in ProctimeAttribute or RowtimeAttribute with CodeGenerator
          Hide
          RuidongLi Ruidong Li added a comment -

          Hi, I have fixed it, you can review later today

          Show
          RuidongLi Ruidong Li added a comment - Hi, I have fixed it, you can review later today
          Hide
          twalthr Timo Walther added a comment -

          Ruidong Li have you started with this issue? I can also fix it if you like.

          Show
          twalthr Timo Walther added a comment - Ruidong Li have you started with this issue? I can also fix it if you like.

            People

            • Assignee:
              RuidongLi Ruidong Li
              Reporter:
              RuidongLi Ruidong Li
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development