Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6561

GlobFilePathFilterTest#testExcludeFilenameWithStart fails on Windows

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 1.3.0, 1.4.0
    • Fix Version/s: 1.3.0, 1.4.0
    • Component/s: Tests
    • Labels:
      None

      Description

      The test fails because it verifies that a file containing an asterisk * is still properly filtered. This character however is not allowed in file names, causing an exception when the nio Path is generated.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user zentol opened a pull request:

          https://github.com/apache/flink/pull/3878

          FLINK-6561 Disable glob test on Windows

          This PR disables a test case in the `GlobFilePathFilterTest`. The test verified that a file name containing asterisks `` was properly filtered out; this however can't succeed on Windows since asterisks aren't allowed in file names in the first place. The creation of a nio path for such a file name throws an exception.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/zentol/flink 6561_glog_test

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3878.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3878


          commit f75edf840a1fb8633543518449f9373e40598001
          Author: zentol <chesnay@apache.org>
          Date: 2017-05-11T19:24:02Z

          FLINK-6561 Disable glob test on Windows


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/3878 FLINK-6561 Disable glob test on Windows This PR disables a test case in the `GlobFilePathFilterTest`. The test verified that a file name containing asterisks ` ` was properly filtered out; this however can't succeed on Windows since asterisks aren't allowed in file names in the first place. The creation of a nio path for such a file name throws an exception. You can merge this pull request into a Git repository by running: $ git pull https://github.com/zentol/flink 6561_glog_test Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3878.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3878 commit f75edf840a1fb8633543518449f9373e40598001 Author: zentol <chesnay@apache.org> Date: 2017-05-11T19:24:02Z FLINK-6561 Disable glob test on Windows
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3878

          Looks good, +1 to merge

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3878 Looks good, +1 to merge
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol commented on the issue:

          https://github.com/apache/flink/pull/3878

          Merging.

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol commented on the issue: https://github.com/apache/flink/pull/3878 Merging.
          Hide
          Zentol Chesnay Schepler added a comment -

          1.3: f3ce0885fc09b3b6853e8f662a15ca3a3c4b26e4
          1.4: 7173774d0cd2b9d138587759d324e6633c24b6bd

          Show
          Zentol Chesnay Schepler added a comment - 1.3: f3ce0885fc09b3b6853e8f662a15ca3a3c4b26e4 1.4: 7173774d0cd2b9d138587759d324e6633c24b6bd
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user zentol closed the pull request at:

          https://github.com/apache/flink/pull/3878

          Show
          githubbot ASF GitHub Bot added a comment - Github user zentol closed the pull request at: https://github.com/apache/flink/pull/3878

            People

            • Assignee:
              Zentol Chesnay Schepler
              Reporter:
              Zentol Chesnay Schepler
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development