[FLINK-6530] Unclosed Response in DatadogHttpClient#validateApiKey()

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.3.0, 1.4.0
• Assignee: Chesnay Schepler
• Reporter: Ted Yu
• Created: 10/May/17 16:08
• Updated: 13/May/17 19:48
• Resolved: 13/May/17 19:48

Description

Here is related code:

    try {
      Response response = client.newCall(r).execute();
      if (!response.isSuccessful()) {
        throw new IllegalArgumentException(
          String.format("API key: %s is invalid", apiKey));
      }
    } catch(IOException e) {
      throw new IllegalStateException("Failed contacting Datadog to validate API key", e);

If execute() throws exception, the Response instance would be left unclosed.

Issue Links

• links to: GitHub Pull Request #3892