Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6509

TestingListener might miss JobLeader notifications

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.3.0
    • Component/s: Tests
    • Labels:
      None

      Description

      The TestingListener might miss JobLeader notifications because it does not perform the check under the lock. This should be changed.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user tillrohrmann opened a pull request:

          https://github.com/apache/flink/pull/3853

          FLINK-6509 [tests] Perform TestingListener#waitForNewLeader under lock

          Performin TestingListener#waitForNewLeader under the lock which is also hold when
          updating the leader information makes sure that leader changes won't go unnoticed.
          This led before to failing test cases due to timeouts.

          cc @StefanRRichter.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/tillrohrmann/flink fixTestingListener

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3853.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3853


          commit 2e36adb971d20892e179a4980ee1fc2ec2133e7b
          Author: Till Rohrmann <trohrmann@apache.org>
          Date: 2017-05-09T11:13:02Z

          FLINK-6509 [tests] Perform TestingListener#waitForNewLeader under lock

          Performin TestingListener#waitForNewLeader under the lock which is also hold when
          updating the leader information makes sure that leader changes won't go unnoticed.
          This led before to failing test cases due to timeouts.


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/3853 FLINK-6509 [tests] Perform TestingListener#waitForNewLeader under lock Performin TestingListener#waitForNewLeader under the lock which is also hold when updating the leader information makes sure that leader changes won't go unnoticed. This led before to failing test cases due to timeouts. cc @StefanRRichter. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink fixTestingListener Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3853.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3853 commit 2e36adb971d20892e179a4980ee1fc2ec2133e7b Author: Till Rohrmann <trohrmann@apache.org> Date: 2017-05-09T11:13:02Z FLINK-6509 [tests] Perform TestingListener#waitForNewLeader under lock Performin TestingListener#waitForNewLeader under the lock which is also hold when updating the leader information makes sure that leader changes won't go unnoticed. This led before to failing test cases due to timeouts.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StefanRRichter commented on the issue:

          https://github.com/apache/flink/pull/3853

          LGMT +1

          Show
          githubbot ASF GitHub Bot added a comment - Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/3853 LGMT +1
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user tillrohrmann commented on the issue:

          https://github.com/apache/flink/pull/3853

          Thanks for the review @StefanRRichter. Merging this PR.

          Show
          githubbot ASF GitHub Bot added a comment - Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3853 Thanks for the review @StefanRRichter. Merging this PR.
          Hide
          till.rohrmann Till Rohrmann added a comment -

          Fixed via f74bb74fb48216a6739c38abf9feb608ac69f837

          Show
          till.rohrmann Till Rohrmann added a comment - Fixed via f74bb74fb48216a6739c38abf9feb608ac69f837
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/flink/pull/3853

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3853

            People

            • Assignee:
              till.rohrmann Till Rohrmann
              Reporter:
              till.rohrmann Till Rohrmann
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development