Uploaded image for project: 'Flink'
  1. Flink
  2. FLINK-6508

Include license files of packaged dependencies

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 1.3.0, 1.2.1, 1.4.0
    • Fix Version/s: 1.3.0, 1.4.0
    • Component/s: Table API & SQL
    • Labels:
      None

      Description

      The Maven artifact for flink-table bundles its (non-Flink) dependencies to have a self-contained JAR file that can be moved to the ./lib folder without adding additional dependencies.

      Currently, we include Apache Calcite, Guava (relocates and required by Calcite), Janino, and Reflections.
      Janino and Reflections are not under Apache license, so we need to include their license files into the JAR file.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user fhueske opened a pull request:

          https://github.com/apache/flink/pull/3852

          FLINK-6508 [table] Include license files of packaged dependencies.

          Adds the license files of Janino and Reflections to the resources folder and copies them into the JAR file under `./META-INF/PACKAGED_LICENSES/`.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/fhueske/flink table-license

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/flink/pull/3852.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #3852



          Show
          githubbot ASF GitHub Bot added a comment - GitHub user fhueske opened a pull request: https://github.com/apache/flink/pull/3852 FLINK-6508 [table] Include license files of packaged dependencies. Adds the license files of Janino and Reflections to the resources folder and copies them into the JAR file under `./META-INF/PACKAGED_LICENSES/`. You can merge this pull request into a Git repository by running: $ git pull https://github.com/fhueske/flink table-license Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/3852.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3852
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user greghogan commented on the issue:

          https://github.com/apache/flink/pull/3852

          Should we add a stronger attribution as in Flink's main `LICENSE` file?

          Show
          githubbot ASF GitHub Bot added a comment - Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3852 Should we add a stronger attribution as in Flink's main `LICENSE` file?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3852

          @greghogan the main `LICENSE` file refers only to the source release.
          We don't redistribute our dependencies in source or binary there (unlike the javascript libraries for the web UI that we actually do redistribute in source).

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3852 @greghogan the main `LICENSE` file refers only to the source release. We don't redistribute our dependencies in source or binary there (unlike the javascript libraries for the web UI that we actually do redistribute in source).
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3852

          @fhueske I think the licenses should not be in `src/main/resources`, brause that packs them into the code as well. Then we have the license twice, one packaged from `src/main/resources`, once from the transformer.

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3852 @fhueske I think the licenses should not be in `src/main/resources`, brause that packs them into the code as well. Then we have the license twice, one packaged from `src/main/resources`, once from the transformer.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user StephanEwen commented on the issue:

          https://github.com/apache/flink/pull/3852

          @fhueske I worked on getting the ASM license in all shaded JAR files. That change would subsume this one. Can you have a look what you think?

          BTW: I could not use the shade resource transformer for the ASM license, because of the way that maven/shade handles relative paths and due to the fact that the resource transformer fails when a dependency already brings the same file.

          Lesson learned today: It sounds simple to add a specific file in various projects to a JAR. But to do that with Maven (in a project like Flink) can take the better part of a day

          Show
          githubbot ASF GitHub Bot added a comment - Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3852 @fhueske I worked on getting the ASM license in all shaded JAR files. That change would subsume this one. Can you have a look what you think? BTW: I could not use the shade resource transformer for the ASM license, because of the way that maven/shade handles relative paths and due to the fact that the resource transformer fails when a dependency already brings the same file. Lesson learned today: It sounds simple to add a specific file in various projects to a JAR. But to do that with Maven (in a project like Flink) can take the better part of a day
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fhueske commented on the issue:

          https://github.com/apache/flink/pull/3852

          @StephanEwen, looks good to me. I'll close my PR then. Thanks for taking care of the licenses.

          Show
          githubbot ASF GitHub Bot added a comment - Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3852 @StephanEwen, looks good to me. I'll close my PR then. Thanks for taking care of the licenses.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user fhueske closed the pull request at:

          https://github.com/apache/flink/pull/3852

          Show
          githubbot ASF GitHub Bot added a comment - Github user fhueske closed the pull request at: https://github.com/apache/flink/pull/3852
          Hide
          StephanEwen Stephan Ewen added a comment -

          Fixed in

          • 1.3.0 via 1b2173712dea5a5b95633af82623bd45785965ce
          • 1.4.0 via 2ff5931982111f37dd51895b7110c6074cb53276
          Show
          StephanEwen Stephan Ewen added a comment - Fixed in 1.3.0 via 1b2173712dea5a5b95633af82623bd45785965ce 1.4.0 via 2ff5931982111f37dd51895b7110c6074cb53276

            People

            • Assignee:
              fhueske Fabian Hueske
              Reporter:
              fhueske Fabian Hueske
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development